From patchwork Tue Jan 28 18:02:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sagar Shrikant Kadam X-Patchwork-Id: 1230475 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=selector1 header.b=Abj7B8n3; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 486ZGd4vx2z9sNF for ; Wed, 29 Jan 2020 05:03:05 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B9F8B81B10; Tue, 28 Jan 2020 19:02:42 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.b="Abj7B8n3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id AC28181B0F; Tue, 28 Jan 2020 19:02:33 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: * X-Spam-Status: No, score=1.3 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER,SPF_HELO_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2061d.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eab::61d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 289CB81B02 for ; Tue, 28 Jan 2020 19:02:30 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sagar.kadam@sifive.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RakrP2vC+VAb+8d1UBr5igcQNynGSQjkUJyMG1TuvVWIBeFY4cvbS7zwGYIj5sOpOy07aXJnhAtgtrzlOb4NrzMGseQRj86gcAgIco90XNbop02hLpf5I0yTJ1IgBLUUyVix2N/3+FTOG8YNaCjNvyS0+y0MZlW8Zop4m7UyqhPhol/MB8e2StMJY7v3pOo54vBzIKg+9c0U6UTANjYYAor3fNW5OTnInaIRH4WaDJcm952eUCQ7prRrQIS8ddaEmzEE2lbmrDrr7dbK3HC+Mtd5HUHgvp7zwG2BtIT5HGaKRsXSZm65AoETKRZdfgtCLRMEDIo1RrlLceJV8vPMOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7MOpRZIfMs2QR9q1FvkIDnrv/utuAZPyeTFMB0/rgzk=; b=V01eMns/3m892Sdq9GVQace/04Kzp1KTkNKM29yzDgmmOGbF/TYISts47rwpEd13F4kGx0AItHzAIDYuH5g4dvDqOSujl4VVTqHmWipQnHpq0TkMz8TiOSVmR+jT/DkhOU3+S8kEEfG8v7pGkiEMkQ44YzYiFH5iL5STiPkc5l/3LVCmgsWvaeBep9AhTRke25IhvGygcGzNE7poN7xnOkpJqtyejkr93FlCK1INd5jwKmokAx3kRIQXFbwWyvLrMDP8zV5ykkHEgyyE8qjl3TSA4noc3s3Y2DSgJjyTyT+OJBgJiMnO47FhZqhBbft7EI5U9tfm+eIMnJz9DWl1qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sifive.com; dmarc=pass action=none header.from=sifive.com; dkim=pass header.d=sifive.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7MOpRZIfMs2QR9q1FvkIDnrv/utuAZPyeTFMB0/rgzk=; b=Abj7B8n3zGmE1ooWYHm6v+HyJWHamHswcNQQbIos2uKJPYeCGjjqDeeu/HZ8R/NJVnhG1SMnvnMDGu+1ZOA7eGK4pjd5/FePS/Z9GWPB7dGiYCN+Qf6UeDfegb9Ss/SzLyWYBlpzMOV8SK4B03Jq00l03f95axoSjrMWaAJl2D4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=sagar.kadam@sifive.com; Received: from DM6PR13MB2442.namprd13.prod.outlook.com (20.176.101.153) by DM6PR13MB3803.namprd13.prod.outlook.com (10.186.141.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.12; Tue, 28 Jan 2020 18:02:27 +0000 Received: from DM6PR13MB2442.namprd13.prod.outlook.com ([fe80::20cf:e8b3:b1e:c8b0]) by DM6PR13MB2442.namprd13.prod.outlook.com ([fe80::20cf:e8b3:b1e:c8b0%7]) with mapi id 15.20.2686.019; Tue, 28 Jan 2020 18:02:27 +0000 From: Sagar Shrikant Kadam To: u-boot@lists.denx.de Subject: [U-Boot Patch v2 2/4] spi: fu540: add claim and release method to spi-sifive.c Date: Tue, 28 Jan 2020 10:02:05 -0800 Message-Id: <1580234527-29280-3-git-send-email-sagar.kadam@sifive.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1580234527-29280-1-git-send-email-sagar.kadam@sifive.com> References: <1580234527-29280-1-git-send-email-sagar.kadam@sifive.com> X-ClientProxiedBy: CO1PR15CA0102.namprd15.prod.outlook.com (2603:10b6:101:21::22) To DM6PR13MB2442.namprd13.prod.outlook.com (2603:10b6:5:cb::25) MIME-Version: 1.0 Received: from gamma07.internal.sifive.com (64.62.193.194) by CO1PR15CA0102.namprd15.prod.outlook.com (2603:10b6:101:21::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.2665.22 via Frontend Transport; Tue, 28 Jan 2020 18:02:27 +0000 X-Mailer: git-send-email 2.7.4 X-Originating-IP: [64.62.193.194] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 95f44b76-c7f8-466a-eb24-08d7a41c3c79 X-MS-TrafficTypeDiagnostic: DM6PR13MB3803: X-LD-Processed: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-Forefront-PRVS: 029651C7A1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(346002)(136003)(39840400004)(376002)(396003)(199004)(189003)(8936002)(478600001)(66476007)(2906002)(956004)(2616005)(8676002)(316002)(6486002)(7696005)(6666004)(86362001)(26005)(16526019)(186003)(4326008)(107886003)(52116002)(66946007)(66556008)(5660300002)(6916009)(81166006)(36756003)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR13MB3803; H:DM6PR13MB2442.namprd13.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: sifive.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n6BjMGTXgldJRCIgOvaqYDJ7q/9TRTG+1nFkoJ7cO/tEzg6XzCKwPhokirN2OkYtGrDg/mKX4XxT1yD/RVjxLYT5hvJ/gGVtgiVx2+dju5CbQSl8lrxrsBhO2/zFlJfJAfvcPqdUTas+yuDsZ40zvHkPauSnjkwaNm6LYwYFSMpHJcBPudEHiz+hL3AEoGGozajNu6LRzkmMV+hGiYzpJqEJOR+uY6WoLR10rFrIBloRN6kPgWQuDp2uRSwzx98Rr4DiVF76HSLIoFr+m73HvVetqEofGjdOLqF7RUF0VlTe82Vev0ieRFNmuT0rdPw6wAqrVAgPeWqygPRt8jjYVS0MLMLcDxyx+8G1kGCpHbgg/7r9J+zUcsfzT1ATQ8a1VR12G+OvNIoVuzXHpNg+O8FNyYY9zSh+m/QzM18UCH6HpgRN3Hw2LItSiejjMyJ4 X-MS-Exchange-AntiSpam-MessageData: 1avcU6VBEt1eEJH+PxJpMC31P39hWuZIkUxlslLgt0iMiW8xV3XQF4Pfj3vchlX4Ejc8cNpsK8jH2YCdPrATGvSEuAj82g1EHYKOJng/VAhbZXvrhdLbKAQgxOkpXI0ftbsE4Mj5f4y2TP9QJXKpBQ== X-OriginatorOrg: sifive.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95f44b76-c7f8-466a-eb24-08d7a41c3c79 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jan 2020 18:02:27.8186 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: tFi83eTe2t1IBdWsYKGkZcyaP92Q5QkUAHSakLB+TpKpnPQcyNbbCCnnMnzRrsaOQBZEwD4aJhXZpCqEcyTm7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB3803 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.26 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.101.4 at phobos.denx.de X-Virus-Status: Clean Add missing bus claim/release method to spi driver for HiFive Unleashed, and handle num_cs generously so that it generates an error if invalid cs number is passed to sf probe. Signed-off-by: Sagar Shrikant Kadam --- drivers/spi/spi-sifive.c | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/drivers/spi/spi-sifive.c b/drivers/spi/spi-sifive.c index 969bd4b..f990ad6 100644 --- a/drivers/spi/spi-sifive.c +++ b/drivers/spi/spi-sifive.c @@ -186,6 +186,36 @@ static void sifive_spi_tx(struct sifive_spi *spi, const u8 *tx_ptr) writel(tx_data, spi->regs + SIFIVE_SPI_REG_TXDATA); } +static int sifive_spi_claim_bus(struct udevice *dev) +{ + int ret; + struct udevice *bus = dev->parent; + struct sifive_spi *spi = dev_get_priv(bus); + struct dm_spi_slave_platdata *slave = dev_get_parent_platdata(dev); + + if (!(slave->cs < spi->num_cs)) { + printf("Invalid cs number = %d\n", slave->cs); + return -EINVAL; + } + + sifive_spi_prep_device(spi, slave); + + ret = sifive_spi_set_cs(spi, slave); + if (ret) + return ret; + + return 0; +} + +static int sifive_spi_release_bus(struct udevice *dev) +{ + struct sifive_spi *spi = dev_get_priv(dev->parent); + + sifive_spi_clear_cs(spi); + + return 0; +} + static int sifive_spi_xfer(struct udevice *dev, unsigned int bitlen, const void *dout, void *din, unsigned long flags) { @@ -345,6 +375,10 @@ static int sifive_spi_probe(struct udevice *bus) /* init the sifive spi hw */ sifive_spi_init_hw(spi); + /* Fetch number of chip selects from DT if present */ + ret = dev_read_u32_default(bus, "num-cs", spi->num_cs); + spi->num_cs = ret; + return 0; } @@ -353,6 +387,8 @@ static const struct dm_spi_ops sifive_spi_ops = { .set_speed = sifive_spi_set_speed, .set_mode = sifive_spi_set_mode, .cs_info = sifive_spi_cs_info, + .claim_bus = sifive_spi_claim_bus, + .release_bus = sifive_spi_release_bus, }; static const struct udevice_id sifive_spi_ids[] = {