From patchwork Thu Jan 23 20:16:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sagar Shrikant Kadam X-Patchwork-Id: 1228553 X-Patchwork-Delegate: uboot@andestech.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.denx.de (client-ip=2a01:238:438b:c500:173d:9f52:ddab:ee01; helo=phobos.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.a=rsa-sha256 header.s=selector1 header.b=SrS8qQ3t; dkim-atps=neutral Received: from phobos.denx.de (phobos.denx.de [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 483YV76Ybsz9sPK for ; Fri, 24 Jan 2020 07:17:35 +1100 (AEDT) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D6A1A81970; Thu, 23 Jan 2020 21:17:07 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=sifive.com header.i=@sifive.com header.b="SrS8qQ3t"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8B16481938; Thu, 23 Jan 2020 21:16:58 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on phobos.denx.de X-Spam-Level: X-Spam-Status: No, score=0.9 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FORGED_SPF_HELO,MSGID_FROM_MTA_HEADER,SPF_HELO_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.2 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20622.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eaa::622]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7ED63817F2 for ; Thu, 23 Jan 2020 21:16:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sifive.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=sagar.kadam@sifive.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eCAonSEARH4xvUe9BRmeodajxyAOXdtEL8wN6DcEylm4WknPuwvnvTSDI01PWbJCNQ8Md0n3XLv3116+WY/8d0Lw0NXBCzHfp3uXUyo95vUmbIGY+miKzxBjEt8+MALpUuKEizWf0rGbCw8H4nRbUa+7bPglsIpLYk9ve60SSk3evW6s1/CMVvUCPi9XixFhL0u8clHgkjL93//VnATPXbDI0zhQXOHDXMNzOZINOeMza2eqfaOiDdAuBuncTKGortKeEn6T3qRbnydWX4XTlUlBgAfNQsz4QYlVIAnr6v3Y8ulV5pyXkLHrIjzaDI2mU1dgnLGtX5TJ6JyOFzg0Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G4/gXW+XZvnBRYVxITWgEPBph4jrvzN4dzLUKS+T45g=; b=X+dqPUcviK9MJC2g2uMbvBXaIlVpyOYt2ypn9vkMzeb9pkkpj2AMFO4SQ9lJyGASqlxdVI0mk7ohaY3Q/z7UCO7mmstj3W1MeO2mX9cTszdycYqLS11vyYq+x09NXRXPTp/PQnh4s/UVxxErc4c2OCuzkAOZ3gJZCgDDJeXPfGYDaI6yDSXgkKTRgW2lwCwHfsVAZqGYDEPE6X35f5vgHA9Y3wj25raemmE8aSydt8lsjrsJvDpWtXoMHTVi2aZ0K0speKAJuWY6rbBMJouLa6NGJfGfA9GgDooMj7c+cYy3qSPCdB/pfASv+VR2vxdkNtFB/HRbbnwYc2oF/a+Z0w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=sifive.com; dmarc=pass action=none header.from=sifive.com; dkim=pass header.d=sifive.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=G4/gXW+XZvnBRYVxITWgEPBph4jrvzN4dzLUKS+T45g=; b=SrS8qQ3tj/ccu7ax4BiJKCjZGLPf2X89Ew8Jv8f3PDbdwLZirSRVps0H3DeRNA4uPnYYEvjqVvvFdAfodLArcxcd8/HHGeub7g2xIhF+nJzSxp1wwSdPZE0v1xI3Ijrqvtbv0l1E9J5UdU2Zf54iq9HidJxPyN3ovvNWIpfOmwU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=sagar.kadam@sifive.com; Received: from DM6PR13MB2442.namprd13.prod.outlook.com (20.176.101.153) by DM6PR13MB2506.namprd13.prod.outlook.com (20.176.96.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2686.12; Thu, 23 Jan 2020 20:16:52 +0000 Received: from DM6PR13MB2442.namprd13.prod.outlook.com ([fe80::20cf:e8b3:b1e:c8b0]) by DM6PR13MB2442.namprd13.prod.outlook.com ([fe80::20cf:e8b3:b1e:c8b0%7]) with mapi id 15.20.2665.017; Thu, 23 Jan 2020 20:16:52 +0000 From: Sagar Shrikant Kadam To: u-boot@lists.denx.de Subject: [U-Boot Patch v1 4/7] spi: fu540: add claim and release method to spi-sifive.c Date: Thu, 23 Jan 2020 12:16:03 -0800 Message-Id: <1579810566-11675-5-git-send-email-sagar.kadam@sifive.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1579810566-11675-1-git-send-email-sagar.kadam@sifive.com> References: <1579810566-11675-1-git-send-email-sagar.kadam@sifive.com> X-ClientProxiedBy: BYAPR06CA0001.namprd06.prod.outlook.com (2603:10b6:a03:d4::14) To DM6PR13MB2442.namprd13.prod.outlook.com (2603:10b6:5:cb::25) MIME-Version: 1.0 Received: from gamma07.internal.sifive.com (64.62.193.194) by BYAPR06CA0001.namprd06.prod.outlook.com (2603:10b6:a03:d4::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.2644.20 via Frontend Transport; Thu, 23 Jan 2020 20:16:52 +0000 X-Mailer: git-send-email 2.7.4 X-Originating-IP: [64.62.193.194] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7e9fb1dc-c747-4b0a-9388-08d7a0412f82 X-MS-TrafficTypeDiagnostic: DM6PR13MB2506: X-LD-Processed: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5516; X-Forefront-PRVS: 029174C036 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39850400004)(366004)(396003)(376002)(136003)(346002)(189003)(199004)(186003)(6486002)(2906002)(2616005)(26005)(8936002)(81166006)(81156014)(956004)(16526019)(52116002)(316002)(4326008)(7696005)(107886003)(86362001)(8676002)(6916009)(6666004)(66556008)(66476007)(66946007)(478600001)(5660300002)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR13MB2506; H:DM6PR13MB2442.namprd13.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: sifive.com does not designate permitted sender hosts) X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WbtwkFDh7/a78Cw38AqMBoVI9RHLUycbeWBLSDVTATx/bfMV7j2bJ56DcDfTT4ZppCybgpjQC9+1q6THzOBgDNB3xchynDO4G1t7w76XNekoViIsgRhkYQxs1g+FS8tHv+eRP1FV5UA+WfPsJL/P3eVjMQaMCDiGz5/K4HLE/fsK+8zUs6dOJw3Hvs0GEDHlcupiNi8/Me0WbVpBym4VMZHsOlNtJvttP7GG5hbOSG5PU5iN1W+3uqBCUqgB5gRVL+BUtjg6XL10YoCih0ur7PMdUYBwb4QQ/+5j/FNPl9YH8GZ/PPChlYBXORYRQKapUW8ovgnRnCeG2TPFGC/DkNWtKv55PN4FmZy2IiclrwhWUD47PrkQfHs8QyCGqxe7bUzFwbCq99pspHlR3qvl4waAVZQu3xgSDTbcW7WuIUF6fc8/gUJrxzKLy76kn5Rx X-MS-Exchange-AntiSpam-MessageData: oV69mxWjlVljp0JsPoumRDk5skyaiOKcpCia78qL2Hw/0Hs3nc/AfbwOW82itU4DLtAtM/JkB3n7WVASodozMw++Vk+eyT77dPS2EQpIGexL8fiCxkQPDk89ucLff7gavfRVsCx6NjL8MBE12I3Zjg== X-OriginatorOrg: sifive.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e9fb1dc-c747-4b0a-9388-08d7a0412f82 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2020 20:16:52.8988 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 22f88e9d-ae0d-4ed9-b984-cdc9be1529f1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3Fw9RDFSI33JCIH2RAwrf1y1L8rAKNxjWjgguDH6vkpj8s+ndYK5bRxf/OfGXXk2TVi4zWdUk8a/B25m1oZjDg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR13MB2506 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.26 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: atish.patra@wdc.com, ick@andestech.com Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.101.4 at phobos.denx.de X-Virus-Status: Clean Add missing bus claim/release method to spi driver for HiFive Unleashed, and handle num_cs generously so that it generates error if invalid cs number is passed to sf probe. Signed-off-by: Sagar Shrikant Kadam --- drivers/spi/spi-sifive.c | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/drivers/spi/spi-sifive.c b/drivers/spi/spi-sifive.c index 969bd4b..f990ad6 100644 --- a/drivers/spi/spi-sifive.c +++ b/drivers/spi/spi-sifive.c @@ -186,6 +186,36 @@ static void sifive_spi_tx(struct sifive_spi *spi, const u8 *tx_ptr) writel(tx_data, spi->regs + SIFIVE_SPI_REG_TXDATA); } +static int sifive_spi_claim_bus(struct udevice *dev) +{ + int ret; + struct udevice *bus = dev->parent; + struct sifive_spi *spi = dev_get_priv(bus); + struct dm_spi_slave_platdata *slave = dev_get_parent_platdata(dev); + + if (!(slave->cs < spi->num_cs)) { + printf("Invalid cs number = %d\n", slave->cs); + return -EINVAL; + } + + sifive_spi_prep_device(spi, slave); + + ret = sifive_spi_set_cs(spi, slave); + if (ret) + return ret; + + return 0; +} + +static int sifive_spi_release_bus(struct udevice *dev) +{ + struct sifive_spi *spi = dev_get_priv(dev->parent); + + sifive_spi_clear_cs(spi); + + return 0; +} + static int sifive_spi_xfer(struct udevice *dev, unsigned int bitlen, const void *dout, void *din, unsigned long flags) { @@ -345,6 +375,10 @@ static int sifive_spi_probe(struct udevice *bus) /* init the sifive spi hw */ sifive_spi_init_hw(spi); + /* Fetch number of chip selects from DT if present */ + ret = dev_read_u32_default(bus, "num-cs", spi->num_cs); + spi->num_cs = ret; + return 0; } @@ -353,6 +387,8 @@ static const struct dm_spi_ops sifive_spi_ops = { .set_speed = sifive_spi_set_speed, .set_mode = sifive_spi_set_mode, .cs_info = sifive_spi_cs_info, + .claim_bus = sifive_spi_claim_bus, + .release_bus = sifive_spi_release_bus, }; static const struct udevice_id sifive_spi_ids[] = {