From patchwork Wed Dec 12 11:49:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siva Durga Prasad Paladugu X-Patchwork-Id: 1011859 X-Patchwork-Delegate: marek.vasut@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="JOOFOqaH"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 43FFVF2M6cz9s3Z for ; Wed, 12 Dec 2018 22:49:57 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id E7225C228F7; Wed, 12 Dec 2018 11:49:54 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAD_ENC_HEADER, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 33D3AC22518; Wed, 12 Dec 2018 11:49:52 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 2CB42C22518; Wed, 12 Dec 2018 11:49:50 +0000 (UTC) Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-eopbgr800047.outbound.protection.outlook.com [40.107.80.47]) by lists.denx.de (Postfix) with ESMTPS id 8586EC22033 for ; Wed, 12 Dec 2018 11:49:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sk5n/frY/nbQyedWldWQgKWIZdJXHA0MUT3/niYCtX4=; b=JOOFOqaHI/6l8grv8CMAkJvN2b8n+NQldpPqEFhWc+CPujNrcNboddlehJ6Qtb65dxEMn0zP+esM9LQ7yL6lL8PrD5Lmt0Ry0sWztpIfNQhVGnxrsbmVIKPIXRP0ZRnWG9ulKVBmixHB2qjbCYBUsp5jLxM7Xu/jnpClK+/KwC0= Received: from BL0PR02CA0050.namprd02.prod.outlook.com (2603:10b6:207:3d::27) by SN6PR02MB4333.namprd02.prod.outlook.com (2603:10b6:805:a4::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1425.19; Wed, 12 Dec 2018 11:49:47 +0000 Received: from CY1NAM02FT038.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::208) by BL0PR02CA0050.outlook.office365.com (2603:10b6:207:3d::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.1404.22 via Frontend Transport; Wed, 12 Dec 2018 11:49:46 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.100) smtp.mailfrom=xilinx.com; lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.100 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.100; helo=xsj-pvapsmtpgw02; Received: from xsj-pvapsmtpgw02 (149.199.60.100) by CY1NAM02FT038.mail.protection.outlook.com (10.152.74.217) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.1425.16 via Frontend Transport; Wed, 12 Dec 2018 11:49:44 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66]:44788 helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw02 with esmtp (Exim 4.63) (envelope-from ) id 1gX31M-0006yv-57; Wed, 12 Dec 2018 03:49:44 -0800 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1gX31H-0008UA-1c; Wed, 12 Dec 2018 03:49:39 -0800 Received: from [172.23.37.99] (helo=xhdsivadur40.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1gX31F-0008QI-0G; Wed, 12 Dec 2018 03:49:37 -0800 From: Siva Durga Prasad Paladugu To: Date: Wed, 12 Dec 2018 17:19:24 +0530 Message-ID: <1544615364-13206-1-git-send-email-siva.durga.paladugu@xilinx.com> X-Mailer: git-send-email 2.7.4 X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.100; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(39860400002)(136003)(346002)(376002)(396003)(2980300002)(189003)(199004)(486006)(81156014)(36386004)(107886003)(81166006)(63266004)(50466002)(36756003)(8676002)(48376002)(9786002)(50226002)(2906002)(26005)(186003)(5660300001)(4326008)(8936002)(77096007)(14444005)(478600001)(126002)(2351001)(54906003)(106002)(356004)(6666004)(336012)(6916009)(2616005)(316002)(476003)(106466001)(47776003)(51416003)(305945005)(16586007)(426003)(7696005)(107986001)(5001870100001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN6PR02MB4333; H:xsj-pvapsmtpgw02; FPR:; SPF:Pass; LANG:en; PTR:unknown-60-100.xilinx.com,xapps1.xilinx.com; MX:1; A:1; X-Microsoft-Exchange-Diagnostics: 1; CY1NAM02FT038; 1:QoLwn1UdtQC6Kq4lqd30H/e211LnO8f9qJVsmWkZFOohKQG8/DFvwQqOLEkWPtxMN6DvWpRvtcsEFOmur6WJQazOA8Ln5nXfbFzEzd3f3ARaHGo1lNWmhMebLx91H/kf MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2a563388-484d-4f23-9395-08d66027e9b3 X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(2390098)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4608076)(2017052603328)(7153060); SRVR:SN6PR02MB4333; X-Microsoft-Exchange-Diagnostics: 1; SN6PR02MB4333; 3:Hxp1OTtcM0OZ0oPOHGEW0tX4z3kfkha02BnJ7TN6wgrb0DyoaVE03mhKdkTHzDviEt/nTKuoAr2dUW+mtBxqNEzlfx0uvScyF8CmXpjKQ6X+SC2vXPwRELrbFi19Ls+NCKbzYaIsCdyfMDIIPESv5wVhsmWpj+YqYmG1ZRiC5+oZrH83DxtNr4KRjmU8310FDsQquAhwZR+Ki10mAK6OJWK+f0Y4/LqD7Yn2LUEvQbQuuSDPxZCpOVmVSwna64O43zly9MPr5rqkapyzNOIRs+znW7NBBQ07dmbl8s09/+T5Y/yBf38PKZHbRZGdmu5JpBUjtcNQjMGtpbfDddSrTX5J9WJAFcAc+3S43J8vWS8=; 25:EmjjodOMoTJ/4DiEyQ82NdO2HH/4o8c6/CkytzaOlGy4Am8DIA7UTznY4Y05gAV7LFOU/FtRqccuR6Q03/zpSADm8Ksz2u0y8kReMoScdKtT3z2dTOrScSWFepNw/LyewJJhbQEjFDAocw/eww0hMZJ8eTo3kkuihj6/pmPDm6adXqNw1oynJVjU9YMEHKcY+0JCTbzHDLiruyYmPDJtAGc0Go0j8NQCstUhZXWUJ/06px/mH47KypZX9Y1YjoMp+HMY9nMQS5SrRmOCZ9pCKcBfjhxYg5M8faYWHEOrCf2cym5GLdLLVuMrg54X/tsJ9G3HzP73jkLpQewJLYIZ5A== X-MS-TrafficTypeDiagnostic: SN6PR02MB4333: X-Microsoft-Exchange-Diagnostics: 1; SN6PR02MB4333; 31:zunmUdGscvOw7zq6hgOVq8XBCcbkohlvx76gTQncK+MmsE+XPhdmpMum3hLGzfhSZK+7PKiooLu7TWNT2xomM+XBzKC67cBfFUYW/TcyG5XfYSTkZEm/QWt8RP0+5TQ76yGDTzV/0nxJEUSlaAD6q/wca/unr1EUMK6ESzfw3bAxy/R4Jx5bOfmQk4gRM7ba1iu+JPRGwERQMVAJjQoH2RTEYZg0wyJfQKN2Beboc8s=; 20:miMVApIgdwXRv4j44wjNLOTcl/a8Lluim+0r6+CYzzu+UKJyfG+sSnda1iBuOQQ9wcbPEz+DY8t1gaNw5X/57hPdR8iwXROzXOfPAsV/MqAx6umouZviv+v40YsU2GbsZuMD9aU9Ua24U30sM7wYf6lDn1+mf8U+ndV5zftF0xlk95H6LT0xK/QjRg9nqdW+TSKTo/bqEUnbA2O6GXgZboZUWV1z24aeMCrNLqQ1UrNuAA6fqrIKtel1Uv3vVaEdfiL6ILz+G2cKvYCaqfmB/lf2hR5mouhKF8YfRyv583lT/Rf6P/cvTZmtE2hVJGAq77LYRcZs9VX2d2Pzg2IINfW7g1Q3WC7mT1krBGR/+S60vK0Nug9+EMRsXOrZOEas8oudjQEVT+4mpHnFZoEAewM+wFmts3KuE+sxiyZmQEJC+DNiM1H5qa+8lEw0ihOfzwIwgBTPsoj3Quf80RAlimePcM1Cz55UyEGfnihIUIdKoscJAi6ftSLz1T5+RE/K X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93004095)(10201501046)(3231455)(999002)(944501520)(52105112)(3002001)(6055026)(148016)(149066)(150057)(6041310)(20161123560045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(201708071742011)(7699051)(76991095); SRVR:SN6PR02MB4333; BCL:0; PCL:0; RULEID:; SRVR:SN6PR02MB4333; X-Microsoft-Exchange-Diagnostics: 1; SN6PR02MB4333; 4:WSSNPicxew2WQc5gB5lAkfBYM+qZiTxBOFtQ7QECMjCcxr5YN2bQsKtNQGkjfc0cp+t65L3RXPWv02Q9eEffnGDCH4824rESQJP6fJHRdWfjTpX0mj9fBEJibvNSXElnrhqUQYWtyYNJyrDsJVZ008kTXNUvFyMU+TqNn0AQTr32/iZEXCeSAUukk3LAraGjznf2TeS+d2U/sk44ftT2pTNpiHhiuasLvdZ00AGc+npdCHYaED9L35ubU/wpUYExZs0l/4cXy2pZxU8Mid5UZA== X-Forefront-PRVS: 0884AAA693 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN6PR02MB4333; 23:SNbblxUYGihV5zb7A7XMF+JBZ+HqNl+J1L+E22cKh?= r5G//RkL++Tjv2hhg0Aktw2zPT+Z/YNSAWbB3qKnEIQqDRM9iRdmxODsfFEDjJLX+YRKyeL5yE2Vavzb18QCFRMGC1T/8WAeprVC6P1cES5rIsv1hSYOThjBiYV7icUXInz+fRc3KGii/xAAvhqB7k38rM7czjSyiqaQdqRVyXUMisSrw5GN4ysaW9LZQI4W8GVdqDVeQo2M1J2ZxQzVIj7jIFNA7K0uimJFkwRCbEN8QfufOi+hVaSnfmzINAxiFV3NY+c5D89v3Nooc2I3AIGKtMBTAWEBxse16yd5Q3BwamlVvzZQA/py/DidsAZ6jKwXakbEDYjnMyoTmM7YKPu4VZ0oitWAbKO6vToJGx6aKjx9jOsmFf1f3zTGd0GMEv2ggd4Wc0FxSQJ59ySbVUnx+nsnuADRaEtHYDAwa1j7tmTKuaA08zhVctp5IoKMaYD3XQ6rsZb9DWvwDO2e4Wvvn4hWEnh0mRHo4crxsu/mhfPpulJ+RLB2wJUb8WQMi50ZhK6Sgg3o6Oau1QOydnVCOmacfjhMBsBSM5Y8hgMQuA/UdqEE9Mk4ltWGPjZrZqkS5vGI4KVr6+1pW51/idsOK8Q7BnKCcZg70Mo9fFB5gPBN+ndQJeHAzakV+BL4qcw7SkEHXf2JQt8x+6O5WW7bF5Laj7DsJ2vgfsgleaPJu1HhV5EZwzRn0q/e9ytHb80z5q+AxF8b76Gzo0/QnKE9fudOgApAMmr3TzozvGeorJLMP1rmPSOtEA69AhLO0pLQEupN8WIFlE95msc8gzT19TuPfIfArFZK54EvQCFWV0JPo92QaoQddnjbEirz23JEk0eeSpchMz3XpnDNLm1yOf381ix7HzxJGShlZRWXRbf5RxgnhGZZ3xZF9fCULJ9a8XGIfZTeMQoKrKCuL95amB0AFj4kicWYj54NeGYhM6Qz5WzI61MS0WHjScTrPTjEsYYA2QRAmecQrnVkQsJO7rFPwtXbJeuDnU6QS5wZcV2K3eDcVXHlhP0YLacFDo58gmhr2L9PmDGtxnxZZQ9MswJMiyyU8UfsoFGtpcYCQ== X-Microsoft-Antispam-Message-Info: ubG8g16L/Ctn+TAB7J4/aKs8UAsjd9OnkSKhPPG0CRZx4ftPluxyuCN7Uu60DBHehSq318uV3OLPpe3ekDGxGWVDrgtH9vDIbb7pmGfQ1VBi/WPma3eotCbqi97XBMymEuq25+DBRIEXeZs+rQRKqSbl7HCh+6v5K6K2H/fvwYRH6OSwCohy+3Sj5d8i8NDCrapor9c7HGbrXoj2F6H9KPHKOvhwUl+ERhDIVogx60A5qOE5bUPeAMaeV5nWxDqjMdndglyLE73T5VLz1rxVK/UjOEGqWtDLsUexMCn3738= X-Microsoft-Exchange-Diagnostics: 1; SN6PR02MB4333; 6:AolGHRnNiFMDEcPHLizRYmt0TB2rlXyXCBXq+9gcbfZTUrZDzr6MyTOM8NpNjHGAqcvIb5UKDgarjnR2WiAq0i0Rmi+jKaqBXiptAwMhxqzaeqNKWRFF+mXXyxARrUHjLLOa4Oa0DYeOD+nPboFfY8OoWIRtN1n1+ID75Mhl1foZkqKw1WPiWZNu7wgnG4Nnzl2H3wQDnxQB+UvLLFOM8sLkgT5zVvD6Fe9NiBmRb5/L1zZTBTj1PO/0MSdRJEUmZv30MyxM5ASJ6pU6/qAND/N+EgSTJs2E69gCWS1KDQEsgGX2lINrF4IpdRuV3KbXF1fr186VAE5qqhOcd8znUS7h2S8Btbsy6stLXPAAWcjQaKr180yMRzHF7Dh8uTCv9f2zF+SfBg8/CkfwoxSvQrVeyTa3wSdEofNCT4l93ps/ELYodP3a7szECakjjiqPNaOqsKzv+pPumWCP4s0aUg==; 5:O7pu0DDwDmwcQkhQtkVcLMW06lC0aXygkOJDQC3q7sGeugiuwX1hCcKLP1x8bggSVJScuQUvrlu1YCzcnllGP1tGnNjTxSf7usEYVp0jE0TK8xwdAT/uv2/LmBNcxEwmt+TqsJN1cOa7w73UD2j9eeCh+SGdHcLPlpXwWKKuPws=; 7:lle3zAGl9qdThknr/jGTLVZmncJ51tMRhTkxVPqDlxSgr6KWqAAzDa3dsPyhh0NXWIA+0JGzoP+FwVIPZh+wQ0PlgTiG+xAqYfh+HfNpfaEQIh7tExKQf+2Jn45ubbkxzKsYcPSA6+yGx9wHZl6zOQ== SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Dec 2018 11:49:44.8792 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2a563388-484d-4f23-9395-08d66027e9b3 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.100]; Helo=[xsj-pvapsmtpgw02] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR02MB4333 Cc: marex@denx.de, michal.simek@xilinx.com Subject: [U-Boot] [RFC PATCH] usb: composite: Fix max packet size for USB3.0 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" For USB3.0 the max packetsize for GET_DESCRIPTOR should be sent as exponent value for 2. This means for 512, max packet size should be filled with 9(2^9=512). Also, fill the USB version field with 3.0 if speed is negotiated to Superspeed. This fixes the issue of DFU gadget download failure with superspeed. With out this patch, the max packet size is overflowed to zero as the bMaxPacketsize is of u8 and hence host is not able to detect this device. Signed-off-by: Siva Durga Prasad Paladugu Reviewed-by: Bin Meng --- drivers/usb/gadget/composite.c | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c index 5106cc5..c7e7623 100644 --- a/drivers/usb/gadget/composite.c +++ b/drivers/usb/gadget/composite.c @@ -735,8 +735,21 @@ composite_setup(struct usb_gadget *gadget, const struct usb_ctrlrequest *ctrl) case USB_DT_DEVICE: cdev->desc.bNumConfigurations = count_configs(cdev, USB_DT_DEVICE); - cdev->desc.bMaxPacketSize0 = - cdev->gadget->ep0->maxpacket; + + /* + * If the speed is Super speed, then the supported + * max packet size is 512 and it should be sent as + * exponent of 2. So, 9(2^9=512) should be filled in + * bMaxPacketSize0. Also fill USB version as 3.0 + * if speed is Super speed. + */ + if (cdev->gadget->speed == USB_SPEED_SUPER) { + cdev->desc.bMaxPacketSize0 = 9; + cdev->desc.bcdUSB = cpu_to_le16(0x0300); + } else { + cdev->desc.bMaxPacketSize0 = + cdev->gadget->ep0->maxpacket; + } value = min(w_length, (u16) sizeof cdev->desc); memcpy(req->buf, &cdev->desc, value); break;