From patchwork Tue May 29 14:22:43 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Siva Durga Prasad Paladugu X-Patchwork-Id: 922140 X-Patchwork-Delegate: monstr@monstr.eu Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=xilinx.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=xilinx.onmicrosoft.com header.i=@xilinx.onmicrosoft.com header.b="BRocA1oS"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 40wGDN0rY9z9rvt for ; Wed, 30 May 2018 00:23:30 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id DEF65C21ECA; Tue, 29 May 2018 14:23:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAD_ENC_HEADER, SPF_HELO_PASS, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id D98A6C21E29; Tue, 29 May 2018 14:23:22 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 2F381C21E31; Tue, 29 May 2018 14:23:21 +0000 (UTC) Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0052.outbound.protection.outlook.com [104.47.33.52]) by lists.denx.de (Postfix) with ESMTPS id 731CCC21E29 for ; Tue, 29 May 2018 14:23:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector1-xilinx-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KFnQBrgIkq2jjx8TkhYwMsDGiBGAQ9KVbjOSfsnlG3U=; b=BRocA1oSWvIx+Ny9jBk2Ti4RB3Yj7MICO+dbCvffsOYlAASnHlc2mmhV1zeEP8mF4V+xQRrOqx7gfp5tYD4DcGn4dQ35RsUUUm64wNTYGzCADkmmZWZ4Sdd3v9O3pd0gRgLlyTfHKESKg5CiWb6GOg5OMH9sWImsChW52ue4Ovk= Received: from BN6PR02CA0038.namprd02.prod.outlook.com (2603:10b6:404:5f::24) by BYAPR02MB4135.namprd02.prod.outlook.com (2603:10b6:a02:fa::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.797.11; Tue, 29 May 2018 14:23:18 +0000 Received: from CY1NAM02FT034.eop-nam02.prod.protection.outlook.com (2a01:111:f400:7e45::202) by BN6PR02CA0038.outlook.office365.com (2603:10b6:404:5f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.797.11 via Frontend Transport; Tue, 29 May 2018 14:23:17 +0000 Authentication-Results: spf=pass (sender IP is 149.199.60.83) smtp.mailfrom=xilinx.com; lists.denx.de; dkim=none (message not signed) header.d=none;lists.denx.de; dmarc=bestguesspass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.60.83 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.60.83; helo=xsj-pvapsmtpgw01; Received: from xsj-pvapsmtpgw01 (149.199.60.83) by CY1NAM02FT034.mail.protection.outlook.com (10.152.75.190) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.20.820.8 via Frontend Transport; Tue, 29 May 2018 14:23:16 +0000 Received: from unknown-38-66.xilinx.com ([149.199.38.66] helo=xsj-pvapsmtp01) by xsj-pvapsmtpgw01 with esmtp (Exim 4.63) (envelope-from ) id 1fNfWu-0008WT-6E for u-boot@lists.denx.de; Tue, 29 May 2018 07:23:16 -0700 Received: from [127.0.0.1] (helo=localhost) by xsj-pvapsmtp01 with smtp (Exim 4.63) (envelope-from ) id 1fNfWp-0007WN-3x for u-boot@lists.denx.de; Tue, 29 May 2018 07:23:11 -0700 Received: from xsj-pvapsmtp01 (smtp3.xilinx.com [149.199.38.66]) by xsj-smtp-dlp1.xlnx.xilinx.com (8.13.8/8.13.1) with ESMTP id w4TEN8rb013297; Tue, 29 May 2018 07:23:08 -0700 Received: from [172.23.37.99] (helo=xhdsivadur40.xilinx.com) by xsj-pvapsmtp01 with esmtp (Exim 4.63) (envelope-from ) id 1fNfWl-0007VN-Pj; Tue, 29 May 2018 07:23:08 -0700 From: Siva Durga Prasad Paladugu To: Date: Tue, 29 May 2018 19:52:43 +0530 Message-ID: <1527603765-24481-1-git-send-email-siva.durga.paladugu@xilinx.com> X-Mailer: git-send-email 2.7.4 X-RCIS-Action: ALLOW X-TM-AS-Product-Ver: IMSS-7.1.0.1224-8.2.0.1013-23620.005 X-TM-AS-User-Approved-Sender: Yes;Yes X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:149.199.60.83; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(376002)(346002)(396003)(39860400002)(39380400002)(2980300002)(438002)(199004)(189003)(36386004)(426003)(5660300001)(106466001)(59450400001)(2616005)(36756003)(336012)(476003)(50466002)(316002)(2351001)(106002)(54906003)(5890100001)(47776003)(8676002)(8936002)(26005)(6916009)(6666003)(50226002)(356003)(48376002)(9786002)(305945005)(77096007)(81166006)(81156014)(107886003)(126002)(7696005)(51416003)(2906002)(478600001)(63266004)(8746002)(4326008)(486006)(186003)(107986001); DIR:OUT; SFP:1101; SCL:1; SRVR:BYAPR02MB4135; H:xsj-pvapsmtpgw01; FPR:; SPF:Pass; LANG:en; PTR:unknown-60-83.xilinx.com; A:1; MX:1; X-Microsoft-Exchange-Diagnostics: 1; CY1NAM02FT034; 1:wpk9GUDqhfxDMl1K4+Nt2tgmJY30pVF6DWN/vUW6DBkyKgbKrlTGHDIUS8hoKKyVJl9csazd2Rexbvi5MIrZAmBYjtrwvKPXWa4WQnChJVWoKsF6b2Sml4d54qPNCnkn MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4608076)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060); SRVR:BYAPR02MB4135; X-Microsoft-Exchange-Diagnostics: 1; BYAPR02MB4135; 3:7fCQrSiNjeJ77802OP2cH9QIA/v3KQZXm8noWLNn3atH6ohnYgG0dxyqHZCcjdGb+K28HubecB+PBOZxJbfIWGBWKVMXpbt+MEPuoVR873wBSMnioz1/Velayig9T9qpsdpQmeKi0ooc+1qojBhaiXxbD4z+m3u1RQh+Za04MeEB5/L8EK49YEE6cxX37CBXyP/pRR5bR1OqPQOtEd+v5OrMpUc1PmB7++E0so4TeMYG9tcFFZrplKfT9h1gPA3IkxOr+ZcbxbC8W58k8WzF60cvdvDxiX2HpUGYrjdUZUZsZEkzry/b54hrUNQW1715l7+jZ5rSlbonmMMVdEH7DNxu8nBkaZZ3CYiFnbMpQPU=; 25:ej6BNCoFB/TYLPP29zXwSbjk1HCaHLM4AUcjkmx+iSn5HU00c/VntkOZQs8W+1PMqloCkQciN+MJNxk4/lJUG8o8/lCGvbFXGoCWTS+FIJcTC2R14ZtY2r9bdwzoOuFzBuGJK0aHCrwdhhmxed8tLNm6NjZpeUiviHNdN1VEc/T6qUlwXBIIMOakbD2tZ7bC7gNa83hR8Sf0GvKP+PUX6CilGlDafkVYyNv528Fs0qvgyWhNgIusC5rPvwVLLad7qav2GD+77nBu84WSVt5+xw8UabGNNhHfyfsHr9USjUf2BeFdkIGBtiZFa/vDAYTs+uJNQ70onEN6I5L4/fgrIA== X-MS-TrafficTypeDiagnostic: BYAPR02MB4135: X-Microsoft-Exchange-Diagnostics: 1; BYAPR02MB4135; 31:5zYoNI9AgY9pRR8j+a3bRoN8uVrWXHHnKrdn8xxRsS0chgKjeDjOYcLXM+bi9LulsjisNiGdqLRK5ZHbssnM86SJrjGBf4IJnxCwuZ5O+F7hp1bPJYU5H2LYxGjweR1bh4kU4tlWUj9WR95Qip70K7TEDSOEDNOB+yNkaZe9hGQlNjYZu3Y5rFZ/cRfl2CI+aJUGBsZc7pqkNaWae2AMV9c8j2iheVTLHav2P4oOhgQ=; 20:EEJoNhZhJOWoQuLUnJ8ZMKm+4hD4NN4ZXImHhlSgMcK5KDpP1ctCzz9UFPhhi+ni2MKBnbbKEOlBdeuZp5KLn/7aoeLyrDQgDj09GAEHmCGTcdXDTgWOlW0s9yrlOqhDuUBbeyKOK0sQh/aH0YYHBfpplB8OF0y2Q5970eRnQvZUyN2Vutm5Z1pLA6NQbMnXI2Mhjn6YAELUZxWivaK73ZGfoCrpT3TDs836MMPji2S0E+ycLET9QsTeWwrUpOBT/UPH6LMORArk4We+aHbXB9uTEcyyA4XwxXSh9hWdhI0czI11II74NHAqdglqjk+zlA7F5Df8us3IVXW5cIhggEVcK+02SrTcU8D1z/Btj4oNXcII6uGPKMUk7p3Sd3lASUfjTNtUOfzLeGl8E1SEqe16Xx0ChABfZ5jj4IQZK+B6sFEX8tmavSzVlfonFM0rQj6pbONBSw87AidsendUW0LcRR/rN37BNsG4xYV56aaIw3PimYxBt+I6WycRN+mv X-Auto-Response-Suppress: DR, RN, NRN, OOF, AutoReply X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192813158149592); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231254)(944501410)(52105095)(10201501046)(93006095)(93004095)(3002001)(6055026)(149027)(150027)(6041310)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123562045)(6072148)(201708071742011)(7699016); SRVR:BYAPR02MB4135; BCL:0; PCL:0; RULEID:; SRVR:BYAPR02MB4135; X-Microsoft-Exchange-Diagnostics: 1; BYAPR02MB4135; 4:MMwi4bCA4CKcQfROXb+Uzceeg3TATpe+br9OjpaPCWcb+sK37mUOKg6QwRumJP24agV/KPlgUOrM/fZXz9uXZA97Iznoq4+Uub5WHln0I0k29SJqCME/F0e5eh3vfN5PLEDl0M2xU6wEfe0vPBtaTMqHdRRMNTptuj/e+1F1y0Ofpdr3izE5RFErBA+ZRgw+8np0HCvXJLXY/AikVyxFH5da27GHL+S7nw8Z9bKGRIvCIHbL/rahKRybZeLYKMRk2KmwYV1V2pERRxKpACI4kiBiOCD//FvuW/SM5uK6/xcizOnBed9vogXrTeXY6zes X-Forefront-PRVS: 0687389FB0 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BYAPR02MB4135; 23:3PJjWNuEcUSLxnFFIkq+FWEsnKSYyWy1kLO1Y867J?= r3HGQWwbsy9RD9bGgnsn7uxO0zAeov/r19QQqPjVRFNXDaBI4JSzEzo5/RFsPuis+p1cCHtxK0AdHjavFUG3u9fagb38yjWnu+R2iFTmhWSZYQVlsDfYI05UZmzSK4fNV49VfbW7SALPFkn2k8K6aJSdzWZgA1SOaaETY1vDlaf+58lXjWBOb6pytKH3MK5f4hknTOtRMP5/fa54p+60ClAFg7XJXDXVY/KjFr0ZRHOLZCEgMH5D7ANUMvqqvAOfzGZswL/YOMthCjnnV28I1GGCCEdaavy/zicVbztjCsrItCDf6ohEXmuj99n6PLn6Ng995mLpfgTqjemNv5oR/jJ6jL6wZLrBYD8m+2qqUdBm66sspuVwAeCiMqhhXsBY5EWW77SIDb1eig4h+3JT/k+pwVVDoc2MLNgnuQwETo1GjHDbe3AJqGIBdEmPf7z6nWPSK10E4wFsrINM4/QCmCbzaDNoY58IEU9gVM1qF0/NQZyk8Wlx0UZmWeTndFH54eM48K8FPwGi6wurilM0oerC0DsO6AiHH2QM6mBd9bbtRCf+Q5b8na1DZFcIS9lHEwXvNjJhKKXFzzbwT2fKwlLX4XattyWjawc8LjH2BIkAfXJiIQorgo3UAeQsBAMYaQAUgiVxuGKac+APQOl9Q7g5TmNnVqm+VPTuSL+W7MS4u5zEtFCXIbN0O8WVuDp3qbCyc865jukCFTab6L6skWJbiyaykn+aMMv0iVW13F7Zm4MrT5HqkfkU4PQpvwqB4wWtwK4fBf8oKMcVwpTir+tNS4yw1r6f82bYCmlANf1VbA2TqeiiuyhRvx2rbqPb8zCgWXZ5lZMafBvK8qQnRN4Tx8BmGumo95+Li7zla31GQB93F4QlxDq+SoEHOi73phOXhgak/YW+Kr6148iejGvlG49x43mFv0dB/B9Op7even6IsxaZkmfz3yz/u91ZZ8BabmfkjgqctzxQOdwRQ1L+o3op5yTLIecAir580I2Jo37hQGyP1nB8+z4pFC6bNKpdS1/GzBcYO9jJB3cE5yrXcbIeQ+Xnox1e9FmsKPIjBucp7UPgmzOCHJXiySiTa4= X-Microsoft-Antispam-Message-Info: KNsIxzrsvfAj5MqDLNAbk51D7jUAyn1kgOI+tARfhCFuIUxMd3+c8vRp0NI7ydh3169vnmOYLtHWZDSVPhthAEXwmvFA0R9gwOnH0+OYH5ombgyHLKLhs7w72YeUM9XGitbEk0fcYqhoz2cIJrxNIoSbmDye9zn2pRUMEOht9MrOaFCjIhRDDovPWvaFlhsl X-Microsoft-Exchange-Diagnostics: 1; BYAPR02MB4135; 6:6VGSfcpr87h/WhaY0gDmHEi7tJD+umxeeIpdmHqWAjxYc+9Qq1PdiTJG0vlTwRFn1Q/ECN8ersPAByNmREHJK1bdMw28Gn/+8pQtzKy3bIYIxLSM8fdIbjwcOy+Khzx1U8yk+Kh6rTo2mix9KmwidZl2rzOpRkrm63WO4QGwUNgTGKdDmwGPZA3ZAvOk2SnYy9iT5RdG9SJMzvO0Mxl2sS+08YC30ZWJNYnV0ki3PPdkr/Jxd+4k+S5/X1fnBVsoMGcf99/nggANuFK7DJRGJedCwjOOP16eSnlrY9UBQCt6S4nwmBNC4Y34+2eNcALzEjboV6W58f9RZueRRJIJ5oykUKi8X0KQxfimte6NiUGnHcutlhI7/Jr4Gyh+RpLT3XoYFlec2Dfmln30AAJaLujYhZGHQ4r6HwV5zCwNc2DyfsHh9HexYnyIRUGstNP5OrGBdhRL6xaGB3Oo+E3o/A==; 5:BZGzNeB5GWwWtEZFZ2OApt9se7YeC5qb2WaTHcni0nPjh3Qzyz9+uIwQDZ85CGMIl3JN5rXbaMRYFjbdvlAjeVQv42hQ+JYhz7d8GoET31wQP3AiY9eMvdU0v6v8RbgTij1qkPNsL7WlJwWojCt6H8I+9RsR6JeE/vHE1LxEKrI=; 24:Q/smHwNp9aPMglQRixpiGZ4tICbx0gQW8Ss9SE9rKLpUL999rPoWetzgECliyGgDg3pggJUWP/0Ec5WT1u0+F3ZXXKLSKqm9poSyHUi6xoo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BYAPR02MB4135; 7:iupNEsv4Zpa2RWyqkI7fPgcbE8gLQy544fWZpFoePij4YYr3Ol9qhnON8tKMvJ9CPVbuEKgXpJcmR9w7p7yZdntIbT0soK1KamHZzWA+embS0xI/0pXG4FZp/fJZuYlL4bkJP445PyYD5ke0FrmfAqtC9xmYsznWFFUKaum25UuuNNRslCbvlEcv1+cGA+B7/k/pYVvQUO9T7oHGAJWPezxrDZiZYB1FZ+st/mZA36ov1mTgvr8uZgyRK1HZyAB6 X-MS-Office365-Filtering-Correlation-Id: 85e75729-ffcb-49d4-a5b5-08d5c56fb84d X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 May 2018 14:23:16.5525 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 85e75729-ffcb-49d4-a5b5-08d5c56fb84d X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.60.83]; Helo=[xsj-pvapsmtpgw01] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR02MB4135 Cc: michal.simek@xilinx.com Subject: [U-Boot] [PATCH 1/3] cmd: fpga: Reorder the arguments parsing code X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" This patch modifies the arguments parsing code by parsing based on requested operation for fpga loadfs and then parses the most common/basic args for other fpga load commands. This makes it easy for new command extensions or additions especially the commands with more args. Signed-off-by: Siva Durga Prasad Paladugu --- cmd/fpga.c | 31 +++++++++++++++++++------------ 1 file changed, 19 insertions(+), 12 deletions(-) -- 2.7.4 This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately. diff --git a/cmd/fpga.c b/cmd/fpga.c index 14ad4e5..0981826 100644 --- a/cmd/fpga.c +++ b/cmd/fpga.c @@ -60,15 +60,31 @@ int do_fpga(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) if (datastr) fpga_data = (void *)simple_strtoul(datastr, NULL, 16); - switch (argc) { + if (argc > 9 && argc < 3) { + debug("%s: Too many or too few args (%d)\n", __func__, argc); + return CMD_RET_USAGE; + } + + op = (int)fpga_get_op(argv[1]); + + switch (op) { #if defined(CONFIG_CMD_FPGA_LOADFS) - case 9: + case FPGA_LOADFS: + if (argc < 9) + return CMD_RET_USAGE; fpga_fsinfo.blocksize = (unsigned int) - simple_strtoul(argv[5], NULL, 16); + simple_strtoul(argv[5], NULL, 16); fpga_fsinfo.interface = argv[6]; fpga_fsinfo.dev_part = argv[7]; fpga_fsinfo.filename = argv[8]; + argc = 5; + break; #endif + default: + break; + } + + switch (argc) { case 5: /* fpga */ data_size = simple_strtoul(argv[4], NULL, 16); @@ -117,15 +133,6 @@ int do_fpga(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) __func__, (ulong)fpga_data); dev = FPGA_INVALID_DEVICE; /* reset device num */ } - - case 2: /* fpga */ - op = (int)fpga_get_op(argv[1]); - break; - - default: - debug("%s: Too many or too few args (%d)\n", __func__, argc); - op = FPGA_NONE; /* force usage display */ - break; } if (dev == FPGA_INVALID_DEVICE) {