From patchwork Fri Mar 9 13:07:20 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan O'Donoghue X-Patchwork-Id: 883610 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="XCKw80yT"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3zySPf6tDjz9sbh for ; Sat, 10 Mar 2018 00:08:54 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 8E306C21E0F; Fri, 9 Mar 2018 13:08:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 762CBC21DFD; Fri, 9 Mar 2018 13:07:50 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id EFC26C21DFB; Fri, 9 Mar 2018 13:07:30 +0000 (UTC) Received: from mail-wm0-f66.google.com (mail-wm0-f66.google.com [74.125.82.66]) by lists.denx.de (Postfix) with ESMTPS id C917CC21DA1 for ; Fri, 9 Mar 2018 13:07:26 +0000 (UTC) Received: by mail-wm0-f66.google.com with SMTP id z81so3784349wmb.4 for ; Fri, 09 Mar 2018 05:07:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=IVYCEeDeNrGFBMrIxSFgFu/f4Y54PmrpgfqgqJ1hTIM=; b=XCKw80yTCPeXA2Vt8vM6VoZWyosQy5WVI4BuGc1v3+nQpyrqAXJevLx9zWFwr+TNSU 8LRGX5hfsFNUuh8mJMs5K4Mo+dqLYX9fEXvGM/whTWa2UlV56WB0V83HTUsYAeTdfwN9 p9kXautdGJ4SDgQXHF64kQSBeyyg1yESXFWF8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=IVYCEeDeNrGFBMrIxSFgFu/f4Y54PmrpgfqgqJ1hTIM=; b=S4uu4AjGTmjtL82GyPVUS8xceqJmHJ3OEh14Q7f0A6JmT2oLoVrcKocVmPXPlDfpHv LJ/1grSmE+f4P9r0P3zuqmIJOrzEGo30ca0pLEQGL0Ppw34AbgLnfhUQVIeUpZ7hQXpB LOolLurjUf4OeoY7g2+1MepKYNV+msEIIHHFakO2Kt8gcl4GrdTCMQ/Wz7VX3fGPkGVJ dyxeiIuG1YfQzrfmxj139LceKvEucmS+UDDNlv4971SsGeWIzmgjrrxOqLf0bg8gEvEG zpSpzoKxmmuXtUTrB7RxNhGD6QPsKKE6tUstE2KPL/SdbkUpesHslRTngXTM/A8sLAhU 4vUA== X-Gm-Message-State: APf1xPAnhblr7NKmKVdA5kwiTpB3qCLRBPQrPcy0sqUDNPwF7oz59l7P EeaUMOEhfpInQP2UOJYfAlPpk+9Jc4w= X-Google-Smtp-Source: AG47ELvOXT59t5U0fH0K3KfKjEzA6Hn7vsWtBN06aPLQS4AKbYOmkmwgCOEpQEI/gUulf2IitOfsMA== X-Received: by 10.80.185.34 with SMTP id m31mr36018381ede.214.1520600845848; Fri, 09 Mar 2018 05:07:25 -0800 (PST) Received: from localhost.localdomain ([109.255.42.2]) by smtp.gmail.com with ESMTPSA id b11sm827527edc.10.2018.03.09.05.07.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 09 Mar 2018 05:07:25 -0800 (PST) From: Bryan O'Donoghue To: U-Boot@lists.denx.de Date: Fri, 9 Mar 2018 13:07:20 +0000 Message-Id: <1520600841-8810-3-git-send-email-bryan.odonoghue@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1520600841-8810-1-git-send-email-bryan.odonoghue@linaro.org> References: <1520600841-8810-1-git-send-email-bryan.odonoghue@linaro.org> Cc: Breno Lima , Fabio Estevam , Utkarsh Gupta Subject: [U-Boot] [PATCH 2/3] imx: hab: Make usage of packed attribute consistent X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" commit cd2d46003ce1 ("arm: imx: hab: Add IVT header definitions") declares struct ivt_header as "__attribute__((packed))". commit ed286bc80e9d ("imx: hab: Check if CSF is valid before authenticating image") declares struct hab_hdr with __packed. This patch makes the __packed convention consistent. Signed-off-by: Bryan O'Donoghue Cc: Utkarsh Gupta Cc: Breno Lima Cc: Fabio Estevam Reviewed-by: Fabio Estevam --- arch/arm/include/asm/mach-imx/hab.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/include/asm/mach-imx/hab.h b/arch/arm/include/asm/mach-imx/hab.h index a522cba..ce9a44d 100644 --- a/arch/arm/include/asm/mach-imx/hab.h +++ b/arch/arm/include/asm/mach-imx/hab.h @@ -22,11 +22,11 @@ #define IVT_HEADER_V1 0x40 #define IVT_HEADER_V2 0x41 -struct ivt_header { +struct __packed ivt_header { uint8_t magic; uint16_t length; uint8_t version; -} __attribute__((packed)); +}; struct ivt { struct ivt_header hdr; /* IVT header above */