| Message ID | 1518344340-13672-2-git-send-email-jagan@amarulasolutions.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | arm: sunxi: Use proper and meaningful Kconfig entries | expand |
On Sun, Feb 11, 2018 at 6:18 PM, Jagan Teki <jagannadh.teki@gmail.com> wrote: > Add simple and meaningful kconfig option for prcm.c > instead of using MACH type on Makefile. > > PRCM (Power/Reset/Clock Management) is considered as a > Multi-Functional Device, so used the same on Kconfig definition. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > arch/arm/mach-sunxi/Kconfig | 7 +++++++ > arch/arm/mach-sunxi/Makefile | 2 +- > 2 files changed, 8 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig > index 1fededd..2b9f48b 100644 > --- a/arch/arm/mach-sunxi/Kconfig > +++ b/arch/arm/mach-sunxi/Kconfig > @@ -6,6 +6,12 @@ config SPL_LDSCRIPT > config IDENT_STRING > default " Allwinner Technology" > > +config MFD_SUN6I_PRCM > + bool "Allwinner A31 PRCM controller" > + help > + Support for the PRCM (Power/Reset/Clock Management) unit available > + in A31 SoC. > + Do these entries even need to be visible? It's not like it makes sense to toggle them independently. This applies to almost all the patches in this series. ChenYu > config SUNXI_HIGH_SRAM > bool > default n > @@ -87,6 +93,7 @@ config MACH_SUN6I > select CPU_V7_HAS_NONSEC > select CPU_V7_HAS_VIRT > select ARCH_SUPPORT_PSCI > + select MFD_SUN6I_PRCM > select SUNXI_GEN_SUN6I > select SUPPORT_SPL > select ARMV7_BOOT_SEC_DEFAULT if OLD_SUNXI_KERNEL_COMPAT > diff --git a/arch/arm/mach-sunxi/Makefile b/arch/arm/mach-sunxi/Makefile > index 2a3c379..3c1c660 100644 > --- a/arch/arm/mach-sunxi/Makefile > +++ b/arch/arm/mach-sunxi/Makefile > @@ -16,7 +16,7 @@ obj-y += pinmux.o > ifndef CONFIG_MACH_SUN9I > obj-y += usb_phy.o > endif > -obj-$(CONFIG_MACH_SUN6I) += prcm.o > +obj-$(CONFIG_MFD_SUN6I_PRCM) += prcm.o > obj-$(CONFIG_MACH_SUN8I) += prcm.o > obj-$(CONFIG_MACH_SUN9I) += prcm.o > obj-$(CONFIG_MACH_SUN6I) += p2wi.o > -- > 2.7.4 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > https://lists.denx.de/listinfo/u-boot
On Mon, Feb 12, 2018 at 9:56 AM, Chen-Yu Tsai <wens@csie.org> wrote: > On Sun, Feb 11, 2018 at 6:18 PM, Jagan Teki <jagannadh.teki@gmail.com> wrote: >> Add simple and meaningful kconfig option for prcm.c >> instead of using MACH type on Makefile. >> >> PRCM (Power/Reset/Clock Management) is considered as a >> Multi-Functional Device, so used the same on Kconfig definition. >> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> >> --- >> arch/arm/mach-sunxi/Kconfig | 7 +++++++ >> arch/arm/mach-sunxi/Makefile | 2 +- >> 2 files changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig >> index 1fededd..2b9f48b 100644 >> --- a/arch/arm/mach-sunxi/Kconfig >> +++ b/arch/arm/mach-sunxi/Kconfig >> @@ -6,6 +6,12 @@ config SPL_LDSCRIPT >> config IDENT_STRING >> default " Allwinner Technology" >> >> +config MFD_SUN6I_PRCM >> + bool "Allwinner A31 PRCM controller" >> + help >> + Support for the PRCM (Power/Reset/Clock Management) unit available >> + in A31 SoC. >> + > > Do these entries even need to be visible? > It's not like it makes sense to toggle them independently. > This applies to almost all the patches in this series. True with PRCM and DRAM and others shouldn't relate to arch code and move to drivers in future.
diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig index 1fededd..2b9f48b 100644 --- a/arch/arm/mach-sunxi/Kconfig +++ b/arch/arm/mach-sunxi/Kconfig @@ -6,6 +6,12 @@ config SPL_LDSCRIPT config IDENT_STRING default " Allwinner Technology" +config MFD_SUN6I_PRCM + bool "Allwinner A31 PRCM controller" + help + Support for the PRCM (Power/Reset/Clock Management) unit available + in A31 SoC. + config SUNXI_HIGH_SRAM bool default n @@ -87,6 +93,7 @@ config MACH_SUN6I select CPU_V7_HAS_NONSEC select CPU_V7_HAS_VIRT select ARCH_SUPPORT_PSCI + select MFD_SUN6I_PRCM select SUNXI_GEN_SUN6I select SUPPORT_SPL select ARMV7_BOOT_SEC_DEFAULT if OLD_SUNXI_KERNEL_COMPAT diff --git a/arch/arm/mach-sunxi/Makefile b/arch/arm/mach-sunxi/Makefile index 2a3c379..3c1c660 100644 --- a/arch/arm/mach-sunxi/Makefile +++ b/arch/arm/mach-sunxi/Makefile @@ -16,7 +16,7 @@ obj-y += pinmux.o ifndef CONFIG_MACH_SUN9I obj-y += usb_phy.o endif -obj-$(CONFIG_MACH_SUN6I) += prcm.o +obj-$(CONFIG_MFD_SUN6I_PRCM) += prcm.o obj-$(CONFIG_MACH_SUN8I) += prcm.o obj-$(CONFIG_MACH_SUN9I) += prcm.o obj-$(CONFIG_MACH_SUN6I) += p2wi.o
Add simple and meaningful kconfig option for prcm.c instead of using MACH type on Makefile. PRCM (Power/Reset/Clock Management) is considered as a Multi-Functional Device, so used the same on Kconfig definition. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- arch/arm/mach-sunxi/Kconfig | 7 +++++++ arch/arm/mach-sunxi/Makefile | 2 +- 2 files changed, 8 insertions(+), 1 deletion(-)