From patchwork Tue Jan 9 09:34:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Masahiro Yamada X-Patchwork-Id: 857340 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=nifty.com header.i=@nifty.com header.b="hrs0uTG7"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3zG6Yh4FQdz9s75 for ; Tue, 9 Jan 2018 20:39:50 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 909D4C220B8; Tue, 9 Jan 2018 09:39:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id B969FC220A6; Tue, 9 Jan 2018 09:36:07 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id A96DBC220DC; Tue, 9 Jan 2018 09:35:56 +0000 (UTC) Received: from conuserg-12.nifty.com (conuserg-12.nifty.com [210.131.2.79]) by lists.denx.de (Postfix) with ESMTPS id 84895C220BA for ; Tue, 9 Jan 2018 09:35:52 +0000 (UTC) Received: from pug.e01.socionext.com (p14092-ipngnfx01kyoto.kyoto.ocn.ne.jp [153.142.97.92]) (authenticated) by conuserg-12.nifty.com with ESMTP id w099YtdG013772; Tue, 9 Jan 2018 18:34:57 +0900 DKIM-Filter: OpenDKIM Filter v2.10.3 conuserg-12.nifty.com w099YtdG013772 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nifty.com; s=dec2015msa; t=1515490497; bh=iOzoCY2NkWr80mFkJT5aBQ/ifuhOJDtsc72C0BefcPg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hrs0uTG7sS07I51h96h8HZP2ySclRNgygaYAnLpoQZJ+9a8TiesM/kKNMP3pyEcNv /0XHLvj0Vew90Eo5AgzHIl89C000kVTnuKyPYo6+IioDdYTkTQCAAQWdW73fLUhCg8 Qb5lPV6gopYpYnkIPqptNZgms/AJC7nW1mMQs0yTKbdW+xoq2EkbO3M9QoGcsnOX/6 8lhN3tr8WhX2jyAX3c3sDNOYnrUJqBKjt0wJnlcTelRxHZURLETMGYIDc9ugVtoEae Q0xttpaV4dGtKQjCavBD0WD16S6Icpvzj2Ixa6Dkdtog5PMK86HbGnNUGpBYAoVzzS JXy4xLqudpdlQ== X-Nifty-SrcIP: [153.142.97.92] From: Masahiro Yamada To: u-boot@lists.denx.de Date: Tue, 9 Jan 2018 18:34:48 +0900 Message-Id: <1515490492-29434-3-git-send-email-yamada.masahiro@socionext.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1515490492-29434-1-git-send-email-yamada.masahiro@socionext.com> References: <1515490492-29434-1-git-send-email-yamada.masahiro@socionext.com> Cc: Tom Rini , Joe Hershberger , "oliver@schinagl.nl" , Olliver Schinagl Subject: [U-Boot] [PATCH 3/7] tools: include necessary headers explicitly X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Several host-tools use "bool" type without including . This relies on the crappy header inclusion chain. tools/Makefile has the following line: HOST_EXTRACFLAGS += -include $(srctree)/include/libfdt_env.h \ All host-tools are forced to include libfdt_env.h even if they are totally unrelated to FDT. Then, is indirectly included as follows: include/libfdt_env.h -> include/linux/types.h -> I am fixing this horrible crap. In advance, I need to add necessary include directives explicitly. tools/fdtgrep.c needs more; for open() and for errno. Signed-off-by: Masahiro Yamada Reviewed-by: Joe Hershberger Reviewed-by: Simon Glass --- tools/fdtgrep.c | 3 +++ tools/gen_ethaddr_crc.c | 1 + tools/ifdtool.c | 1 + tools/imagetool.h | 1 + tools/mips-relocs.c | 1 + 5 files changed, 7 insertions(+) diff --git a/tools/fdtgrep.c b/tools/fdtgrep.c index 7af77b7..8d33205 100644 --- a/tools/fdtgrep.c +++ b/tools/fdtgrep.c @@ -10,7 +10,10 @@ #include #include +#include #include +#include +#include #include #include #include diff --git a/tools/gen_ethaddr_crc.c b/tools/gen_ethaddr_crc.c index fe9896d..8cf86f4 100644 --- a/tools/gen_ethaddr_crc.c +++ b/tools/gen_ethaddr_crc.c @@ -6,6 +6,7 @@ */ #include +#include #include #include #include diff --git a/tools/ifdtool.c b/tools/ifdtool.c index 195b153..729991e 100644 --- a/tools/ifdtool.c +++ b/tools/ifdtool.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include diff --git a/tools/imagetool.h b/tools/imagetool.h index a8d5054..e67de9b 100644 --- a/tools/imagetool.h +++ b/tools/imagetool.h @@ -12,6 +12,7 @@ #include "os_support.h" #include #include +#include #include #include #include diff --git a/tools/mips-relocs.c b/tools/mips-relocs.c index 8be69d3..27d4730 100644 --- a/tools/mips-relocs.c +++ b/tools/mips-relocs.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include #include