diff mbox series

[U-Boot] power: tps65910: replace error() by pr_err()

Message ID 1513607908-9806-1-git-send-email-fb@ltec.ch
State Accepted
Commit 46caea7f96f0cd81cbc92fefc3d279e870442cb0
Delegated to: Tom Rini
Headers show
Series [U-Boot] power: tps65910: replace error() by pr_err() | expand

Commit Message

Felix Brack Dec. 18, 2017, 2:38 p.m. UTC
The patch replaces the former error() by the new pr_err().
This makes the TPS65910 driver conform to Masahiro's patch
'treewide:replace with error() with pr_err()' introduced
October 2017.

Signed-off-by: Felix Brack <fb@ltec.ch>
---

 drivers/power/pmic/pmic_tps65910_dm.c        | 4 ++--
 drivers/power/regulator/tps65910_regulator.c | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Simon Glass Dec. 19, 2017, 3:42 p.m. UTC | #1
On 18 December 2017 at 07:38, Felix Brack <fb@ltec.ch> wrote:
> The patch replaces the former error() by the new pr_err().
> This makes the TPS65910 driver conform to Masahiro's patch
> 'treewide:replace with error() with pr_err()' introduced
> October 2017.
>
> Signed-off-by: Felix Brack <fb@ltec.ch>
> ---
>
>  drivers/power/pmic/pmic_tps65910_dm.c        | 4 ++--
>  drivers/power/regulator/tps65910_regulator.c | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)

Reviewed-by: Simon Glass <sjg@chromium.org>
Tom Rini Jan. 2, 2018, 12:47 a.m. UTC | #2
On Mon, Dec 18, 2017 at 03:38:28PM +0100, Felix Brack wrote:

> The patch replaces the former error() by the new pr_err().
> This makes the TPS65910 driver conform to Masahiro's patch
> 'treewide:replace with error() with pr_err()' introduced
> October 2017.
> 
> Signed-off-by: Felix Brack <fb@ltec.ch>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!
diff mbox series

Patch

diff --git a/drivers/power/pmic/pmic_tps65910_dm.c b/drivers/power/pmic/pmic_tps65910_dm.c
index 0127ce3..c65f38f 100644
--- a/drivers/power/pmic/pmic_tps65910_dm.c
+++ b/drivers/power/pmic/pmic_tps65910_dm.c
@@ -32,7 +32,7 @@  static int pmic_tps65910_write(struct udevice *dev, uint reg, const u8 *buffer,
 
 	ret = dm_i2c_write(dev, reg, buffer, len);
 	if (ret)
-		error("%s write error on register %02x\n", dev->name, reg);
+		pr_err("%s write error on register %02x\n", dev->name, reg);
 
 	return ret;
 }
@@ -44,7 +44,7 @@  static int pmic_tps65910_read(struct udevice *dev, uint reg, u8 *buffer,
 
 	ret = dm_i2c_read(dev, reg, buffer, len);
 	if (ret)
-		error("%s read error on register %02x\n", dev->name, reg);
+		pr_err("%s read error on register %02x\n", dev->name, reg);
 
 	return ret;
 }
diff --git a/drivers/power/regulator/tps65910_regulator.c b/drivers/power/regulator/tps65910_regulator.c
index 5e2ec8f..ad952e5 100644
--- a/drivers/power/regulator/tps65910_regulator.c
+++ b/drivers/power/regulator/tps65910_regulator.c
@@ -340,11 +340,11 @@  static int buck_set_vdd1_vdd2_value(struct udevice *dev, int uV)
 
 	/* check setpoint is within limits */
 	if (uV < uc_pdata->min_uV) {
-		error("voltage %duV for %s too low\n", uV, dev->name);
+		pr_err("voltage %duV for %s too low\n", uV, dev->name);
 		return -EINVAL;
 	}
 	if (uV > uc_pdata->max_uV) {
-		error("voltage %duV for %s too high\n", uV, dev->name);
+		pr_err("voltage %duV for %s too high\n", uV, dev->name);
 		return -EINVAL;
 	}