From patchwork Tue Dec 12 13:23:39 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Neil Armstrong X-Patchwork-Id: 847496 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="hrhbT4ZL"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3yx0sR0rRYz9s7B for ; Wed, 13 Dec 2017 00:24:09 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 0C2CDC21DA5; Tue, 12 Dec 2017 13:23:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id ED8E9C21D9F; Tue, 12 Dec 2017 13:23:48 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 49D59C21D9F; Tue, 12 Dec 2017 13:23:47 +0000 (UTC) Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com [74.125.82.67]) by lists.denx.de (Postfix) with ESMTPS id BC86AC21C40 for ; Tue, 12 Dec 2017 13:23:46 +0000 (UTC) Received: by mail-wm0-f67.google.com with SMTP id f9so20390138wmh.0 for ; Tue, 12 Dec 2017 05:23:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=m403W3DA3xz8PhwDsGRGG3PzcpA9xMLcZV7jn7b168U=; b=hrhbT4ZLufSgjhZ9jgnrMV1usPV4U+r9DrT3yB/um8oPg0Ud8xOSkdKnAAkvbk8G0e EEeufrWWY4VRPWvmNWWAoJVQj0K36ZmzAx230ccCV1amPOKNQRwP+FEbaD78mwkfZTcH O2umPGQowNsnW2g1ltyVNWSQ8E/VvQiTMC9Ey8IwRMu+XYz+vTP3tyKSJHfyVi95OQ0v gZ5c14E0BK2B0hljgRsKqwZDJHMlDhQ8O8OpC2tj6YJFwCCsswBUgLCOeDM/bA8CfKLy mnKOXKjFN6yFG+tUNA9ymQ03bbwzCUlb5FpZ/eRgZRHjVPpiFXi7r40k+e9vJMCY/3cw HZHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=m403W3DA3xz8PhwDsGRGG3PzcpA9xMLcZV7jn7b168U=; b=tM4kcW5djv1VBB8DzD6k1D0K6jN854COtXs1rK2MtS7ho03Dr/N5ZAOeoy0f+FoVz6 3EtBDgvGmAubI3mnxVGOL8F0T3alhc6HCtZcn2S8gPEWckYTIRMvxXlxJC4GlQ50XQPQ DEvgtMavMKszBT/stKqio+dvBVsYjLENlNG2i8EMDdDMgN/W157+gAMNWuolXiH15CfT Ixltn+vbVdOdyAHpNelk166uQPqwtuk02K2k+l+j0rFJC2E1Ztg4+c2HAl1xTbd3RDJe wEbklA54SfoHA/G3cfxfjD7MSat/2Ur1P8OSEZU4LkGn9PYrE1Kp4DGaHxkmBnWqgH1i VaWA== X-Gm-Message-State: AKGB3mKkB9RC+LDcOeQJd54EXIdofMNyj0o6eQ8JXYugNE4/ccw5MmJs tYG7Q2+uyKAq20g682xIyS75ObNvxB0= X-Google-Smtp-Source: ACJfBouOOcpZWZ8uhLxJORC3YamzRvpQvsg0DW91LrpXj0KezGobDN+sMGWpBNmDypx//AsWqgU5AQ== X-Received: by 10.28.173.213 with SMTP id w204mr1836831wme.126.1513085026104; Tue, 12 Dec 2017 05:23:46 -0800 (PST) Received: from bender.baylibre.local ([90.63.244.31]) by smtp.gmail.com with ESMTPSA id m201sm4201540wma.13.2017.12.12.05.23.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 12 Dec 2017 05:23:45 -0800 (PST) From: Neil Armstrong To: u-boot@lists.denx.de Date: Tue, 12 Dec 2017 14:23:39 +0100 Message-Id: <1513085019-8071-1-git-send-email-narmstrong@baylibre.com> X-Mailer: git-send-email 2.7.4 Cc: trini@konsulko.com, Hans Verkuil , linux-amlogic@lists.infradead.org Subject: [U-Boot] [PATCH u-boot] ARM: arch-meson: fix writel arguments order X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Hans Verkuil Using writel causes a "Synchronous Abort". Invert the arguments. Signed-off-by: Hans Verkuil Signed-off-by: Neil Armstrong --- arch/arm/mach-meson/eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Thanks Hans for finding this stupid error ! Neil diff --git a/arch/arm/mach-meson/eth.c b/arch/arm/mach-meson/eth.c index 2debe93..8c6577b 100644 --- a/arch/arm/mach-meson/eth.c +++ b/arch/arm/mach-meson/eth.c @@ -38,8 +38,8 @@ void meson_gx_eth_init(phy_interface_t mode, unsigned int flags) /* Use GXL RMII Internal PHY */ if (IS_ENABLED(CONFIG_MESON_GXL) && (flags & MESON_GXL_USE_INTERNAL_RMII_PHY)) { - writel(GXBB_ETH_REG_2, 0x10110181); - writel(GXBB_ETH_REG_3, 0xe40908ff); + writel(0x10110181, GXBB_ETH_REG_2); + writel(0xe40908ff, GXBB_ETH_REG_3); } break;