From patchwork Fri Dec 1 07:20:29 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eddie Cai X-Patchwork-Id: 843380 X-Patchwork-Delegate: marek.vasut@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.denx.de (client-ip=81.169.180.215; helo=lists.denx.de; envelope-from=u-boot-bounces@lists.denx.de; receiver=) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="FMTA3SyZ"; dkim-atps=neutral Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3yp5MV0NdHz9tBX for ; Fri, 1 Dec 2017 18:22:45 +1100 (AEDT) Received: by lists.denx.de (Postfix, from userid 105) id 98CE4C21F3D; Fri, 1 Dec 2017 07:22:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=FREEMAIL_FROM, KHOP_BIG_TO_CC, RCVD_IN_DNSWL_BLOCKED, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, T_DKIM_INVALID autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 1271AC21F53; Fri, 1 Dec 2017 07:21:25 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 6E223C21EE4; Fri, 1 Dec 2017 07:21:06 +0000 (UTC) Received: from mail-pg0-f67.google.com (mail-pg0-f67.google.com [74.125.83.67]) by lists.denx.de (Postfix) with ESMTPS id 071F1C21F8A for ; Fri, 1 Dec 2017 07:21:03 +0000 (UTC) Received: by mail-pg0-f67.google.com with SMTP id b18so4128074pgv.10 for ; Thu, 30 Nov 2017 23:21:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cprXhNT4lnlHrd9dvWVBKcpu8d/I90zcrZDEZWq9kzg=; b=FMTA3SyZxnQ858ZoJ9ziL0yP9gzJJDu5o6vTesdsJD6HH79PEnss937uSVKbFgaHm9 aR2I/VLX368h7x8u3+biRXverGvh6UL0nuCI/BAmb0WZ5XxFEf5Qh+mqJ9jwpNwYoSHG cv98NDq1/uoPwdRUEDa+W6J1RUWjOuM9u6qK2SF/i8vGSGKfSVJlDs0Mfn1AncMtnQVF 73lH6JMmKdxm9yMWutefHV6tZOWfKfequow0XMFlHXFvNSnifeozqBABnCb9H5LD31ou HBnSuA8QUszsd9p9UKvnVMy16hGXhdxgmw+wSNgWldswFRupaAKMmavyvr5ebwihH+Qb ftBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cprXhNT4lnlHrd9dvWVBKcpu8d/I90zcrZDEZWq9kzg=; b=QZ5+VRHBKqCgN9Zlo+7uBt/O6/weeRB1S9no84T9Ao/mJJiUpxW6gTXZ27WRvZhaSY 0ILsLps6W1oz6pB6vvKmNZCVCjUPLPvvJ0czuaKbwtEbHU/8Q/M89wA2Ujfm4TrZQ2mL YeZuwh1jhyiXsB/grHD9vLKaRngUDfonXNbdSVy84azpJ3zrucTTG8esyoQaFut0IIEn q+CVMAfKRXJ0WWtASzpAY1r5mI/H2lyW+5/8usjYtctudSit6hg9liZkv+osMT/jKadj Q3MZFeCFCwHVj9mKaRBkydJyNu5iDIb4F3B4jPeXGyriZ3o2h5OeeOM5AODn/K5A3LI0 ZbHg== X-Gm-Message-State: AJaThX7TszIMx9I8UbwErI5FwkOg4KC8UaN2Ymht3UW49tTJIxCo3W5i h6nAZgzxBjfdhiM/Mr+nGkk= X-Google-Smtp-Source: AGs4zMaU09qslQc58HeRuV44MkjRYnrCV5+XoIS2Y8PwLKMV56q9IaNbTL9BskKnRz+MHDZl+Yh9Ow== X-Received: by 10.101.83.133 with SMTP id x5mr2298632pgq.175.1512112861640; Thu, 30 Nov 2017 23:21:01 -0800 (PST) Received: from localhost.localdomain ([103.29.142.67]) by smtp.gmail.com with ESMTPSA id a87sm11929003pfg.159.2017.11.30.23.20.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 30 Nov 2017 23:21:00 -0800 (PST) From: Eddie Cai To: lukma@denx.de, sjg@chromium.org, marex@denx.de, trini@konsulko.com, yamada.masahiro@socionext.com, maxime.ripard@free-electrons.com, agraf@suse.de, bmeng.cn@gmail.com, yanmiaobest@gmail.com, dinguyen@kernel.org, boris.brezillon@free-electrons.com, sr@denx.de, uri.mashiach@compulab.co.il, michal.simek@xilinx.com Date: Fri, 1 Dec 2017 15:20:29 +0800 Message-Id: <1512112831-26759-3-git-send-email-eddie.cai.linux@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1512112831-26759-1-git-send-email-eddie.cai.linux@gmail.com> References: <1512112831-26759-1-git-send-email-eddie.cai.linux@gmail.com> Cc: u-boot@lists.denx.de Subject: [U-Boot] [PATCH V11 2/4] usb: rockchip: add rockusb command X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" this patch add rockusb command. the usage is rockusb e.g. rockusb 0 mmc 0 Signed-off-by: Eddie Cai Reviewed-by: Simon Glass --- Changes in v11: -fix check patch error -add maintainer Changes in v10: -fix build error Changes in v9: -fix compile error Changes in v8: -none Changes in v7: -none Changes in v6: -move some data to f_rockusb structure Changes in v5: -fix build error when build non-rockchip board -fix checkpatch error Changes in v4: -use enum instead of macro define -move some structure define and macro to f_rockusb.h -add some function comment as Simon required -address other comment from Simon -fix build error as Lukasz point out --- MAINTAINERS | 1 + cmd/Kconfig | 8 +++++++ cmd/Makefile | 1 + cmd/rockusb.c | 74 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 84 insertions(+) create mode 100644 cmd/rockusb.c diff --git a/MAINTAINERS b/MAINTAINERS index e92a15d..c7db583 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -456,6 +456,7 @@ ROCKUSB M: Eddie Cai S: Maintained F: drivers/usb/gadget/f_rockusb.c +F: cmd/rockusb.c VIDEO M: Anatolij Gustschin diff --git a/cmd/Kconfig b/cmd/Kconfig index 5a6afab..b46bf41 100644 --- a/cmd/Kconfig +++ b/cmd/Kconfig @@ -914,6 +914,14 @@ config CMD_USB_SDP help Enables the command "sdp" which is used to have U-Boot emulating the Serial Download Protocol (SDP) via USB. +config CMD_ROCKUSB + bool "rockusb" + depends on USB_FUNCTION_ROCKUSB + help + Rockusb protocol is widely used by Rockchip SoC based devices. It can + read/write info, image to/from devices. This enable rockusb command + support to communication with rockusb device. for more detail about + this command, please read doc/README.rockusb. config CMD_USB_MASS_STORAGE bool "UMS usb mass storage" diff --git a/cmd/Makefile b/cmd/Makefile index 2b0444d..6837e9b 100644 --- a/cmd/Makefile +++ b/cmd/Makefile @@ -105,6 +105,7 @@ obj-$(CONFIG_CMD_READ) += read.o obj-$(CONFIG_CMD_REGINFO) += reginfo.o obj-$(CONFIG_CMD_REISER) += reiser.o obj-$(CONFIG_CMD_REMOTEPROC) += remoteproc.o +obj-$(CONFIG_CMD_ROCKUSB) += rockusb.o obj-$(CONFIG_SANDBOX) += host.o obj-$(CONFIG_CMD_SATA) += sata.o obj-$(CONFIG_CMD_NVME) += nvme.o diff --git a/cmd/rockusb.c b/cmd/rockusb.c new file mode 100644 index 0000000..af81cdc --- /dev/null +++ b/cmd/rockusb.c @@ -0,0 +1,74 @@ +/* + * Copyright (C) 2017 Eddie Cai + * + * SPDX-License-Identifier: GPL-2.0+ + */ + +#include +#include +#include +#include +#include +#include + +static int do_rockusb(cmd_tbl_t *cmdtp, int flag, int argc, char *const argv[]) +{ + int controller_index, dev_index; + char *usb_controller; + char *devtype; + char *devnum; + int ret; + + if (argc < 2) + return CMD_RET_USAGE; + + usb_controller = argv[1]; + controller_index = simple_strtoul(usb_controller, NULL, 0); + + if (argc >= 4) { + devtype = argv[2]; + devnum = argv[3]; + } else { + return CMD_RET_USAGE; + } + dev_index = simple_strtoul(devnum, NULL, 0); + rockusb_dev_init(devtype, dev_index); + + ret = board_usb_init(controller_index, USB_INIT_DEVICE); + if (ret) { + printf("USB init failed: %d\n", ret); + return CMD_RET_FAILURE; + } + + g_dnl_clear_detach(); + ret = g_dnl_register("usb_dnl_rockusb"); + if (ret) + return CMD_RET_FAILURE; + + if (!g_dnl_board_usb_cable_connected()) { + puts("\rUSB cable not detected, Command exit.\n"); + ret = CMD_RET_FAILURE; + goto exit; + } + + while (1) { + if (g_dnl_detach()) + break; + if (ctrlc()) + break; + usb_gadget_handle_interrupts(controller_index); + } + ret = CMD_RET_SUCCESS; + +exit: + g_dnl_unregister(); + g_dnl_clear_detach(); + board_usb_cleanup(controller_index, USB_INIT_DEVICE); + + return ret; +} + +U_BOOT_CMD(rockusb, 4, 1, do_rockusb, + "use the rockusb protocol", + " e.g. rockusb 0 mmc 0\n" +);