| Message ID | 1506083248-20207-1-git-send-email-fb@ltec.ch |
|---|---|
| State | Accepted |
| Commit | bd2259e3c40c097c47e1dfc58a03b1df66b44840 |
| Delegated to: | Tom Rini |
| Headers | show |
| Series | [U-Boot] doc: Fix statements on case sensitivity for regulator prefix | expand |
On Fri, Sep 22, 2017 at 02:27:28PM +0200, Felix Brack wrote: > The regulator bindings state that regulator prefixes are allowd to be > in upper or lower case. However pmic_bind_children from pmic_uclass uses > strncmp to compare DT node name against prefix. This comparison is case > sensitive hence the regulator driver prefix case matters. > > Signed-off-by: Felix Brack <fb@ltec.ch> Applied to u-boot/master, thanks!
diff --git a/doc/device-tree-bindings/regulator/regulator.txt b/doc/device-tree-bindings/regulator/regulator.txt index 2cf4b9d..918711e 100644 --- a/doc/device-tree-bindings/regulator/regulator.txt +++ b/doc/device-tree-bindings/regulator/regulator.txt @@ -10,10 +10,10 @@ pmic: drivers/power/pmic/max77686.c regulator: drivers/power/regulator/max77686.c For the node name e.g.: "prefix[:alpha:]num { ... }": -- the driver prefix should be: "prefix" or "PREFIX" - case insensitive +- the driver prefix should be: "prefix" - case sensitive - the node name's "num" is set as "dev->driver_data" on bind -Example the prefix "ldo" will pass for: "ldo1", "ldo@1", "LDO1", "LDOREG@1"... +Example the prefix "ldo" will pass for: "ldo1", "ldo@1", "ldoreg@1, ... Optional properties: - regulator-name: a string, required by the regulator uclass
The regulator bindings state that regulator prefixes are allowd to be in upper or lower case. However pmic_bind_children from pmic_uclass uses strncmp to compare DT node name against prefix. This comparison is case sensitive hence the regulator driver prefix case matters. Signed-off-by: Felix Brack <fb@ltec.ch> --- doc/device-tree-bindings/regulator/regulator.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)