diff mbox series

[U-Boot,1/2] armv8: layerscape: Allocate 66 MB DDR for secure memory

Message ID 1504254301-7970-1-git-send-email-sumit.garg@nxp.com
State Accepted
Commit 9781d9ff5fafd3c433b426914f9d017ddfe757b5
Delegated to: York Sun
Headers show
Series [U-Boot,1/2] armv8: layerscape: Allocate 66 MB DDR for secure memory | expand

Commit Message

Sumit Garg Sept. 1, 2017, 8:25 a.m. UTC
Change DDR allocated for secure memory from 2 MB to 66 MB. This additional
64 MB secure memory is required for trusted OS running in Trusted Execution
Environment using ARMv8 TrustZone.

Signed-off-by: Sumit Garg <sumit.garg@nxp.com>
---
 arch/arm/include/asm/arch-fsl-layerscape/config.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

York Sun Oct. 23, 2017, 9:06 p.m. UTC | #1
On 09/01/2017 01:24 AM, Sumit Garg wrote:
> Change DDR allocated for secure memory from 2 MB to 66 MB. This additional
> 64 MB secure memory is required for trusted OS running in Trusted Execution
> Environment using ARMv8 TrustZone.
> 
> Signed-off-by: Sumit Garg <sumit.garg@nxp.com>
> ---
>  arch/arm/include/asm/arch-fsl-layerscape/config.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/include/asm/arch-fsl-layerscape/config.h b/arch/arm/include/asm/arch-fsl-layerscape/config.h
> index a7098be..95e2791 100644
> --- a/arch/arm/include/asm/arch-fsl-layerscape/config.h
> +++ b/arch/arm/include/asm/arch-fsl-layerscape/config.h
> @@ -16,7 +16,7 @@
>   * Reserve secure memory
>   * To be aligned with MMU block size
>   */
> -#define CONFIG_SYS_MEM_RESERVE_SECURE	(2048 * 1024)	/* 2MB */
> +#define CONFIG_SYS_MEM_RESERVE_SECURE	(66 * 1024 * 1024)	/* 66MB */
>  #define SPL_TLB_SETBACK	0x1000000	/* 16MB under effective memory top */
>  
>  #ifdef CONFIG_ARCH_LS2080A
> 

Sumit,

I believe this patch is no longer needed after the merge of

commit 710d0cd79ede129d5203325c2a188c6f93c61ca3
Author: Sumit Garg <sumit.garg@nxp.com>
Date:   Wed Oct 4 03:20:49 2017 +0530

    armv8: fsl-layerscape: Allocate Secure memory from first ddr region

York
Sumit Garg Oct. 24, 2017, 3:44 a.m. UTC | #2
> -----Original Message-----
> From: York Sun
> Sent: Tuesday, October 24, 2017 2:36 AM
> To: Sumit Garg <sumit.garg@nxp.com>; u-boot@lists.denx.de
> Cc: Ruchika Gupta <ruchika.gupta@nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com>; Z.q. Hou <zhiqiang.hou@nxp.com>; Pankaj
> Gupta <pankaj.gupta@nxp.com>; Arun Pathak <arun.pathak@nxp.com>; Sahil
> Malhotra <sahil.malhotra@nxp.com>
> Subject: Re: [PATCH 1/2] armv8: layerscape: Allocate 66 MB DDR for secure
> memory
> 
> On 09/01/2017 01:24 AM, Sumit Garg wrote:
> > Change DDR allocated for secure memory from 2 MB to 66 MB. This
> > additional
> > 64 MB secure memory is required for trusted OS running in Trusted
> > Execution Environment using ARMv8 TrustZone.
> >
> > Signed-off-by: Sumit Garg <sumit.garg@nxp.com>
> > ---
> >  arch/arm/include/asm/arch-fsl-layerscape/config.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/include/asm/arch-fsl-layerscape/config.h
> > b/arch/arm/include/asm/arch-fsl-layerscape/config.h
> > index a7098be..95e2791 100644
> > --- a/arch/arm/include/asm/arch-fsl-layerscape/config.h
> > +++ b/arch/arm/include/asm/arch-fsl-layerscape/config.h
> > @@ -16,7 +16,7 @@
> >   * Reserve secure memory
> >   * To be aligned with MMU block size
> >   */
> > -#define CONFIG_SYS_MEM_RESERVE_SECURE	(2048 * 1024)	/* 2MB
> */
> > +#define CONFIG_SYS_MEM_RESERVE_SECURE	(66 * 1024 * 1024)
> 	/* 66MB */
> >  #define SPL_TLB_SETBACK	0x1000000	/* 16MB under effective
> memory top */
> >
> >  #ifdef CONFIG_ARCH_LS2080A
> >
> 
> Sumit,
> 
> I believe this patch is no longer needed after the merge of
> 
> commit 710d0cd79ede129d5203325c2a188c6f93c61ca3
> Author: Sumit Garg <sumit.garg@nxp.com>
> Date:   Wed Oct 4 03:20:49 2017 +0530
> 
>     armv8: fsl-layerscape: Allocate Secure memory from first ddr region
> 
> York
 
No, this patch is needed. The patch you mentioned is just to allocate Secure memory
from first ddr region. But this patch is meant to increase Secure memory allocated from
2MB -> 66MB.

Sumit
York Sun Oct. 30, 2017, 6:35 p.m. UTC | #3
On 09/01/2017 01:24 AM, Sumit Garg wrote:
> Change DDR allocated for secure memory from 2 MB to 66 MB. This additional
> 64 MB secure memory is required for trusted OS running in Trusted Execution
> Environment using ARMv8 TrustZone.
> 
> Signed-off-by: Sumit Garg <sumit.garg@nxp.com>
> ---

Reformatted commit message to wrap back at or before 70 characters.
Applied to fsl-qoriq master. Thanks.

York
diff mbox series

Patch

diff --git a/arch/arm/include/asm/arch-fsl-layerscape/config.h b/arch/arm/include/asm/arch-fsl-layerscape/config.h
index a7098be..95e2791 100644
--- a/arch/arm/include/asm/arch-fsl-layerscape/config.h
+++ b/arch/arm/include/asm/arch-fsl-layerscape/config.h
@@ -16,7 +16,7 @@ 
  * Reserve secure memory
  * To be aligned with MMU block size
  */
-#define CONFIG_SYS_MEM_RESERVE_SECURE	(2048 * 1024)	/* 2MB */
+#define CONFIG_SYS_MEM_RESERVE_SECURE	(66 * 1024 * 1024)	/* 66MB */
 #define SPL_TLB_SETBACK	0x1000000	/* 16MB under effective memory top */
 
 #ifdef CONFIG_ARCH_LS2080A