From patchwork Tue Apr 18 18:44:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 751929 X-Patchwork-Delegate: sjg@chromium.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.denx.de (dione.denx.de [81.169.180.215]) by ozlabs.org (Postfix) with ESMTP id 3w6vFk4nMDz9s3s for ; Wed, 19 Apr 2017 04:45:10 +1000 (AEST) Received: by lists.denx.de (Postfix, from userid 105) id 18062C21C5B; Tue, 18 Apr 2017 18:45:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=FREEMAIL_FROM, RCVD_IN_MSPIKE_H2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from lists.denx.de (localhost [IPv6:::1]) by lists.denx.de (Postfix) with ESMTP id 6C18EC21C26; Tue, 18 Apr 2017 18:45:05 +0000 (UTC) Received: by lists.denx.de (Postfix, from userid 105) id 612BFC21C26; Tue, 18 Apr 2017 18:45:04 +0000 (UTC) Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by lists.denx.de (Postfix) with ESMTPS id E8A74C21C1F for ; Tue, 18 Apr 2017 18:45:03 +0000 (UTC) Received: from workstation4.fritz.box ([95.222.184.236]) by mail.gmx.com (mrgmx001 [212.227.17.184]) with ESMTPSA (Nemesis) id 0LbuCq-1cHcRe3LE4-00jGDa; Tue, 18 Apr 2017 20:44:54 +0200 From: Heinrich Schuchardt To: Simon Glass Date: Tue, 18 Apr 2017 20:44:49 +0200 Message-Id: <1492541089-12778-1-git-send-email-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.1.4 In-Reply-To: References: MIME-Version: 1.0 X-Provags-ID: V03:K0:y7C7KephftmgLEF1XxGv1U4BPsXzd6UiIZTZh5dy/VRgha1OD1u t4XPB4ByDQBDEbv+94tAVLb4+1Cy1RE/uETVUTFK3rUK4O82QhBjv5F1Vp3dF7FI+H/etg5 siS3itjnOhf6jfw3eL53eLwBenG558JGnFIcjwNtDrd3oYzslOgQfKzcovUktD/sx+CZwq0 lWCjs0THe68H8SZ0oXHxA== X-UI-Out-Filterresults: notjunk:1; V01:K0:TrXNouAUFoM=:O+oApn2K77P7GGrVBKEyiv BSv/JP62HciihZieX+sx9nb4p+Xz0zeNLb8Wx9i4tl6Y7V/jP4s4zBwo9qZXx/xpRojfyRNqB SIht60b+tsj29N7yDvl6H8okWFr0cTECeXzyyCUTTzsWQgkivAunVpW0HzCBRAwnwe04pwAUF ocKDUeQfDlj6FsSiL+rwqXsYZ2Ysrq56hVPCK9TxK3rGtFVgjcXhUV/aN4753wWnO6lPLAvO1 uu19qNToAuwPcHrPA2681IMU0d/GWUjyxpB1031Rw6f3HvdQVHXGbErLyDBgL+X07mq6wN4lL I2j82XP7zVCHxaR9YbxJUv294ifMDfipijwR2axh2AxC6fGnctJDKC30/X2bfHpYKQhPrJmyb YlXvrP6HhYircPHhePDt7Aimw+vw+lV5OTJMAxDuKr/C5Tij5RyviT+ecKXps7bUN2uzH86Sf tKMuNmqP32gK4fl9ZneypyeUfjdoubpAOIZuoxvnvPrg6udopyMeYCe8DJ8T0UoL9T7d+EDaG 5nZ9dkyHccjzwwGw0+nWFBJzsXrIoG/RRO2zoLCrMKwPJonoTWhF4BJIa+vQBEusFesWPXx2n m+XUj9halBqW9Nx4vxcFR2Ow0/hak7jb1KkHtEBy4M/ZhqPORV1qqFT1ji/43cWfO+8gG9NA3 aHETt4Ta9LyKyjTpNsFHU1RjU2P0ul1Zk/7KDzEJ2kdXdZfb+77hIPHjTWRe5f0HYcPzoofkx 2sJb1KVRjqJ7zjTP3SR8pENmMzDeyEz/fRvAiBJyOHdR6K3f/87sMta3JImNJnWN1eapEIw+l ZSSDvs1 Cc: Heinrich Schuchardt , U-Boot Mailing List , =?UTF-8?q?Andreas=20F=C3=A4rber?= Subject: [U-Boot] [PATCH 1/1] core/uclass: uclass_get_device_tail: always set devp X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.18 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Set devp even if probing fails. Without the patch the following problem occurs: If the first block device is not probed successfully no block device is passed by bootefi to the EFI executable. The problem was reported by Andreas Färber in https://lists.denx.de/pipermail/u-boot/2017-April/287432.html For testing I used an odroid-c2 with a dts including &sd_emmc_a { status = "okay"; } This device does not exist on the board and cannot be initialized. Reported-by: Andreas Färber Signed-off-by: Heinrich Schuchardt --- drivers/core/uclass.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/core/uclass.c b/drivers/core/uclass.c index 04fb45b..b647384 100644 --- a/drivers/core/uclass.c +++ b/drivers/core/uclass.c @@ -349,12 +349,13 @@ int uclass_get_device_tail(struct udevice *dev, int ret, return ret; assert(dev); + + *devp = dev; + ret = device_probe(dev); if (ret) return ret; - *devp = dev; - return 0; }