| Message ID | 1484708635-14722-3-git-send-email-eddie.cai@rock-chips.com |
|---|---|
| State | Accepted |
| Delegated to: | Simon Glass |
| Headers | show |
Hi Eddie,
This patch is no need. Jacob Chen has already send patch to update
the sdram params
for rk3288 miniarm, and that patch has acked by Simon.
Thanks,
- Kever
On 01/18/2017 11:03 AM, Eddie Cai wrote:
> The final version of Tinker board is using two channel LPDDR3.
> So modify dmc configuration to meet it.
>
> Signed-off-by: Eddie Cai <eddie.cai@rock-chips.com>
> ---
> arch/arm/dts/rk3288-tinker.dts | 17 ++++++++---------
> 1 file changed, 8 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/dts/rk3288-tinker.dts b/arch/arm/dts/rk3288-tinker.dts
> index 4dacc76..090c100 100644
> --- a/arch/arm/dts/rk3288-tinker.dts
> +++ b/arch/arm/dts/rk3288-tinker.dts
> @@ -17,17 +17,16 @@
> };
>
> &dmc {
> - rockchip,pctl-timing = <0x29a 0xc8 0x1f8 0x42 0x4e 0x4 0xea 0xa
> - 0x5 0x0 0xa 0x7 0x19 0x24 0xa 0x7
> - 0x5 0xa 0x5 0x200 0x5 0x10 0x40 0x0
> - 0x1 0x7 0x7 0x4 0xc 0x43 0x100 0x0
> - 0x5 0x0>;
> - rockchip,phy-timing = <0x48f9aab4 0xea0910 0x1002c200
> - 0xa60 0x40 0x10 0x0>;
> - rockchip,sdram-params = <0x30B25564 0x627 3 666000000 3 9 1>;
> + rockchip,pctl-timing = <0x215 0xc8 0x0 0x35 0x26 0x2 0x70 0x2000d
> + 0x6 0x0 0x8 0x4 0x17 0x24 0xd 0x6
> + 0x4 0x8 0x4 0x76 0x4 0x0 0x30 0x0
> + 0x1 0x2 0x2 0x4 0x0 0x0 0xc0 0x4
> + 0x8 0x1f4>;
> + rockchip,phy-timing = <0x48d7dd93 0x187008d8 0x121076
> + 0x0 0xc3 0x6 0x2>;
> + rockchip,sdram-params = <0x20d266a4 0x5b6 2 533000000 6 9 0>;
> };
>
> -
> &pinctrl {
> u-boot,dm-pre-reloc;
> };
Thanks Kever Hi Simon I did some search and found you acked the Jacob's patch, see [0]. But didn't apply it. Did you lost this patch? [0]https://patchwork.ozlabs.org/patch/694820/ 2017-01-18 11:43 GMT+08:00 Kever Yang <kever.yang@rock-chips.com>: > Hi Eddie, > > This patch is no need. Jacob Chen has already send patch to update the > sdram params > for rk3288 miniarm, and that patch has acked by Simon. > > Thanks, > - Kever > > On 01/18/2017 11:03 AM, Eddie Cai wrote: > >> The final version of Tinker board is using two channel LPDDR3. >> So modify dmc configuration to meet it. >> >> Signed-off-by: Eddie Cai <eddie.cai@rock-chips.com> >> --- >> arch/arm/dts/rk3288-tinker.dts | 17 ++++++++--------- >> 1 file changed, 8 insertions(+), 9 deletions(-) >> >> diff --git a/arch/arm/dts/rk3288-tinker.dts >> b/arch/arm/dts/rk3288-tinker.dts >> index 4dacc76..090c100 100644 >> --- a/arch/arm/dts/rk3288-tinker.dts >> +++ b/arch/arm/dts/rk3288-tinker.dts >> @@ -17,17 +17,16 @@ >> }; >> &dmc { >> - rockchip,pctl-timing = <0x29a 0xc8 0x1f8 0x42 0x4e 0x4 0xea 0xa >> - 0x5 0x0 0xa 0x7 0x19 0x24 0xa 0x7 >> - 0x5 0xa 0x5 0x200 0x5 0x10 0x40 0x0 >> - 0x1 0x7 0x7 0x4 0xc 0x43 0x100 0x0 >> - 0x5 0x0>; >> - rockchip,phy-timing = <0x48f9aab4 0xea0910 0x1002c200 >> - 0xa60 0x40 0x10 0x0>; >> - rockchip,sdram-params = <0x30B25564 0x627 3 666000000 3 9 1>; >> + rockchip,pctl-timing = <0x215 0xc8 0x0 0x35 0x26 0x2 0x70 0x2000d >> + 0x6 0x0 0x8 0x4 0x17 0x24 0xd 0x6 >> + 0x4 0x8 0x4 0x76 0x4 0x0 0x30 0x0 >> + 0x1 0x2 0x2 0x4 0x0 0x0 0xc0 0x4 >> + 0x8 0x1f4>; >> + rockchip,phy-timing = <0x48d7dd93 0x187008d8 0x121076 >> + 0x0 0xc3 0x6 0x2>; >> + rockchip,sdram-params = <0x20d266a4 0x5b6 2 533000000 6 9 0>; >> }; >> - >> &pinctrl { >> u-boot,dm-pre-reloc; >> }; >> > > >
Hi Eddie, On 17 January 2017 at 21:51, Eddie Cai <eddie.cai.linux@gmail.com> wrote: > Thanks Kever > Hi Simon > > I did some search and found you acked the Jacob's patch, see [0]. But didn't > apply it. Did you lost this patch? > > [0]https://patchwork.ozlabs.org/patch/694820/ Yes I did - will reply on that thread. Regards, Simon
diff --git a/arch/arm/dts/rk3288-tinker.dts b/arch/arm/dts/rk3288-tinker.dts index 4dacc76..090c100 100644 --- a/arch/arm/dts/rk3288-tinker.dts +++ b/arch/arm/dts/rk3288-tinker.dts @@ -17,17 +17,16 @@ }; &dmc { - rockchip,pctl-timing = <0x29a 0xc8 0x1f8 0x42 0x4e 0x4 0xea 0xa - 0x5 0x0 0xa 0x7 0x19 0x24 0xa 0x7 - 0x5 0xa 0x5 0x200 0x5 0x10 0x40 0x0 - 0x1 0x7 0x7 0x4 0xc 0x43 0x100 0x0 - 0x5 0x0>; - rockchip,phy-timing = <0x48f9aab4 0xea0910 0x1002c200 - 0xa60 0x40 0x10 0x0>; - rockchip,sdram-params = <0x30B25564 0x627 3 666000000 3 9 1>; + rockchip,pctl-timing = <0x215 0xc8 0x0 0x35 0x26 0x2 0x70 0x2000d + 0x6 0x0 0x8 0x4 0x17 0x24 0xd 0x6 + 0x4 0x8 0x4 0x76 0x4 0x0 0x30 0x0 + 0x1 0x2 0x2 0x4 0x0 0x0 0xc0 0x4 + 0x8 0x1f4>; + rockchip,phy-timing = <0x48d7dd93 0x187008d8 0x121076 + 0x0 0xc3 0x6 0x2>; + rockchip,sdram-params = <0x20d266a4 0x5b6 2 533000000 6 9 0>; }; - &pinctrl { u-boot,dm-pre-reloc; };
The final version of Tinker board is using two channel LPDDR3. So modify dmc configuration to meet it. Signed-off-by: Eddie Cai <eddie.cai@rock-chips.com> --- arch/arm/dts/rk3288-tinker.dts | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-)