From patchwork Tue Jan 10 10:18:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 713210 X-Patchwork-Delegate: jh80.chung@samsung.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 3tySfw3zRYz9s3T for ; Tue, 10 Jan 2017 21:19:03 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id A0629B38D6; Tue, 10 Jan 2017 11:18:59 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id agj0s_A7xa4J; Tue, 10 Jan 2017 11:18:59 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 7B906B3898; Tue, 10 Jan 2017 11:18:58 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 4F9DDA7641 for ; Tue, 10 Jan 2017 11:18:56 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u9UogRvxWfPa for ; Tue, 10 Jan 2017 11:18:56 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-wj0-f194.google.com (mail-wj0-f194.google.com [209.85.210.194]) by theia.denx.de (Postfix) with ESMTPS id 11B87A7616 for ; Tue, 10 Jan 2017 11:18:52 +0100 (CET) Received: by mail-wj0-f194.google.com with SMTP id ey1so7969976wjd.2 for ; Tue, 10 Jan 2017 02:18:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=UupEg+M6c1AJKVXcIw9QsU8gOt26ezMufHlGxCKfwNY=; b=hz2ADQrSFv2hokeFSLgcO1/JnyiokstSItRsM/YpJuhfqMcOuW90EF3zV+zFnnJOCR edk5JZXOnf6kZyfIxMkG0e7PNUyMS3gSRJSQ0NTW8N6LJsRPV0kq612qMI4BVIUDjOQK PoFey4vyQzr5loUt+iJffc+CH7gxnfAJrSn+tSYbbAco1TnpaF9Q8zi/s5o7immO6uW2 bGJ1jmLj5GpydM66gq9js01fEozyrXfsHphAh1TT6jjtm00bqa1MC7SUifnImqPXHhzK FcRQhGqvh69S3NeX+cA2pQWVoQDkAvxzdBb3COFWeZTyNXfqIxadIpfeHbsBK46P/CB5 DU+w== X-Gm-Message-State: AIkVDXLF4wV4sFiAPDsKgBOvkqJ4PFoPaHmik453Pwf46i4twyXgrkUp35Y04hlmQKscZg== X-Received: by 10.194.79.33 with SMTP id g1mr1302966wjx.130.1484043532154; Tue, 10 Jan 2017 02:18:52 -0800 (PST) Received: from jagan-XPS-13-9350.homenet.telecomitalia.it (host47-201-static.1-79-b.business.telecomitalia.it. [79.1.201.47]) by smtp.gmail.com with ESMTPSA id 203sm23685894wmf.21.2017.01.10.02.18.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 10 Jan 2017 02:18:50 -0800 (PST) From: Jagan Teki To: u-boot@lists.denx.de Date: Tue, 10 Jan 2017 11:18:43 +0100 Message-Id: <1484043523-29721-1-git-send-email-jagan@openedev.com> X-Mailer: git-send-email 1.9.1 Subject: [U-Boot] [PATCH 14/20] mmc: Print error code for mmc_complete_init failure X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Jagan Teki Print the error code for non-zero (failure case) instead of making debug statement without any condition, this usually gives proper clue in failure condition. Log: --- MMC: FSL_SDHC: 0 mmc_init: -70, time 38 *** Warning - MMC init failed, using default environment Cc: Jaehoon Chung Signed-off-by: Jagan Teki --- drivers/mmc/mmc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index 9f8368a..3648950 100644 --- a/drivers/mmc/mmc.c +++ b/drivers/mmc/mmc.c @@ -1751,7 +1751,9 @@ int mmc_init(struct mmc *mmc) if (!err) err = mmc_complete_init(mmc); - debug("%s: %d, time %lu\n", __func__, err, get_timer(start)); + if (err) + printf("%s: %d, time %lu\n", __func__, err, get_timer(start)); + return err; }