Message ID | 1484043523-29721-1-git-send-email-jagan@openedev.com |
---|---|
State | Accepted |
Commit | 919b485834a746cf839ccded41e456d17d57a31f |
Delegated to: | Jaehoon Chung |
Headers | show |
Hi, On 01/10/2017 07:18 PM, Jagan Teki wrote: > From: Jagan Teki <jagan@amarulasolutions.com> > > Print the error code for non-zero (failure case) instead > of making debug statement without any condition, this > usually gives proper clue in failure condition. > > Log: > --- > MMC: FSL_SDHC: 0 > mmc_init: -70, time 38 > *** Warning - MMC init failed, using default environment > > Cc: Jaehoon Chung <jh80.chung@samsung.com> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> I didn't see the other patches..but i picked this patch on u-boot-mmc. Applied on u-boot-mmc. Thanks! Best Regards, Jaehoon Chung > --- > drivers/mmc/mmc.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c > index 9f8368a..3648950 100644 > --- a/drivers/mmc/mmc.c > +++ b/drivers/mmc/mmc.c > @@ -1751,7 +1751,9 @@ int mmc_init(struct mmc *mmc) > > if (!err) > err = mmc_complete_init(mmc); > - debug("%s: %d, time %lu\n", __func__, err, get_timer(start)); > + if (err) > + printf("%s: %d, time %lu\n", __func__, err, get_timer(start)); > + > return err; > } > >
diff --git a/drivers/mmc/mmc.c b/drivers/mmc/mmc.c index 9f8368a..3648950 100644 --- a/drivers/mmc/mmc.c +++ b/drivers/mmc/mmc.c @@ -1751,7 +1751,9 @@ int mmc_init(struct mmc *mmc) if (!err) err = mmc_complete_init(mmc); - debug("%s: %d, time %lu\n", __func__, err, get_timer(start)); + if (err) + printf("%s: %d, time %lu\n", __func__, err, get_timer(start)); + return err; }