diff mbox

[U-Boot,v3,11/13] i2c: mxc: Print hex instead of decimal for bus address

Message ID 1480978860-4351-12-git-send-email-jagan@openedev.com
State Superseded
Delegated to: Stefano Babic
Headers show

Commit Message

Jagan Teki Dec. 5, 2016, 11 p.m. UTC 
From: Jagan Teki <jagan@amarulasolutions.com>

Better to print the hex value for bus address instead of
decimal, for more readbility on bus addressing.

Before:
------
U-Boot> i2c dev 1
Setting bus to 1
i2c bus 1 at 35274752, no gpio pinctrl state.

After:
------
U-Boot> i2c dev 1
Setting bus to 1
i2c bus 1 at 0x21a4000, no gpio pinctrl state.

Cc: Simon Glass <sjg@chromium.org>
Cc: Heiko Schocher <hs@denx.de>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/i2c/mxc_i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Heiko Schocher Dec. 6, 2016, 2:07 p.m. UTC | #1 
Hello Jagan,

Am 06.12.2016 um 00:00 schrieb Jagan Teki:
> From: Jagan Teki <jagan@amarulasolutions.com>
>
> Better to print the hex value for bus address instead of
> decimal, for more readbility on bus addressing.
>
> Before:
> ------
> U-Boot> i2c dev 1
> Setting bus to 1
> i2c bus 1 at 35274752, no gpio pinctrl state.
>
> After:
> ------
> U-Boot> i2c dev 1
> Setting bus to 1
> i2c bus 1 at 0x21a4000, no gpio pinctrl state.
>
> Cc: Simon Glass <sjg@chromium.org>
> Cc: Heiko Schocher <hs@denx.de>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Michael Trimarchi <michael@amarulasolutions.com>
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
>   drivers/i2c/mxc_i2c.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Acked-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
>
> diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c
> index 6247d33..03a5ce9 100644
> --- a/drivers/i2c/mxc_i2c.c
> +++ b/drivers/i2c/mxc_i2c.c
> @@ -775,7 +775,7 @@ static int mxc_i2c_probe(struct udevice *bus)
>   	 */
>   	ret = fdt_stringlist_search(fdt, node, "pinctrl-names", "gpio");
>   	if (ret < 0) {
> -		dev_info(dev, "i2c bus %d at %lu, no gpio pinctrl state.\n", bus->seq, i2c_bus->base);
> +		dev_info(dev, "i2c bus %d at 0x%2lx, no gpio pinctrl state.\n", bus->seq, i2c_bus->base);
>   	} else {
>   		ret = gpio_request_by_name_nodev(fdt, node, "scl-gpios",
>   						 0, &i2c_bus->scl_gpio,
>
diff mbox

Patch

diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c
index 6247d33..03a5ce9 100644
--- a/drivers/i2c/mxc_i2c.c
+++ b/drivers/i2c/mxc_i2c.c
@@ -775,7 +775,7 @@  static int mxc_i2c_probe(struct udevice *bus)
 	 */
 	ret = fdt_stringlist_search(fdt, node, "pinctrl-names", "gpio");
 	if (ret < 0) {
-		dev_info(dev, "i2c bus %d at %lu, no gpio pinctrl state.\n", bus->seq, i2c_bus->base);
+		dev_info(dev, "i2c bus %d at 0x%2lx, no gpio pinctrl state.\n", bus->seq, i2c_bus->base);
 	} else {
 		ret = gpio_request_by_name_nodev(fdt, node, "scl-gpios",
 						 0, &i2c_bus->scl_gpio,