diff mbox

[U-Boot,v6,07/21] sf: Increase max id length by 1 byte

Message ID 1479268992-26811-8-git-send-email-jagan@openedev.com
State Accepted
Commit 0bdb7cb91f26c07424ed8ca9136c41d0755a1437
Delegated to: Jagannadha Sutradharudu Teki
Headers show

Commit Message

Jagan Teki Nov. 16, 2016, 4:02 a.m. UTC 
So, now SPI_FLASH_ID_MAX_LEN is 6 bytes useful for
few spansion flash families S25FS-S

Cc: Bin Meng <bmeng.cn@gmail.com>
Cc: York Sun <york.sun@nxp.com>
Cc: Vignesh R <vigneshr@ti.com>
Cc: Mugunthan V N <mugunthanvnm@ti.com>
Cc: Michal Simek <michal.simek@xilinx.com>
Cc: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
Signed-off-by: Jagan Teki <jagan@openedev.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Jagan Teki <jagan@openedev.com>
Tested-by: Jagan Teki <jagan@openedev.com>
---
 drivers/mtd/spi/sf_internal.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Siva Durga Prasad Paladugu Nov. 16, 2016, 6 a.m. UTC | #1 
Hi,

> -----Original Message-----
> From: Jagan Teki [mailto:jagan@openedev.com]
> Sent: Wednesday, November 16, 2016 9:33 AM
> To: u-boot@lists.denx.de
> Cc: Jagan Teki <jagan@openedev.com>; Bin Meng <bmeng.cn@gmail.com>;
> York Sun <york.sun@nxp.com>; Vignesh R <vigneshr@ti.com>; Mugunthan V
> N <mugunthanvnm@ti.com>; Michal Simek <michal.simek@xilinx.com>; Siva
> Durga Prasad Paladugu <sivadur@xilinx.com>
> Subject: [PATCH v6 07/21] sf: Increase max id length by 1 byte
>
> So, now SPI_FLASH_ID_MAX_LEN is 6 bytes useful for few spansion flash
> families S25FS-S
Good, This is what, I want to see from first patch.
>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> Cc: York Sun <york.sun@nxp.com>
> Cc: Vignesh R <vigneshr@ti.com>
> Cc: Mugunthan V N <mugunthanvnm@ti.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> Signed-off-by: Jagan Teki <jagan@openedev.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Jagan Teki <jagan@openedev.com>
> Tested-by: Jagan Teki <jagan@openedev.com>
Reviewed-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>

Thanks,
Siva
> ---
>  drivers/mtd/spi/sf_internal.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi/sf_internal.h b/drivers/mtd/spi/sf_internal.h
> index 770f628..cbed6e8 100644
> --- a/drivers/mtd/spi/sf_internal.h
> +++ b/drivers/mtd/spi/sf_internal.h
> @@ -107,7 +107,7 @@ int sst_write_bp(struct spi_flash *flash, u32 offset,
> size_t len,
>  #define JEDEC_MFR(info)              ((info)->id[0])
>  #define JEDEC_ID(info)               (((info)->id[1]) << 8 | ((info)->id[2]))
>  #define JEDEC_EXT(info)              (((info)->id[3]) << 8 | ((info)->id[4]))
> -#define SPI_FLASH_MAX_ID_LEN 5
> +#define SPI_FLASH_MAX_ID_LEN 6
>
>  struct spi_flash_info {
>       /* Device name ([MANUFLETTER][DEVTYPE][DENSITY][EXTRAINFO]) */
> --
> 1.9.1



This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately.
Siva Durga Prasad Paladugu Nov. 16, 2016, 6:02 a.m. UTC | #2 
Hi,

> -----Original Message-----
> From: Jagan Teki [mailto:jagan@openedev.com]
> Sent: Wednesday, November 16, 2016 9:33 AM
> To: u-boot@lists.denx.de
> Cc: Jagan Teki <jagan@openedev.com>; Bin Meng <bmeng.cn@gmail.com>;
> York Sun <york.sun@nxp.com>; Vignesh R <vigneshr@ti.com>; Mugunthan V
> N <mugunthanvnm@ti.com>; Michal Simek <michal.simek@xilinx.com>; Siva
> Durga Prasad Paladugu <sivadur@xilinx.com>
> Subject: [PATCH v6 07/21] sf: Increase max id length by 1 byte
> 
> So, now SPI_FLASH_ID_MAX_LEN is 6 bytes useful for few spansion flash
> families S25FS-S
Good, This is what, I want to see from first patch.
> 
> Cc: Bin Meng <bmeng.cn@gmail.com>
> Cc: York Sun <york.sun@nxp.com>
> Cc: Vignesh R <vigneshr@ti.com>
> Cc: Mugunthan V N <mugunthanvnm@ti.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Cc: Siva Durga Prasad Paladugu <sivadur@xilinx.com>
> Signed-off-by: Jagan Teki <jagan@openedev.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Jagan Teki <jagan@openedev.com>
> Tested-by: Jagan Teki <jagan@openedev.com>
Reviewed-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com>

Thanks,
Siva
> ---
>  drivers/mtd/spi/sf_internal.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi/sf_internal.h b/drivers/mtd/spi/sf_internal.h
> index 770f628..cbed6e8 100644
> --- a/drivers/mtd/spi/sf_internal.h
> +++ b/drivers/mtd/spi/sf_internal.h
> @@ -107,7 +107,7 @@ int sst_write_bp(struct spi_flash *flash, u32 offset,
> size_t len,
>  #define JEDEC_MFR(info)		((info)->id[0])
>  #define JEDEC_ID(info)		(((info)->id[1]) << 8 | ((info)->id[2]))
>  #define JEDEC_EXT(info)		(((info)->id[3]) << 8 | ((info)->id[4]))
> -#define SPI_FLASH_MAX_ID_LEN	5
> +#define SPI_FLASH_MAX_ID_LEN	6
> 
>  struct spi_flash_info {
>  	/* Device name ([MANUFLETTER][DEVTYPE][DENSITY][EXTRAINFO]) */
> --
> 1.9.1
diff mbox

Patch

diff --git a/drivers/mtd/spi/sf_internal.h b/drivers/mtd/spi/sf_internal.h
index 770f628..cbed6e8 100644
--- a/drivers/mtd/spi/sf_internal.h
+++ b/drivers/mtd/spi/sf_internal.h
@@ -107,7 +107,7 @@  int sst_write_bp(struct spi_flash *flash, u32 offset, size_t len,
 #define JEDEC_MFR(info)		((info)->id[0])
 #define JEDEC_ID(info)		(((info)->id[1]) << 8 | ((info)->id[2]))
 #define JEDEC_EXT(info)		(((info)->id[3]) << 8 | ((info)->id[4]))
-#define SPI_FLASH_MAX_ID_LEN	5
+#define SPI_FLASH_MAX_ID_LEN	6
 
 struct spi_flash_info {
 	/* Device name ([MANUFLETTER][DEVTYPE][DENSITY][EXTRAINFO]) */