From patchwork Wed Nov 16 04:02:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 695421 X-Patchwork-Delegate: jagannadh.teki@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 3tJVyF2Sl5z9syB for ; Wed, 16 Nov 2016 15:04:37 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 5B6C9A7599; Wed, 16 Nov 2016 05:04:17 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xUaI1ah_X4sM; Wed, 16 Nov 2016 05:04:17 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 393DCA754C; Wed, 16 Nov 2016 05:04:08 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 3896AA7558 for ; Wed, 16 Nov 2016 05:04:04 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id S_4SaOYEj2_4 for ; Wed, 16 Nov 2016 05:04:04 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-pg0-f66.google.com (mail-pg0-f66.google.com [74.125.83.66]) by theia.denx.de (Postfix) with ESMTPS id 0BFDFB382E for ; Wed, 16 Nov 2016 05:03:57 +0100 (CET) Received: by mail-pg0-f66.google.com with SMTP id x23so13483793pgx.3 for ; Tue, 15 Nov 2016 20:03:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4MHrMLKWxmbyOhn3+nf0LAVigYpzehpy4Wt+ewb0y98=; b=e1Gdcwcq6qLIoNyGCBD8aJ/4ccUb9RTHgCsmAkkq6vn0/mC+RpXtjIgB5kAykJOoym bgD40xqpqK1BDTUA2WPgNOfcbGm/cjcgKEf8WBXtyYkAJoBCVADL7C/zRF5tu6sPZ9uQ 5zScDN88w3psghFXYNBjuhvQ9/7IHWuHP/uIMXiIAf9eVeJpLK5yWNqulJswprQG7DN9 pqaaEZVH7iogOvtn1I8yOGBDodeoR+HO3T/KfoI7dVFhzhUL2vIbxiUf18QklwYkDuGA 2rxlmqnYidTSqE2iWIcDlZfqQwyN1dzKTll7CON4nrfq2eN0MsY7Y9w7XPt4jIAt4VdG AL3A== X-Gm-Message-State: ABUngveJb58cSKYxrz38EbmsLwGRE893Sc1wmkovf63cOXRr+QjGExg0yZbxxXeyIdQrWg== X-Received: by 10.99.204.81 with SMTP id q17mr3650579pgi.168.1479269036376; Tue, 15 Nov 2016 20:03:56 -0800 (PST) Received: from localhost.localdomain ([115.97.183.210]) by smtp.gmail.com with ESMTPSA id q145sm25217663pfq.22.2016.11.15.20.03.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 15 Nov 2016 20:03:54 -0800 (PST) From: Jagan Teki To: u-boot@lists.denx.de Date: Wed, 16 Nov 2016 09:32:55 +0530 Message-Id: <1479268992-26811-5-git-send-email-jagan@openedev.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1479268992-26811-1-git-send-email-jagan@openedev.com> References: <1479268992-26811-1-git-send-email-jagan@openedev.com> MIME-Version: 1.0 Cc: Michal Simek , Siva Durga Prasad Paladugu , Jagan Teki Subject: [U-Boot] [PATCH v6 04/21] sf: Cleanup spi_flash_info{} X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" - Proper tabs spaces - Removed unnecessary - Added meaningful comments  Cc: Simon Glass Cc: Bin Meng Cc: York Sun Cc: Vignesh R Cc: Mugunthan V N Cc: Michal Simek Cc: Siva Durga Prasad Paladugu Signed-off-by: Jagan Teki Reviewed-by: Siva Durga Prasad Paladugu --- drivers/mtd/spi/sf_internal.h | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/mtd/spi/sf_internal.h b/drivers/mtd/spi/sf_internal.h index a9455ac..d7ac6b3 100644 --- a/drivers/mtd/spi/sf_internal.h +++ b/drivers/mtd/spi/sf_internal.h @@ -108,17 +108,9 @@ int sst_write_bp(struct spi_flash *flash, u32 offset, size_t len, #define JEDEC_ID(info) (((info)->id[1]) << 8 | ((info)->id[2])) #define JEDEC_EXT(info) (((info)->id[3]) << 8 | ((info)->id[4])) -/** - * struct spi_flash_info - SPI/QSPI flash device params structure - * - * @name: Device name ([MANUFLETTER][DEVTYPE][DENSITY][EXTRAINFO]) - * @sector_size: Isn't necessarily a sector size from vendor, - * the size listed here is what works with CMD_ERASE_64K - * @nr_sectors: No.of sectors on this device - * @flags: Important param, for flash specific behaviour - */ struct spi_flash_info { - const char *name; + /* Device name ([MANUFLETTER][DEVTYPE][DENSITY][EXTRAINFO]) */ + const char *name; /* * This array stores the ID bytes. @@ -128,12 +120,16 @@ struct spi_flash_info { u8 id[5]; u8 id_len; - u32 sector_size; - u32 nr_sectors; + /* + * The size listed here is what works with SPINOR_OP_SE, which isn't + * necessarily called a "sector" by the vendor. + */ + u32 sector_size; + u32 nr_sectors; - u16 page_size; + u16 page_size; - u16 flags; + u16 flags; #define SECT_4K BIT(0) #define E_FSR BIT(1) #define SST_WR BIT(2)