| Message ID | 1479268992-26811-12-git-send-email-jagan@openedev.com |
|---|---|
| State | Accepted |
| Commit | 475bf816f1fbc7be5c5ba12cd456841a0f9508c9 |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
Hi, > -----Original Message----- > From: Jagan Teki [mailto:jagan@openedev.com] > Sent: Wednesday, November 16, 2016 9:33 AM > To: u-boot@lists.denx.de > Cc: Jagan Teki <jagan@openedev.com>; Bin Meng <bmeng.cn@gmail.com>; > York Sun <york.sun@nxp.com>; Vignesh R <vigneshr@ti.com>; Mugunthan V > N <mugunthanvnm@ti.com>; Michal Simek <michal.simek@xilinx.com>; Siva > Durga Prasad Paladugu <sivadur@xilinx.com> > Subject: [PATCH v6 11/21] sf: Remove non-meaningful comments > > Remove unneeded/non-meaningful commit message on params and flash. > > Cc: Bin Meng <bmeng.cn@gmail.com> > Cc: York Sun <york.sun@nxp.com> > Cc: Vignesh R <vigneshr@ti.com> > Cc: Mugunthan V N <mugunthanvnm@ti.com> > Cc: Michal Simek <michal.simek@xilinx.com> > Cc: Siva Durga Prasad Paladugu <sivadur@xilinx.com> > Signed-off-by: Jagan Teki <jagan@openedev.com> > Reviewed-by: Simon Glass <sjg@chromium.org> > Reviewed-by: Jagan Teki <jagan@openedev.com> Reviewed-by: Siva Durga Prasad Paladugu <sivadur@xilinx.com> Thanks, Siva > --- > drivers/mtd/spi/sf_params.c | 1 - > drivers/mtd/spi/spi_flash.c | 3 --- > 2 files changed, 4 deletions(-) > > diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c index > 6157e29..05cedf1 100644 > --- a/drivers/mtd/spi/sf_params.c > +++ b/drivers/mtd/spi/sf_params.c > @@ -42,7 +42,6 @@ > .page_size = 256, \ > .flags = (_flags), > > -/* SPI/QSPI flash device params structure */ const struct spi_flash_info > spi_flash_ids[] = { > #ifdef CONFIG_SPI_FLASH_ATMEL /* ATMEL */ > {"AT45DB011D", INFO(0x1f2200, 0x0, 64 * 1024, 4, > SECT_4K) }, > diff --git a/drivers/mtd/spi/spi_flash.c b/drivers/mtd/spi/spi_flash.c index > b126a21..813f08d 100644 > --- a/drivers/mtd/spi/spi_flash.c > +++ b/drivers/mtd/spi/spi_flash.c > @@ -1015,16 +1015,13 @@ int spi_flash_scan(struct spi_flash *flash) > JEDEC_MFR(info) == SPI_FLASH_CFI_MFR_SST) > write_sr(flash, 0); > > - /* Assign spi data */ > flash->name = info->name; > flash->memory_map = spi->memory_map; > flash->dual_flash = spi->option; > > - /* Assign spi flash flags */ > if (info->flags & SST_WR) > flash->flags |= SNOR_F_SST_WR; > > - /* Assign spi_flash ops */ > #ifndef CONFIG_DM_SPI_FLASH > flash->write = spi_flash_cmd_write_ops; #if > defined(CONFIG_SPI_FLASH_SST) > -- > 1.9.1
diff --git a/drivers/mtd/spi/sf_params.c b/drivers/mtd/spi/sf_params.c index 6157e29..05cedf1 100644 --- a/drivers/mtd/spi/sf_params.c +++ b/drivers/mtd/spi/sf_params.c @@ -42,7 +42,6 @@ .page_size = 256, \ .flags = (_flags), -/* SPI/QSPI flash device params structure */ const struct spi_flash_info spi_flash_ids[] = { #ifdef CONFIG_SPI_FLASH_ATMEL /* ATMEL */ {"AT45DB011D", INFO(0x1f2200, 0x0, 64 * 1024, 4, SECT_4K) }, diff --git a/drivers/mtd/spi/spi_flash.c b/drivers/mtd/spi/spi_flash.c index b126a21..813f08d 100644 --- a/drivers/mtd/spi/spi_flash.c +++ b/drivers/mtd/spi/spi_flash.c @@ -1015,16 +1015,13 @@ int spi_flash_scan(struct spi_flash *flash) JEDEC_MFR(info) == SPI_FLASH_CFI_MFR_SST) write_sr(flash, 0); - /* Assign spi data */ flash->name = info->name; flash->memory_map = spi->memory_map; flash->dual_flash = spi->option; - /* Assign spi flash flags */ if (info->flags & SST_WR) flash->flags |= SNOR_F_SST_WR; - /* Assign spi_flash ops */ #ifndef CONFIG_DM_SPI_FLASH flash->write = spi_flash_cmd_write_ops; #if defined(CONFIG_SPI_FLASH_SST)