From patchwork Wed Nov 9 11:50:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 692715 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 3tDPgC0YRpz9ssP for ; Wed, 9 Nov 2016 22:52:23 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 85C6AA75A9; Wed, 9 Nov 2016 12:52:00 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9vvT0g0iIy-o; Wed, 9 Nov 2016 12:52:00 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id D92E5A7558; Wed, 9 Nov 2016 12:51:58 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 8C2B8B382B for ; Wed, 9 Nov 2016 12:51:54 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9vL6my11IREN for ; Wed, 9 Nov 2016 12:51:54 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-pf0-f194.google.com (mail-pf0-f194.google.com [209.85.192.194]) by theia.denx.de (Postfix) with ESMTPS id 52DEEB382D for ; Wed, 9 Nov 2016 12:51:52 +0100 (CET) Received: by mail-pf0-f194.google.com with SMTP id n85so23399863pfi.3 for ; Wed, 09 Nov 2016 03:51:52 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9mBbbvnHrhQGoxFv9uyXeoCWUic3tp5Hc/H8FMFJE4Q=; b=eNVCCGvwxSvgtE+57afwBxD6+87w2jZY1azep5sff1zar1hCLYMI1Hpf4JoU4z07XN iYgd8dtK3hmxzEpo8nXln0iRu4QLahDDkjfwk+uFup0zuDzwQfYXwwHJ4VrDh8HhZqOK NXnPlpvPOWkN1t5NjgOX80RyKoWPcctYqxR+ii2msZRScHEZtbh/g4jv2+Umchjl+C07 TOkbQL7ImDaKbKcSRQxMQXLE3c68HcTk20XqvyX2ZXQL9TEyyepKOoMBfq9Qvnu/dNN+ NPDcr7Z3PsBaxxkxv6f/t0pDWIAfzDl4eH5hdRjL+XAiOoZEkhEp1Z2aYaRaBrg+O3Nr uICQ== X-Gm-Message-State: ABUngvd5GKnlm1qglwj+iIaVE2majYI0vp3XBCkst82XH5FfZH6TfJrnVMKUYC5bTywqfQ== X-Received: by 10.98.139.157 with SMTP id e29mr32376513pfl.115.1478692310959; Wed, 09 Nov 2016 03:51:50 -0800 (PST) Received: from localhost.localdomain ([115.118.123.122]) by smtp.gmail.com with ESMTPSA id yx8sm55437092pac.29.2016.11.09.03.51.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 09 Nov 2016 03:51:49 -0800 (PST) From: Jagan Teki To: Stefano Babic Date: Wed, 9 Nov 2016 17:20:00 +0530 Message-Id: <1478692203-4442-5-git-send-email-jagan@openedev.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1478692203-4442-1-git-send-email-jagan@openedev.com> References: <1478692203-4442-1-git-send-email-jagan@openedev.com> Cc: u-boot@lists.denx.de, Matteo Lisi Subject: [U-Boot] [PATCH v2 4/7] net: fec: Zap local mac variable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Jagan Teki Call dev->enetaddr or pdata->enetaddr directly in eth_ops instead of local mac variable. Cc: Stefano Babic Cc: Matteo Lisi Cc: Michael Trimarchi Acked-by: Joe Hershberger Signed-off-by: Jagan Teki --- drivers/net/fec_mxc.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index 09433df..787823c 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -934,9 +934,8 @@ struct mii_dev *fec_get_miibus(uint32_t base_addr, int dev_id) static int fec_recv(struct eth_device *dev) { struct fec_priv *fec = (struct fec_priv *)dev->priv; - uchar *mac = dev->enetaddr; - return _fec_recv(fec, mac); + return _fec_recv(fec, dev->enetaddr); } static int fec_send(struct eth_device *dev, void *packet, int length) @@ -956,17 +955,15 @@ static void fec_halt(struct eth_device *dev) static int fec_set_hwaddr(struct eth_device *dev) { struct fec_priv *fec = (struct fec_priv *)dev->priv; - uchar *mac = dev->enetaddr; - return _fec_set_hwaddr(fec, mac); + return _fec_set_hwaddr(fec, dev->enetaddr); } static int fec_init(struct eth_device *dev, bd_t *bd) { struct fec_priv *fec = (struct fec_priv *)dev->priv; - uchar *mac = dev->enetaddr; - return _fec_init(fec, mac); + return _fec_init(fec, dev->enetaddr); } static int fec_get_hwaddr(int dev_id, unsigned char *mac) @@ -1142,9 +1139,8 @@ static int fec_set_hwaddr(struct udevice *dev) { struct fec_priv *fec = dev_get_priv(dev); struct eth_pdata *pdata = dev_get_platdata(dev); - uchar *mac = pdata->enetaddr; - return _fec_set_hwaddr(fec, mac); + return _fec_set_hwaddr(fec, pdata->enetaddr); } static void fec_halt(struct udevice *dev) @@ -1158,9 +1154,8 @@ static int fec_recv(struct udevice *dev, int flags, uchar **packetp) { struct fec_priv *fec = dev_get_priv(dev); struct eth_pdata *pdata = dev_get_platdata(dev); - uchar *mac = pdata->enetaddr; - return _fec_recv(fec, mac); + return _fec_recv(fec, pdata->enetaddr); } static int fec_send(struct udevice *dev, void *packet, int length) @@ -1174,9 +1169,8 @@ static int fec_init(struct udevice *dev) { struct fec_priv *fec = dev_get_priv(dev); struct eth_pdata *pdata = dev_get_platdata(dev); - uchar *mac = pdata->enetaddr; - return _fec_init(fec, mac); + return _fec_init(fec, pdata->enetaddr); } static const struct eth_ops fecmxc_ops = {