From patchwork Thu Nov 3 19:43:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jagan Teki X-Patchwork-Id: 690993 X-Patchwork-Delegate: joe.hershberger@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 3t8wSl49c3z9vDY for ; Fri, 4 Nov 2016 06:46:15 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 69DBEB3883; Thu, 3 Nov 2016 20:46:09 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 90tvDPEEnY36; Thu, 3 Nov 2016 20:46:09 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 08302B3879; Thu, 3 Nov 2016 20:46:05 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 00129B384D for ; Thu, 3 Nov 2016 20:44:28 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sBJ6bEzCIPLC for ; Thu, 3 Nov 2016 20:44:28 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-pf0-f195.google.com (mail-pf0-f195.google.com [209.85.192.195]) by theia.denx.de (Postfix) with ESMTPS id 3E9EEB384F for ; Thu, 3 Nov 2016 20:44:20 +0100 (CET) Received: by mail-pf0-f195.google.com with SMTP id a136so5684693pfa.0 for ; Thu, 03 Nov 2016 12:44:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=CBffieD1LTorRb+SHs98/brXu2ThTI2NQ4QOyB8fsKQ=; b=cRyQzA4V573bHzFqXuaowFC16FKRfv+uEvGNsDHumRaAG+K26Xeb8qzuk9Ztbuh1r6 VBQ7mtyzvUGLpLpwx54x3x4XTgo6je3ZS7PJu9/FikLal381YpOeTeHGs3yFrrHWT3V4 rugBrSp9DWdFHPLuAmqtqqJk6CSSCle7uLxDA0eVN9+qSJzusjxm3hqEljBIYUFG9k5R LalJ7nkgz1iCWCygTZp5hhKO3a0SKzxbe+NVibhaDdIDPZ/lYSfzA8u/fdy5YRW+Tib5 stbNBzKlx22FxvhnHKcuZm17T2wyarfYMLRZx+TtCUNp0t6/sHDLr8FcE2rCQogLJnhL Ms0Q== X-Gm-Message-State: ABUngveadOvfdGsZEFrdrvkuWU5VqTvkmEMofhbRsii+yCiCsgiCkw74iASW8JZ2iJKotA== X-Received: by 10.99.124.20 with SMTP id x20mr16084971pgc.60.1478202259353; Thu, 03 Nov 2016 12:44:19 -0700 (PDT) Received: from localhost.localdomain ([115.97.182.217]) by smtp.gmail.com with ESMTPSA id n7sm14597948pfn.62.2016.11.03.12.44.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 03 Nov 2016 12:44:18 -0700 (PDT) From: Jagan Teki To: Stefano Babic Date: Fri, 4 Nov 2016 01:13:34 +0530 Message-Id: <1478202214-3103-4-git-send-email-jagan@openedev.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1478202214-3103-1-git-send-email-jagan@openedev.com> References: <1478202214-3103-1-git-send-email-jagan@openedev.com> Cc: Joe Hershberger , u-boot@lists.denx.de, Matteo Lisi Subject: [U-Boot] [PATCH 4/4] net: fec: Zap local mac variable X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" From: Jagan Teki Call dev->enetaddr or pdata->enetaddr directly in eth_ops instead of local mac variable. Cc: Stefano Babic Cc: Matteo Lisi Cc: Michael Trimarchi Cc: Joe Hershberger Signed-off-by: Jagan Teki Acked-by: Joe Hershberger --- drivers/net/fec_mxc.c | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c index 746faed..13daae1 100644 --- a/drivers/net/fec_mxc.c +++ b/drivers/net/fec_mxc.c @@ -934,9 +934,8 @@ struct mii_dev *fec_get_miibus(uint32_t base_addr, int dev_id) static int fec_recv(struct eth_device *dev) { struct fec_priv *fec = (struct fec_priv *)dev->priv; - uchar *mac = dev->enetaddr; - return _fec_recv(fec, mac); + return _fec_recv(fec, dev->enetaddr); } static int fec_send(struct eth_device *dev, void *packet, int length) @@ -956,17 +955,15 @@ static void fec_halt(struct eth_device *dev) static int fec_set_hwaddr(struct eth_device *dev) { struct fec_priv *fec = (struct fec_priv *)dev->priv; - uchar *mac = dev->enetaddr; - return _fec_set_hwaddr(fec, mac); + return _fec_set_hwaddr(fec, dev->enetaddr); } static int fec_init(struct eth_device *dev, bd_t *bd) { struct fec_priv *fec = (struct fec_priv *)dev->priv; - uchar *mac = dev->enetaddr; - return _fec_init(fec, mac); + return _fec_init(fec, dev->enetaddr); } static int fec_get_hwaddr(int dev_id, unsigned char *mac) @@ -1142,9 +1139,8 @@ static int fec_set_hwaddr(struct udevice *dev) { struct fec_priv *fec = dev_get_priv(dev); struct eth_pdata *pdata = dev_get_platdata(dev); - uchar *mac = pdata->enetaddr; - return _fec_set_hwaddr(fec, mac); + return _fec_set_hwaddr(fec, pdata->enetaddr); } static void fec_halt(struct udevice *dev) @@ -1158,9 +1154,8 @@ static int fec_recv(struct udevice *dev, int flags, uchar **packetp) { struct fec_priv *fec = dev_get_priv(dev); struct eth_pdata *pdata = dev_get_platdata(dev); - uchar *mac = pdata->enetaddr; - return _fec_recv(fec, mac); + return _fec_recv(fec, pdata->enetaddr); } static int fec_send(struct udevice *dev, void *packet, int length) @@ -1174,9 +1169,8 @@ static int fec_init(struct udevice *dev) { struct fec_priv *fec = dev_get_priv(dev); struct eth_pdata *pdata = dev_get_platdata(dev); - uchar *mac = pdata->enetaddr; - return _fec_init(fec, mac); + return _fec_init(fec, pdata->enetaddr); } static const struct eth_ops fecmxc_ops = {