| Message ID | 1477663067-20911-2-git-send-email-jagan@openedev.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Stefano Babic |
| Headers | show |
Hi Jagan, On 28/10/2016 15:57, Jagan Teki wrote: > From: Jagan Teki <jagan@amarulasolutions.com> > > Added kconfig entry for CONFIG_VIDEO_IPV3 driver. > > Cc: Anatolij Gustschin <agust@denx.de> > Cc: Stefano Babic <sbabic@denx.de> > Cc: Matteo Lisi <matteo.lisi@engicam.com> > Cc: Michael Trimarchi <michael@amarulasolutions.com> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > drivers/video/Kconfig | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig > index 577e6d7..134f1c8 100644 > --- a/drivers/video/Kconfig > +++ b/drivers/video/Kconfig > @@ -443,6 +443,14 @@ config VIDEO > model. Video drivers typically provide a colour text console and > cursor. > > +config VIDEO_IPUV3 > + bool "i.MX IPUv3 Core video support" > + depends on MX6 > + default y if VIDEO > + help > + This enables framebuffer driver for i.MX processors working > + on the IPUv3(Image Processing Unit) internal graphic processor. > + > config CFB_CONSOLE > bool "Enable colour frame buffer console" > depends on VIDEO > I have difficulties with your patches. They have updated and moved configuration to Kconfig, but they do not care of the existing boards. This series breaks a lot of boards except yours - I cannot merge it. The same thing happens to the series I have already merged (but not pushed to the server) with "Use CONFIG_DM_ETH support". I have merged it and pushed to u-boot-imx, -next, so you can easier see what happens. Both series break existing board and I cannot take them, and even if they are improving i.MX code with new features. Can you take a look at fix them in the order: - first the FEC series ==> see -next branch - then the IPU (this series). Thanks, Stefano
Hi Stefano, On Tue, Nov 29, 2016 at 11:22 PM, Stefano Babic <sbabic@denx.de> wrote: > Hi Jagan, > > On 28/10/2016 15:57, Jagan Teki wrote: >> From: Jagan Teki <jagan@amarulasolutions.com> >> >> Added kconfig entry for CONFIG_VIDEO_IPV3 driver. >> >> Cc: Anatolij Gustschin <agust@denx.de> >> Cc: Stefano Babic <sbabic@denx.de> >> Cc: Matteo Lisi <matteo.lisi@engicam.com> >> Cc: Michael Trimarchi <michael@amarulasolutions.com> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> >> --- >> drivers/video/Kconfig | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig >> index 577e6d7..134f1c8 100644 >> --- a/drivers/video/Kconfig >> +++ b/drivers/video/Kconfig >> @@ -443,6 +443,14 @@ config VIDEO >> model. Video drivers typically provide a colour text console and >> cursor. >> >> +config VIDEO_IPUV3 >> + bool "i.MX IPUv3 Core video support" >> + depends on MX6 >> + default y if VIDEO >> + help >> + This enables framebuffer driver for i.MX processors working >> + on the IPUv3(Image Processing Unit) internal graphic processor. >> + >> config CFB_CONSOLE >> bool "Enable colour frame buffer console" >> depends on VIDEO >> > > I have difficulties with your patches. They have updated and moved > configuration to Kconfig, but they do not care of the existing boards. > > This series breaks a lot of boards except yours - I cannot merge it. > > The same thing happens to the series I have already merged (but not > pushed to the server) with "Use CONFIG_DM_ETH support". I have merged it > and pushed to u-boot-imx, -next, so you can easier see what happens. > Both series break existing board and I cannot take them, and even if > they are improving i.MX code with new features. > > Can you take a look at fix them in the order: > > - first the FEC series ==> see -next branch Found the issue and made a changes according to previous version patches which eventually works on all targets. > - then the IPU (this series). Fixed and will send the And also I've one more series with engicam boards [1], shall I send all these 3 series into one on top of u-boot-imx/master? [1] [PATCH v3 00/11] imx6: Add Engicam GEAM6UL/i.CoreM6 RQS board support thanks!
Hi Jagan, On 02/12/2016 14:57, Jagan Teki wrote: > Hi Stefano, > > On Tue, Nov 29, 2016 at 11:22 PM, Stefano Babic <sbabic@denx.de> wrote: >> Hi Jagan, >> >> On 28/10/2016 15:57, Jagan Teki wrote: >>> From: Jagan Teki <jagan@amarulasolutions.com> >>> >>> Added kconfig entry for CONFIG_VIDEO_IPV3 driver. >>> >>> Cc: Anatolij Gustschin <agust@denx.de> >>> Cc: Stefano Babic <sbabic@denx.de> >>> Cc: Matteo Lisi <matteo.lisi@engicam.com> >>> Cc: Michael Trimarchi <michael@amarulasolutions.com> >>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> >>> --- >>> drivers/video/Kconfig | 8 ++++++++ >>> 1 file changed, 8 insertions(+) >>> >>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig >>> index 577e6d7..134f1c8 100644 >>> --- a/drivers/video/Kconfig >>> +++ b/drivers/video/Kconfig >>> @@ -443,6 +443,14 @@ config VIDEO >>> model. Video drivers typically provide a colour text console and >>> cursor. >>> >>> +config VIDEO_IPUV3 >>> + bool "i.MX IPUv3 Core video support" >>> + depends on MX6 >>> + default y if VIDEO >>> + help >>> + This enables framebuffer driver for i.MX processors working >>> + on the IPUv3(Image Processing Unit) internal graphic processor. >>> + >>> config CFB_CONSOLE >>> bool "Enable colour frame buffer console" >>> depends on VIDEO >>> >> >> I have difficulties with your patches. They have updated and moved >> configuration to Kconfig, but they do not care of the existing boards. >> >> This series breaks a lot of boards except yours - I cannot merge it. >> >> The same thing happens to the series I have already merged (but not >> pushed to the server) with "Use CONFIG_DM_ETH support". I have merged it >> and pushed to u-boot-imx, -next, so you can easier see what happens. >> Both series break existing board and I cannot take them, and even if >> they are improving i.MX code with new features. >> >> Can you take a look at fix them in the order: >> >> - first the FEC series ==> see -next branch > > Found the issue and made a changes according to previous version > patches which eventually works on all targets. > ok - thanks for reworking this. >> - then the IPU (this series). > > Fixed and will send the > > And also I've one more series with engicam boards [1], shall I send > all these 3 series into one on top of u-boot-imx/master? No. I will prefer we distinguish the series, because they touch different topics. And it is easier to integrate them - if there are still some issues in the last series, this could block the whole mereg. We go on as planned: you send the updated two series fixing the issues I reported. If you kn ow that 3 series is already broken, feel free to send a new version - but I will check it only after having merged the first two series. Best regards, Stefano Babic > > [1] [PATCH v3 00/11] imx6: Add Engicam GEAM6UL/i.CoreM6 RQS board support > > thanks! >
Hi Stefano, On Mon, Dec 5, 2016 at 1:01 PM, Stefano Babic <sbabic@denx.de> wrote: > Hi Jagan, > > On 02/12/2016 14:57, Jagan Teki wrote: >> Hi Stefano, >> >> On Tue, Nov 29, 2016 at 11:22 PM, Stefano Babic <sbabic@denx.de> wrote: >>> Hi Jagan, >>> >>> On 28/10/2016 15:57, Jagan Teki wrote: >>>> From: Jagan Teki <jagan@amarulasolutions.com> >>>> >>>> Added kconfig entry for CONFIG_VIDEO_IPV3 driver. >>>> >>>> Cc: Anatolij Gustschin <agust@denx.de> >>>> Cc: Stefano Babic <sbabic@denx.de> >>>> Cc: Matteo Lisi <matteo.lisi@engicam.com> >>>> Cc: Michael Trimarchi <michael@amarulasolutions.com> >>>> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> >>>> --- >>>> drivers/video/Kconfig | 8 ++++++++ >>>> 1 file changed, 8 insertions(+) >>>> >>>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig >>>> index 577e6d7..134f1c8 100644 >>>> --- a/drivers/video/Kconfig >>>> +++ b/drivers/video/Kconfig >>>> @@ -443,6 +443,14 @@ config VIDEO >>>> model. Video drivers typically provide a colour text console and >>>> cursor. >>>> >>>> +config VIDEO_IPUV3 >>>> + bool "i.MX IPUv3 Core video support" >>>> + depends on MX6 >>>> + default y if VIDEO >>>> + help >>>> + This enables framebuffer driver for i.MX processors working >>>> + on the IPUv3(Image Processing Unit) internal graphic processor. >>>> + >>>> config CFB_CONSOLE >>>> bool "Enable colour frame buffer console" >>>> depends on VIDEO >>>> >>> >>> I have difficulties with your patches. They have updated and moved >>> configuration to Kconfig, but they do not care of the existing boards. >>> >>> This series breaks a lot of boards except yours - I cannot merge it. >>> >>> The same thing happens to the series I have already merged (but not >>> pushed to the server) with "Use CONFIG_DM_ETH support". I have merged it >>> and pushed to u-boot-imx, -next, so you can easier see what happens. >>> Both series break existing board and I cannot take them, and even if >>> they are improving i.MX code with new features. >>> >>> Can you take a look at fix them in the order: >>> >>> - first the FEC series ==> see -next branch >> >> Found the issue and made a changes according to previous version >> patches which eventually works on all targets. >> > > ok - thanks for reworking this. > > >>> - then the IPU (this series). >> >> Fixed and will send the >> >> And also I've one more series with engicam boards [1], shall I send >> all these 3 series into one on top of u-boot-imx/master? > > No. I will prefer we distinguish the series, because they touch > different topics. And it is easier to integrate them - if there are > still some issues in the last series, this could block the whole mereg. > > We go on as planned: you send the updated two series fixing the issues I > reported. If you kn ow that 3 series is already broken, feel free to > send a new version - but I will check it only after having merged the > first two series. OK, I sent both the series at v3. buildman look fine now, please find the same. thanks!
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig index 577e6d7..134f1c8 100644 --- a/drivers/video/Kconfig +++ b/drivers/video/Kconfig @@ -443,6 +443,14 @@ config VIDEO model. Video drivers typically provide a colour text console and cursor. +config VIDEO_IPUV3 + bool "i.MX IPUv3 Core video support" + depends on MX6 + default y if VIDEO + help + This enables framebuffer driver for i.MX processors working + on the IPUv3(Image Processing Unit) internal graphic processor. + config CFB_CONSOLE bool "Enable colour frame buffer console" depends on VIDEO