| Message ID | 1476359817-20989-1-git-send-email-j-keerthy@ti.com |
|---|---|
| State | Rejected |
| Delegated to: | Simon Glass |
| Headers | show |
Hi Keerthy, On 13 October 2016 at 05:56, Keerthy <j-keerthy@ti.com> wrote: > Accommodate fdt_subnode_offset signature change. > > Signed-off-by: Keerthy <j-keerthy@ti.com> > --- > drivers/power/pmic/lp873x.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/pmic/lp873x.c b/drivers/power/pmic/lp873x.c > index 307f96b..2af86b1 100644 > --- a/drivers/power/pmic/lp873x.c > +++ b/drivers/power/pmic/lp873x.c > @@ -51,7 +51,7 @@ static int lp873x_bind(struct udevice *dev) > int children; > int node = dev->of_offset; > > - regulators_node = fdt_subnode_offset(blob, node, "regulators"); > + regulators_node = fdt_subnode_offset(node, blob, "regulators"); I don't think the signature has changed on this one. > > if (regulators_node <= 0) { > printf("%s: %s reg subnode not found!", __func__, dev->name); > -- > 1.9.1 > Regards, Simon
On Thursday 13 October 2016 06:22 PM, Simon Glass wrote: > Hi Keerthy, > > On 13 October 2016 at 05:56, Keerthy <j-keerthy@ti.com> wrote: >> Accommodate fdt_subnode_offset signature change. >> >> Signed-off-by: Keerthy <j-keerthy@ti.com> >> --- >> drivers/power/pmic/lp873x.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/power/pmic/lp873x.c b/drivers/power/pmic/lp873x.c >> index 307f96b..2af86b1 100644 >> --- a/drivers/power/pmic/lp873x.c >> +++ b/drivers/power/pmic/lp873x.c >> @@ -51,7 +51,7 @@ static int lp873x_bind(struct udevice *dev) >> int children; >> int node = dev->of_offset; >> >> - regulators_node = fdt_subnode_offset(blob, node, "regulators"); >> + regulators_node = fdt_subnode_offset(node, blob, "regulators"); > > I don't think the signature has changed on this one. Ouch! I went through your patch again. Oversight. This is not needed. Palmas patch is good enough. Thanks, Keerthy > >> >> if (regulators_node <= 0) { >> printf("%s: %s reg subnode not found!", __func__, dev->name); >> -- >> 1.9.1 >> > > Regards, > Simon >
diff --git a/drivers/power/pmic/lp873x.c b/drivers/power/pmic/lp873x.c index 307f96b..2af86b1 100644 --- a/drivers/power/pmic/lp873x.c +++ b/drivers/power/pmic/lp873x.c @@ -51,7 +51,7 @@ static int lp873x_bind(struct udevice *dev) int children; int node = dev->of_offset; - regulators_node = fdt_subnode_offset(blob, node, "regulators"); + regulators_node = fdt_subnode_offset(node, blob, "regulators"); if (regulators_node <= 0) { printf("%s: %s reg subnode not found!", __func__, dev->name);
Accommodate fdt_subnode_offset signature change. Signed-off-by: Keerthy <j-keerthy@ti.com> --- drivers/power/pmic/lp873x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)