diff mbox

[U-Boot,RESEND,V2,5/6] gpio: rk: remove gpio_xlate routine

Message ID 1461166659-28276-6-git-send-email-eric@nelint.com
State Accepted
Delegated to: Simon Glass
Headers show

Commit Message

Eric Nelson April 20, 2016, 3:37 p.m. UTC 
With the addition of GPIO_ACTIVE_LOW parsing in gpio-uclass,
the Rockchip gpio driver doesn't need a custom xlate routine.

Signed-off-by: Eric Nelson <eric@nelint.com>
Acked-by: Simon Glass <sjg@chromium.org>
---
 V2 removes the include of <dt-bindings/gpio/gpio.h>
 drivers/gpio/rk_gpio.c | 11 -----------
 1 file changed, 11 deletions(-)

Comments

Simon Glass May 7, 2016, 7:03 p.m. UTC | #1 
On 20 April 2016 at 09:37, Eric Nelson <eric@nelint.com> wrote:
> With the addition of GPIO_ACTIVE_LOW parsing in gpio-uclass,
> the Rockchip gpio driver doesn't need a custom xlate routine.
>
> Signed-off-by: Eric Nelson <eric@nelint.com>
> Acked-by: Simon Glass <sjg@chromium.org>
> ---
>  V2 removes the include of <dt-bindings/gpio/gpio.h>
>  drivers/gpio/rk_gpio.c | 11 -----------
>  1 file changed, 11 deletions(-)

Applied to u-boot-dm, thanks!
diff mbox

Patch

diff --git a/drivers/gpio/rk_gpio.c b/drivers/gpio/rk_gpio.c
index 40e87bd..fefe3ca 100644
--- a/drivers/gpio/rk_gpio.c
+++ b/drivers/gpio/rk_gpio.c
@@ -16,7 +16,6 @@ 
 #include <asm/io.h>
 #include <asm/arch/clock.h>
 #include <dm/pinctrl.h>
-#include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/clock/rk3288-cru.h>
 
 enum {
@@ -98,15 +97,6 @@  static int rockchip_gpio_get_function(struct udevice *dev, unsigned offset)
 #endif
 }
 
-static int rockchip_gpio_xlate(struct udevice *dev, struct gpio_desc *desc,
-			    struct fdtdec_phandle_args *args)
-{
-	desc->offset = args->args[0];
-	desc->flags = args->args[1] & GPIO_ACTIVE_LOW ? GPIOD_ACTIVE_LOW : 0;
-
-	return 0;
-}
-
 static int rockchip_gpio_probe(struct udevice *dev)
 {
 	struct gpio_dev_priv *uc_priv = dev_get_uclass_priv(dev);
@@ -135,7 +125,6 @@  static const struct dm_gpio_ops gpio_rockchip_ops = {
 	.get_value		= rockchip_gpio_get_value,
 	.set_value		= rockchip_gpio_set_value,
 	.get_function		= rockchip_gpio_get_function,
-	.xlate			= rockchip_gpio_xlate,
 };
 
 static const struct udevice_id rockchip_gpio_ids[] = {