Message ID | 1460879338-7671-4-git-send-email-b.galvani@gmail.com |
---|---|
State | Superseded |
Delegated to: | Tom Rini |
Headers | show |
> Am 17.04.2016 um 09:48 schrieb Beniamino Galvani <b.galvani@gmail.com>: > > Implement calls to the secure monitor to reset the board and read the > MAC address from e-fuse. > > Signed-off-by: Beniamino Galvani <b.galvani@gmail.com> > --- > arch/arm/include/asm/arch-meson/sm.h | 13 +++++++ > arch/arm/mach-meson/Makefile | 2 +- > arch/arm/mach-meson/board.c | 3 +- > arch/arm/mach-meson/sm.c | 71 ++++++++++++++++++++++++++++++++++ > board/hardkernel/odroid-c2/odroid-c2.c | 16 ++++++++ > 5 files changed, 103 insertions(+), 2 deletions(-) > create mode 100644 arch/arm/include/asm/arch-meson/sm.h > create mode 100644 arch/arm/mach-meson/sm.c > > diff --git a/arch/arm/include/asm/arch-meson/sm.h b/arch/arm/include/asm/arch-meson/sm.h > new file mode 100644 > index 0000000..87134c6 > --- /dev/null > +++ b/arch/arm/include/asm/arch-meson/sm.h > @@ -0,0 +1,13 @@ > +/* > + * (C) Copyright 2016 - Beniamino Galvani <b.galvani@gmail.com> > + * > + * SPDX-License-Identifier: GPL-2.0+ > + */ > + > +#ifndef __MESON_SM_H__ > +#define __MESON_SM_H__ > + > +void meson_sm_reboot(void); > +ssize_t meson_sm_read_efuse(uintptr_t offset, void *buffer, size_t size); > + > +#endif /* __MESON_SM_H__ */ > diff --git a/arch/arm/mach-meson/Makefile b/arch/arm/mach-meson/Makefile > index 44e3d63..bf49b8b 100644 > --- a/arch/arm/mach-meson/Makefile > +++ b/arch/arm/mach-meson/Makefile > @@ -4,4 +4,4 @@ > # SPDX-License-Identifier: GPL-2.0+ > # > > -obj-y += board.o > +obj-y += board.o sm.o > diff --git a/arch/arm/mach-meson/board.c b/arch/arm/mach-meson/board.c > index 05f4c79..6272f2f 100644 > --- a/arch/arm/mach-meson/board.c > +++ b/arch/arm/mach-meson/board.c > @@ -8,6 +8,7 @@ > #include <libfdt.h> > #include <linux/err.h> > #include <asm/arch/gxbb.h> > +#include <asm/arch/sm.h> > #include <asm/armv8/mmu.h> > #include <asm/unaligned.h> > > @@ -42,7 +43,7 @@ void dram_init_banksize(void) > > void reset_cpu(ulong addr) > { > - /* Not implemented yet */ > + meson_sm_reboot(); Shouldn't reboot be available as psci call? We could then have a generic reset function for systems with working psci in atf. Alex
On 04/17/2016 09:48 AM, Beniamino Galvani wrote: > Implement calls to the secure monitor to reset the board and read the > MAC address from e-fuse. > > Signed-off-by: Beniamino Galvani <b.galvani@gmail.com> [...] > diff --git a/arch/arm/mach-meson/sm.c b/arch/arm/mach-meson/sm.c > new file mode 100644 > index 0000000..3065bd2 > --- /dev/null > +++ b/arch/arm/mach-meson/sm.c > @@ -0,0 +1,71 @@ > +/* > + * (C) Copyright 2016 Beniamino Galvani <b.galvani@gmail.com> > + * > + * SPDX-License-Identifier: GPL-2.0+ > + * > + * Secure monitor calls. > + */ > + > +#include <common.h> > +#include <asm/arch/gxbb.h> > + > +#define MIN(a, b) ((a) < (b) ? (a) : (b)) See include/linux/kernel.h for min macro > +#define FN_GET_SHARE_MEM_INPUT_BASE 0x82000020 > +#define FN_GET_SHARE_MEM_OUTPUT_BASE 0x82000021 > +#define FN_EFUSE_READ 0x82000030 > +#define FN_EFUSE_WRITE 0x82000031 > +#define FN_REBOOT 0x84000009 > + > +static void *shmem_input; > +static void *shmem_output; [...]
On Sun, Apr 17, 2016 at 11:48:34AM +0200, Alexander Graf wrote: > Shouldn't reboot be available as psci call? We could then have a > generic reset function for systems with working psci in atf. Yes, the 0x84000009 function ID used to reset the board seems to be actually a PSCI call, so probably a generic function could be implemented and used. I will change this in the next version. Thanks, Beniamino
On Sun, Apr 17, 2016 at 12:00:59PM +0200, Marek Vasut wrote: > > +#define MIN(a, b) ((a) < (b) ? (a) : (b)) > > See include/linux/kernel.h for min macro Ah, I missed it, thanks! Beniamino
diff --git a/arch/arm/include/asm/arch-meson/sm.h b/arch/arm/include/asm/arch-meson/sm.h new file mode 100644 index 0000000..87134c6 --- /dev/null +++ b/arch/arm/include/asm/arch-meson/sm.h @@ -0,0 +1,13 @@ +/* + * (C) Copyright 2016 - Beniamino Galvani <b.galvani@gmail.com> + * + * SPDX-License-Identifier: GPL-2.0+ + */ + +#ifndef __MESON_SM_H__ +#define __MESON_SM_H__ + +void meson_sm_reboot(void); +ssize_t meson_sm_read_efuse(uintptr_t offset, void *buffer, size_t size); + +#endif /* __MESON_SM_H__ */ diff --git a/arch/arm/mach-meson/Makefile b/arch/arm/mach-meson/Makefile index 44e3d63..bf49b8b 100644 --- a/arch/arm/mach-meson/Makefile +++ b/arch/arm/mach-meson/Makefile @@ -4,4 +4,4 @@ # SPDX-License-Identifier: GPL-2.0+ # -obj-y += board.o +obj-y += board.o sm.o diff --git a/arch/arm/mach-meson/board.c b/arch/arm/mach-meson/board.c index 05f4c79..6272f2f 100644 --- a/arch/arm/mach-meson/board.c +++ b/arch/arm/mach-meson/board.c @@ -8,6 +8,7 @@ #include <libfdt.h> #include <linux/err.h> #include <asm/arch/gxbb.h> +#include <asm/arch/sm.h> #include <asm/armv8/mmu.h> #include <asm/unaligned.h> @@ -42,7 +43,7 @@ void dram_init_banksize(void) void reset_cpu(ulong addr) { - /* Not implemented yet */ + meson_sm_reboot(); } static struct mm_region gxbb_mem_map[] = { diff --git a/arch/arm/mach-meson/sm.c b/arch/arm/mach-meson/sm.c new file mode 100644 index 0000000..3065bd2 --- /dev/null +++ b/arch/arm/mach-meson/sm.c @@ -0,0 +1,71 @@ +/* + * (C) Copyright 2016 Beniamino Galvani <b.galvani@gmail.com> + * + * SPDX-License-Identifier: GPL-2.0+ + * + * Secure monitor calls. + */ + +#include <common.h> +#include <asm/arch/gxbb.h> + +#define MIN(a, b) ((a) < (b) ? (a) : (b)) + +#define FN_GET_SHARE_MEM_INPUT_BASE 0x82000020 +#define FN_GET_SHARE_MEM_OUTPUT_BASE 0x82000021 +#define FN_EFUSE_READ 0x82000030 +#define FN_EFUSE_WRITE 0x82000031 +#define FN_REBOOT 0x84000009 + +static void *shmem_input; +static void *shmem_output; + +static void meson_init_shmem(void) +{ + struct pt_regs regs; + + if (shmem_input && shmem_output) + return; + + regs.regs[0] = FN_GET_SHARE_MEM_INPUT_BASE; + smc_call(®s); + shmem_input = (void *)regs.regs[0]; + + regs.regs[0] = FN_GET_SHARE_MEM_OUTPUT_BASE; + smc_call(®s); + shmem_output = (void *)regs.regs[0]; + + debug("Secure Monitor shmem: 0x%p 0x%p\n", shmem_input, shmem_output); +} + +void meson_sm_reboot(void) +{ + struct pt_regs regs; + + regs.regs[0] = FN_REBOOT; + regs.regs[1] = 1; /* normal reboot */ + regs.regs[2] = 0; + regs.regs[3] = 0; + + smc_call(®s); +} + +ssize_t meson_sm_read_efuse(uintptr_t offset, void *buffer, size_t size) +{ + struct pt_regs regs; + + meson_init_shmem(); + + regs.regs[0] = FN_EFUSE_READ; + regs.regs[1] = offset; + regs.regs[2] = size; + + smc_call(®s); + + if (regs.regs[0] == 0) + return -1; + + memcpy(buffer, shmem_output, MIN(size, regs.regs[0])); + + return regs.regs[0]; +} diff --git a/board/hardkernel/odroid-c2/odroid-c2.c b/board/hardkernel/odroid-c2/odroid-c2.c index c258d4f..bd72100 100644 --- a/board/hardkernel/odroid-c2/odroid-c2.c +++ b/board/hardkernel/odroid-c2/odroid-c2.c @@ -7,9 +7,15 @@ #include <common.h> #include <asm/io.h> #include <asm/arch/gxbb.h> +#include <asm/arch/sm.h> #include <dm/platdata.h> #include <phy.h> +#define EFUSE_SN_OFFSET 20 +#define EFUSE_SN_SIZE 16 +#define EFUSE_MAC_OFFSET 52 +#define EFUSE_MAC_SIZE 6 + int board_init(void) { return 0; @@ -27,6 +33,9 @@ U_BOOT_DEVICE(meson_eth) = { int misc_init_r(void) { + u8 mac_addr[EFUSE_MAC_SIZE]; + ssize_t len; + /* Select Ethernet function */ setbits_le32(GXBB_PINMUX(6), 0x3fff); @@ -47,5 +56,12 @@ int misc_init_r(void) mdelay(10); setbits_le32(GXBB_GPIO_OUT(3), BIT(14)); + if (!eth_getenv_enetaddr("ethaddr", mac_addr)) { + len = meson_sm_read_efuse(EFUSE_MAC_OFFSET, + mac_addr, EFUSE_MAC_SIZE); + if (len == EFUSE_MAC_SIZE && is_valid_ethaddr(mac_addr)) + eth_setenv_enetaddr("ethaddr", mac_addr); + } + return 0; }
Implement calls to the secure monitor to reset the board and read the MAC address from e-fuse. Signed-off-by: Beniamino Galvani <b.galvani@gmail.com> --- arch/arm/include/asm/arch-meson/sm.h | 13 +++++++ arch/arm/mach-meson/Makefile | 2 +- arch/arm/mach-meson/board.c | 3 +- arch/arm/mach-meson/sm.c | 71 ++++++++++++++++++++++++++++++++++ board/hardkernel/odroid-c2/odroid-c2.c | 16 ++++++++ 5 files changed, 103 insertions(+), 2 deletions(-) create mode 100644 arch/arm/include/asm/arch-meson/sm.h create mode 100644 arch/arm/mach-meson/sm.c