| Message ID | 1459667897-2824-6-git-send-email-b.galvani@gmail.com |
|---|---|
| State | Changes Requested |
| Delegated to: | Tom Rini |
| Headers | show |
On Sun, Apr 03, 2016 at 09:18:13AM +0200, Beniamino Galvani wrote: > Enable serial support in the ODROID-C2 configuration. > > Signed-off-by: Beniamino Galvani <b.galvani@gmail.com> Reviewed-by: Tom Rini <trini@konsulko.com> But this too should be folded in with the initial support. In fact, I would go so far as to say that in general, the initial platform patch should be enough to boot the platform. So UART, DDR (and anything that all requires), board itself. If we're not adding a new eth driver, enabling eth is fine too. If that means adding some driver fixes first, make them the first patches in the series. Thanks!
On Sun, Apr 03, 2016 at 12:09:44PM -0400, Tom Rini wrote: > But this too should be folded in with the initial support. In fact, I > would go so far as to say that in general, the initial platform patch > should be enough to boot the platform. So UART, DDR (and anything that > all requires), board itself. If we're not adding a new eth driver, > enabling eth is fine too. If that means adding some driver fixes first, > make them the first patches in the series. Thanks! I'll do, thanks. Beniamino
diff --git a/configs/odroid-c2_defconfig b/configs/odroid-c2_defconfig index 765076a..069f02d 100644 --- a/configs/odroid-c2_defconfig +++ b/configs/odroid-c2_defconfig @@ -11,3 +11,10 @@ CONFIG_DEFAULT_DEVICE_TREE="meson-gxbb-odroidc2" # CONFIG_CMD_SOURCE is not set # CONFIG_CMD_SETEXPR is not set CONFIG_OF_CONTROL=y +CONFIG_DEBUG_UART=y +CONFIG_DEBUG_UART_MESON=y +CONFIG_DEBUG_UART_BASE=0xc81004c0 +CONFIG_DEBUG_UART_CLOCK=24000000 +CONFIG_DEBUG_UART_ANNOUNCE=y +CONFIG_DEBUG_UART_SKIP_INIT=y +CONFIG_MESON_SERIAL=y
Enable serial support in the ODROID-C2 configuration. Signed-off-by: Beniamino Galvani <b.galvani@gmail.com> --- configs/odroid-c2_defconfig | 7 +++++++ 1 file changed, 7 insertions(+)