| Message ID | 1453935761-24319-1-git-send-email-srae@broadcom.com |
|---|---|
| State | Accepted |
| Commit | a18c2706f15ac3460cb902d37705f90ffae84ce6 |
| Delegated to: | Marek Vasut |
| Headers | show |
On Thursday, January 28, 2016 at 12:02:41 AM, Steve Rae wrote: > Fix the formatting in error messages, and demote one error message > to a warning, as it is only informational. > > Signed-off-by: Steve Rae <srae@broadcom.com> I'd leave this to Lukasz, if he doesn't respond, ping me in a week or so. Best regards, Marek Vasut
ping -- Thanks! On 16-01-27 03:42 PM, Marek Vasut wrote: > On Thursday, January 28, 2016 at 12:02:41 AM, Steve Rae wrote: >> Fix the formatting in error messages, and demote one error message >> to a warning, as it is only informational. >> >> Signed-off-by: Steve Rae <srae@broadcom.com> > > I'd leave this to Lukasz, if he doesn't respond, ping me in a week or so. > > Best regards, > Marek Vasut >
On 02/16/2016 02:20 AM, Steve Rae wrote: > ping -- Thanks! > > On 16-01-27 03:42 PM, Marek Vasut wrote: >> On Thursday, January 28, 2016 at 12:02:41 AM, Steve Rae wrote: >>> Fix the formatting in error messages, and demote one error message >>> to a warning, as it is only informational. >>> >>> Signed-off-by: Steve Rae <srae@broadcom.com> >> >> I'd leave this to Lukasz, if he doesn't respond, ping me in a week or so. >> >> Best regards, >> Marek Vasut >> Applied to u-boot-usb/master, thanks!
Hi Marek, > On 02/16/2016 02:20 AM, Steve Rae wrote: > > ping -- Thanks! > > > > On 16-01-27 03:42 PM, Marek Vasut wrote: > >> On Thursday, January 28, 2016 at 12:02:41 AM, Steve Rae wrote: > >>> Fix the formatting in error messages, and demote one error message > >>> to a warning, as it is only informational. > >>> > >>> Signed-off-by: Steve Rae <srae@broadcom.com> > >> > >> I'd leave this to Lukasz, if he doesn't respond, ping me in a week > >> or so. > >> > >> Best regards, > >> Marek Vasut > >> > > Applied to u-boot-usb/master, thanks! > +1
diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c index 87e54eb..a54b4ee 100644 --- a/drivers/usb/gadget/f_fastboot.c +++ b/drivers/usb/gadget/f_fastboot.c @@ -382,7 +382,7 @@ static void cb_getvar(struct usb_ep *ep, struct usb_request *req) strsep(&cmd, ":"); if (!cmd) { - error("missing variable\n"); + error("missing variable"); fastboot_tx_write_str("FAILmissing var"); return; } @@ -413,7 +413,7 @@ static void cb_getvar(struct usb_ep *ep, struct usb_request *req) else strcpy(response, "FAILValue not set"); } else { - error("unknown variable: %s\n", cmd); + printf("WARNING: unknown variable: %s\n", cmd); strcpy(response, "FAILVariable not implemented"); } fastboot_tx_write_str(response); @@ -561,7 +561,7 @@ static void cb_flash(struct usb_ep *ep, struct usb_request *req) strsep(&cmd, ":"); if (!cmd) { - error("missing partition name\n"); + error("missing partition name"); fastboot_tx_write_str("FAILmissing partition name"); return; } @@ -683,7 +683,7 @@ static void rx_handler_command(struct usb_ep *ep, struct usb_request *req) } if (!func_cb) { - error("unknown command: %s\n", cmdbuf); + error("unknown command: %s", cmdbuf); fastboot_tx_write_str("FAILunknown command"); } else { if (req->actual < req->length) { @@ -691,7 +691,7 @@ static void rx_handler_command(struct usb_ep *ep, struct usb_request *req) buf[req->actual] = 0; func_cb(ep, req); } else { - error("buffer overflow\n"); + error("buffer overflow"); fastboot_tx_write_str("FAILbuffer overflow"); } }
Fix the formatting in error messages, and demote one error message to a warning, as it is only informational. Signed-off-by: Steve Rae <srae@broadcom.com> --- drivers/usb/gadget/f_fastboot.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)