From patchwork Thu Dec 10 21:27:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Troy Kisky X-Patchwork-Id: 555333 X-Patchwork-Delegate: jagannadh.teki@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id DDF40140297 for ; Fri, 11 Dec 2015 08:27:59 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=boundarydevices-com.20150623.gappssmtp.com header.i=@boundarydevices-com.20150623.gappssmtp.com header.b=vxiMHqOD; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 2D30C4B6DF; Thu, 10 Dec 2015 22:27:58 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XkpAYAPaFz4a; Thu, 10 Dec 2015 22:27:57 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 6118C4B6D1; Thu, 10 Dec 2015 22:27:57 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id B78A04B6D1 for ; Thu, 10 Dec 2015 22:27:54 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3Tb1hIpW-80n for ; Thu, 10 Dec 2015 22:27:54 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-pf0-f180.google.com (mail-pf0-f180.google.com [209.85.192.180]) by theia.denx.de (Postfix) with ESMTPS id 430F04B6CD for ; Thu, 10 Dec 2015 22:27:50 +0100 (CET) Received: by pfv76 with SMTP id 76so1323918pfv.2 for ; Thu, 10 Dec 2015 13:27:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=boundarydevices-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=h+aDXPrb+lNgZU9oUzzsHoimyWzHutD+Ho1wnh2QTIk=; b=vxiMHqOD1ZSjAboRmYCwE2nuQ4kOETY6+NCYCjoBpgcGJCHkjuw27SoxHL4EEW9qc4 qWNriX6pjX3SCOW3w58GzYJ2N0J0gOXCVx4c5GBuAo6h84jpESEyJLzo4i5zHiDdGeOM u9X2ZU2X4/f0jTQEgLKliv6N1fRhsE/zo5CcbnVomJMi/t7S5IzjUDthiw0lSxh49O5L AgcOXDFU2dIZ/BQVSZBTUHQUkOpy8JALVihV72gPuiqqkL9QOjmae6xCo7q/Sxr/ixMK 02ptV1H4h4+GJd1z2IT3XDn9XUfIme73324rdbQ4Q+eme/q+ybmNGzCxNgwC4rT38zjQ x6Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=h+aDXPrb+lNgZU9oUzzsHoimyWzHutD+Ho1wnh2QTIk=; b=m4I5vh4DjRFjWRCfAQMsRiMQCMgv+7cs39ufmLRVossvcQkW34rJXHLVJYBiaArJD5 nGxcq2tVHUSyLS9Wj+jdqtUjtW5HF/NAmyW6ezCwJYR0cTNUt0I943iI9mSI1JC9Gh+T D0kMOAwN5nqRTDNplZ7oLDJRc/MKsqI1NkfZpfwDhUPvwvNEU9H4PqH2J4VCpGpLpKje Y49pPkj7LNPSD4CS1jMd2e5/gy83JwP7/yq9yVsqyFNaiFc84ASXX4XWVV0o/mOtLS5d oFip+1YpzKMpKVAK/5SojzeoVcVVUydT6TmGLA3p14YQbN0kpH5QRtOLukCQOeBvF5c+ OEwA== X-Gm-Message-State: ALoCoQnE+ZPdZ1/iKOQ2/KJOO6JYSsB/dYBYt9BsPG9i6qXhS1i09ln4X8vl4u2NW5f8To9QwvLReNbv82zBsSArBJZ/Q/81fw== X-Received: by 10.98.42.9 with SMTP id q9mr10102149pfq.142.1449782869350; Thu, 10 Dec 2015 13:27:49 -0800 (PST) Received: from localhost.localdomain (wsip-70-184-93-199.ph.ph.cox.net. [70.184.93.199]) by smtp.googlemail.com with ESMTPSA id m20sm20416002pfi.80.2015.12.10.13.27.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 10 Dec 2015 13:27:48 -0800 (PST) From: Troy Kisky To: jteki@openedev.com, sbabic@denx.de Date: Thu, 10 Dec 2015 14:27:43 -0700 Message-Id: <1449782863-15230-1-git-send-email-troy.kisky@boundarydevices.com> X-Mailer: git-send-email 2.5.0 Cc: marex@denx.de, fabio.estevam@freescale.com, u-boot@lists.denx.de Subject: [U-Boot] [PATCH V2 1/1] Revert "spi: fsl_qspi: Use GENMASK" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" If GENMASK is REALLY desired, it should be GENMASK(23,0) But since GENMASK is obviously more confusing, let's just revert. This reverts commit bad490a24212c068c5b718b9189f47ea4075d078. Reviewed-by: Fabio Estevam Signed-off-by: Troy Kisky --- v2: add sign off/ reviewed by --- drivers/spi/fsl_qspi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/fsl_qspi.c b/drivers/spi/fsl_qspi.c index ed39114..dd7048a 100644 --- a/drivers/spi/fsl_qspi.c +++ b/drivers/spi/fsl_qspi.c @@ -24,7 +24,7 @@ DECLARE_GLOBAL_DATA_PTR; #define TX_BUFFER_SIZE 0x40 #endif -#define OFFSET_BITS_MASK GENMASK(24, 0) +#define OFFSET_BITS_MASK 0x00ffffff #define FLASH_STATUS_WEL 0x02