From patchwork Thu Dec 10 21:10:27 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Troy Kisky X-Patchwork-Id: 555330 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 9A2FC1402A9 for ; Fri, 11 Dec 2015 08:10:46 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=boundarydevices-com.20150623.gappssmtp.com header.i=@boundarydevices-com.20150623.gappssmtp.com header.b=O8T9GMMG; dkim-atps=neutral Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id E30C44B6AF; Thu, 10 Dec 2015 22:10:42 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ArD8fxdqSJHU; Thu, 10 Dec 2015 22:10:42 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 34A864B699; Thu, 10 Dec 2015 22:10:42 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 294CB4B699 for ; Thu, 10 Dec 2015 22:10:39 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nni8yQprvh1y for ; Thu, 10 Dec 2015 22:10:39 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-pf0-f180.google.com (mail-pf0-f180.google.com [209.85.192.180]) by theia.denx.de (Postfix) with ESMTPS id AEF9A4B698 for ; Thu, 10 Dec 2015 22:10:35 +0100 (CET) Received: by pfbu66 with SMTP id u66so10031705pfb.3 for ; Thu, 10 Dec 2015 13:10:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=boundarydevices-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=Y1d0ivwuXSC1guVzmKh+QXttX+Zs3ENm0j+6VSNdEF4=; b=O8T9GMMGhtQPAitEHFo837GFcDSRl8waohcW/yuS6J1QWc+Y2IEtcwZktFbbFsqGV6 GlTZh9qjGmaLvA/iOXy1dvzNDoxYsbBe5KTJqdqENrETyiO4RB1ib4HHSe8yIRhx4Gn2 q/q2l3CicVSZgr8aY52WfRFLVBnE3iWN5DkVLAL/KGWyEhLvVeAbAYSOcOxKkGEbLJJY iqC0w4Arzq7eVqDwns8emlUkiXLODRuNx3+lX5waObF0cJARy0jh7Mjv5EzqSIS1pUbd OuJMJ3wXMrRh+N/lh4JcHJYFQ7n1civbzhdsi/Ir9DbqrNfvBhNEm4UYUrs7WY282YJq T+2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Y1d0ivwuXSC1guVzmKh+QXttX+Zs3ENm0j+6VSNdEF4=; b=ZRx2+G607y47V4xXNC1XAxIhjuZVodLs23hZasbYsX5eJBsaMwwx5dq6endk5jKZrW HHixbeMDFhls0SUXhvyU/Jde9y1D/RqYgwNHu+CwkhL2uh7k2JZ8NcUqPAZ0tiKtVTLz reMzwuoCd0LW0w/WJ9jqLRdD/hAtnaH6wWe5JrNlFRmfuVwZGKGxh3jer4JnAUCnj/l/ KWlgfpYm6pmCf5mmULULCJGdLltB72zGOtXeb0I7JUawuD5C2amh2uC0Zj22uotDOtuK 1hyCNTDVZnQ/MovETe7tO1uGi+jZ+02veJ0aF5jKVhIOOPA4o/oGG2F3hV7kaNpJGUtr 3tsQ== X-Gm-Message-State: ALoCoQlI54eu83GdXydVH12UUtPCY2tdzz3Qi68Y7DHLV/XI5ygOHONFZiC+vSR8qZB47KJF6B8boS/uSPXNEFhjQtwAtlrZHw== X-Received: by 10.98.16.71 with SMTP id y68mr10213071pfi.108.1449781833262; Thu, 10 Dec 2015 13:10:33 -0800 (PST) Received: from localhost.localdomain (wsip-70-184-93-199.ph.ph.cox.net. [70.184.93.199]) by smtp.googlemail.com with ESMTPSA id w1sm20394174pfa.57.2015.12.10.13.10.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 10 Dec 2015 13:10:32 -0800 (PST) From: Troy Kisky To: jteki@openedev.com, sbabic@denx.de Date: Thu, 10 Dec 2015 14:10:27 -0700 Message-Id: <1449781827-14961-1-git-send-email-troy.kisky@boundarydevices.com> X-Mailer: git-send-email 2.5.0 Cc: marex@denx.de, fabio.estevam@freescale.com, u-boot@lists.denx.de Subject: [U-Boot] [PATCH] Revert "spi: fsl_qspi: Use GENMASK" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" If GENMASK is REALLY desired, it should be GENMASK(23,0) But since GENMASK is obviously more confusing, let's just revert This reverts commit bad490a24212c068c5b718b9189f47ea4075d078. Reviewed-by: Fabio Estevam diff --git a/drivers/spi/fsl_qspi.c b/drivers/spi/fsl_qspi.c index 169835e..0a161b6 100644 --- a/drivers/spi/fsl_qspi.c +++ b/drivers/spi/fsl_qspi.c @@ -25,7 +25,7 @@ DECLARE_GLOBAL_DATA_PTR; #define TX_BUFFER_SIZE 0x40 #endif -#define OFFSET_BITS_MASK GENMASK(24, 0) +#define OFFSET_BITS_MASK 0x00ffffff #define FLASH_STATUS_BUSY 0x01 #define FLASH_STATUS_WEL 0x02