diff mbox

[U-Boot] imx: mx6: add missing return value

Message ID 1448818234-9284-1-git-send-email-jeroen@myspectrum.nl
State Awaiting Upstream
Delegated to: Stefano Babic
Headers show

Commit Message

Jeroen Hofstee Nov. 29, 2015, 5:30 p.m. UTC 
cc: Peng Fan <Peng.Fan@freescale.com>
Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
---
not tested ;)

 arch/arm/cpu/armv7/mx6/clock.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Peng Fan Nov. 30, 2015, 1:46 a.m. UTC | #1 
Hi Jeroen,
On Sun, Nov 29, 2015 at 06:30:34PM +0100, Jeroen Hofstee wrote:
>cc: Peng Fan <Peng.Fan@freescale.com>
>Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
>---
>not tested ;)
>
> arch/arm/cpu/armv7/mx6/clock.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c
>index 67e0f32..4f6fe86 100644
>--- a/arch/arm/cpu/armv7/mx6/clock.c
>+++ b/arch/arm/cpu/armv7/mx6/clock.c
>@@ -715,6 +715,8 @@ int enable_lcdif_clock(u32 base_addr)
> 	reg = readl(&imx_ccm->CCGR2);
> 	reg |= MXC_CCM_CCGR2_LCD_MASK;
> 	writel(reg, &imx_ccm->CCGR2);
>+
>+	return 0;

I CCed i.MX branch maintainer for you.

Reviewed-by: Peng Fan <Peng.Fan@freescale.com>

Regards,
Peng.

> }
> #endif
> 
>-- 
>1.9.1
>
Stefano Babic Nov. 30, 2015, 10:17 a.m. UTC | #2 
On 30/11/2015 02:46, Peng Fan wrote:
> Hi Jeroen,
> On Sun, Nov 29, 2015 at 06:30:34PM +0100, Jeroen Hofstee wrote:
>> cc: Peng Fan <Peng.Fan@freescale.com>
>> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
>> ---
>> not tested ;)
>>
>> arch/arm/cpu/armv7/mx6/clock.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c
>> index 67e0f32..4f6fe86 100644
>> --- a/arch/arm/cpu/armv7/mx6/clock.c
>> +++ b/arch/arm/cpu/armv7/mx6/clock.c
>> @@ -715,6 +715,8 @@ int enable_lcdif_clock(u32 base_addr)
>> 	reg = readl(&imx_ccm->CCGR2);
>> 	reg |= MXC_CCM_CCGR2_LCD_MASK;
>> 	writel(reg, &imx_ccm->CCGR2);
>> +
>> +	return 0;
> 
> I CCed i.MX branch maintainer for you.
> 
> Reviewed-by: Peng Fan <Peng.Fan@freescale.com>
> 

Thanks.

Reviewed-by: Stefano Babic <sbabic@denx.de>

Best regards,
Stefano Babic
Stefano Babic Dec. 7, 2015, 1:59 p.m. UTC | #3 
On 30/11/2015 02:46, Peng Fan wrote:
> Hi Jeroen,
> On Sun, Nov 29, 2015 at 06:30:34PM +0100, Jeroen Hofstee wrote:
>> cc: Peng Fan <Peng.Fan@freescale.com>
>> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
>> ---
>> not tested ;)
>>
>> arch/arm/cpu/armv7/mx6/clock.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c
>> index 67e0f32..4f6fe86 100644
>> --- a/arch/arm/cpu/armv7/mx6/clock.c
>> +++ b/arch/arm/cpu/armv7/mx6/clock.c
>> @@ -715,6 +715,8 @@ int enable_lcdif_clock(u32 base_addr)
>> 	reg = readl(&imx_ccm->CCGR2);
>> 	reg |= MXC_CCM_CCGR2_LCD_MASK;
>> 	writel(reg, &imx_ccm->CCGR2);
>> +
>> +	return 0;
> 
> I CCed i.MX branch maintainer for you.
> 
> Reviewed-by: Peng Fan <Peng.Fan@freescale.com>
> 

Applied to u-boot-imx, thanks !

Best regards,
Stefano Babic
diff mbox

Patch

diff --git a/arch/arm/cpu/armv7/mx6/clock.c b/arch/arm/cpu/armv7/mx6/clock.c
index 67e0f32..4f6fe86 100644
--- a/arch/arm/cpu/armv7/mx6/clock.c
+++ b/arch/arm/cpu/armv7/mx6/clock.c
@@ -715,6 +715,8 @@  int enable_lcdif_clock(u32 base_addr)
 	reg = readl(&imx_ccm->CCGR2);
 	reg |= MXC_CCM_CCGR2_LCD_MASK;
 	writel(reg, &imx_ccm->CCGR2);
+
+	return 0;
 }
 #endif