From patchwork Wed Mar 25 13:39:05 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 454398 X-Patchwork-Delegate: hdegoede@redhat.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 250C9140082 for ; Thu, 26 Mar 2015 00:50:27 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id DCC98A7423; Wed, 25 Mar 2015 14:50:23 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OyEL3hFI7sCN; Wed, 25 Mar 2015 14:50:23 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 2A306A7420; Wed, 25 Mar 2015 14:50:23 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 08E464B688 for ; Wed, 25 Mar 2015 14:50:21 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1DZQqgTQzKKT for ; Wed, 25 Mar 2015 14:50:20 +0100 (CET) X-Greylist: delayed 666 seconds by postgrey-1.34 at theia; Wed, 25 Mar 2015 14:50:16 CET X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from SMTP.CITRIX.COM (smtp.citrix.com [66.165.176.89]) by theia.denx.de (Postfix) with ESMTPS id 6D6624B686 for ; Wed, 25 Mar 2015 14:50:16 +0100 (CET) X-IronPort-AV: E=Sophos;i="5.11,465,1422921600"; d="scan'208";a="246549807" From: Ian Campbell To: , Ian Campbell , "Hans de Goede" Date: Wed, 25 Mar 2015 13:39:05 +0000 Message-ID: <1427290745-26578-1-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.1.4 MIME-Version: 1.0 X-DLP: MIA1 Cc: Ian Campbell Subject: [U-Boot] [PATCH] sunxi: set GMAC TX delay = 0x1 on Cubietruck. X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.15 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" Of 4 boards in our automated test system 2 do not have reliable networking with the default TX delay of 0x0. Increasing to 0x1 seems to make things reliable on all 4 boards. Some previous ad-hpoc tests with tx delay set to 0, 1, 2 and 3 on one of the problematic boards showed: 0: mw.l 0x1c20164 0x006 1 -- t/o in 4/5 tftp runs 1: mw.l 0x1c20164 0x406 1 -- t/o in 1/5 tftp runs 2: mw.l 0x1c20164 0x806 1 -- t/o in 1/5 tftp runs 3: mw.l 0x1c20164 0xc06 1 -- t/o many times in first tftp run For 0, 1 and 2 "t/o" means one or two "T" glitches in the download, but it did complete. For 3 those were basically continuous and it couldn't complete. tftp was of a 16M initrd. Signed-off-by: Ian Campbell --- NB, Unlike the normal typo I actually mean to use my citrix address here, since this was done for/at work. Actual testing was done on v2014.10 with the same direct write hack as BananaPi had in that release (but with value == 1), I can't easily upgrade the remove machines to something newer. The affect of this patch is the same and has been tested on a local board, which didn't have problems to start with however. --- configs/Cubietruck_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/configs/Cubietruck_defconfig b/configs/Cubietruck_defconfig index 5c23bc7..fa48331 100644 --- a/configs/Cubietruck_defconfig +++ b/configs/Cubietruck_defconfig @@ -1,6 +1,7 @@ CONFIG_SPL=y CONFIG_SYS_EXTRA_OPTIONS="AXP209_POWER,SUNXI_GMAC,RGMII,AHCI,SATAPWR=SUNXI_GPH(12),USB_EHCI" CONFIG_FDTFILE="sun7i-a20-cubietruck.dtb" +CONFIG_GMAC_TX_DELAY=1 CONFIG_VIDEO_VGA=y CONFIG_ARM=y CONFIG_ARCH_SUNXI=y