Message ID | 1420695867-1621-2-git-send-email-jy0922.shim@samsung.com |
---|---|
State | Changes Requested |
Delegated to: | Minkyu Kang |
Headers | show |
Hi, On 7 January 2015 at 22:44, Joonyoung Shim <jy0922.shim@samsung.com> wrote: > This needs for special handling of SD4_nRESET_OUT line for eMMC memory > to perform complete reboot on Odroid X2/U3 boards. > > Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com> > --- > arch/arm/dts/exynos4412-odroid.dts | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/arm/dts/exynos4412-odroid.dts b/arch/arm/dts/exynos4412-odroid.dts > index ecb3e23..519a7dd 100644 > --- a/arch/arm/dts/exynos4412-odroid.dts > +++ b/arch/arm/dts/exynos4412-odroid.dts > @@ -90,4 +90,9 @@ > reg = <0x125B0000 0x100>; > }; > }; > + > + emmc-reset { > + compatible = "samsung,emmc-reset"; > + reset-gpio = <&gpk1 2 0>; > + }; > }; Shouldn't this go in the relevant sdhci node instead of its own node? Regards, Simon
+Cc Jaehoon, On 01/09/2015 03:20 AM, Simon Glass wrote: > Hi, > > On 7 January 2015 at 22:44, Joonyoung Shim <jy0922.shim@samsung.com> wrote: >> This needs for special handling of SD4_nRESET_OUT line for eMMC memory >> to perform complete reboot on Odroid X2/U3 boards. >> >> Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com> >> --- >> arch/arm/dts/exynos4412-odroid.dts | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/arch/arm/dts/exynos4412-odroid.dts b/arch/arm/dts/exynos4412-odroid.dts >> index ecb3e23..519a7dd 100644 >> --- a/arch/arm/dts/exynos4412-odroid.dts >> +++ b/arch/arm/dts/exynos4412-odroid.dts >> @@ -90,4 +90,9 @@ >> reg = <0x125B0000 0x100>; >> }; >> }; >> + >> + emmc-reset { >> + compatible = "samsung,emmc-reset"; >> + reset-gpio = <&gpk1 2 0>; >> + }; >> }; > > Shouldn't this go in the relevant sdhci node instead of its own node? > Jaehoon, is it reasonable? Thanks.
diff --git a/arch/arm/dts/exynos4412-odroid.dts b/arch/arm/dts/exynos4412-odroid.dts index ecb3e23..519a7dd 100644 --- a/arch/arm/dts/exynos4412-odroid.dts +++ b/arch/arm/dts/exynos4412-odroid.dts @@ -90,4 +90,9 @@ reg = <0x125B0000 0x100>; }; }; + + emmc-reset { + compatible = "samsung,emmc-reset"; + reset-gpio = <&gpk1 2 0>; + }; };
This needs for special handling of SD4_nRESET_OUT line for eMMC memory to perform complete reboot on Odroid X2/U3 boards. Signed-off-by: Joonyoung Shim <jy0922.shim@samsung.com> --- arch/arm/dts/exynos4412-odroid.dts | 5 +++++ 1 file changed, 5 insertions(+)