From patchwork Tue Nov 4 00:15:48 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nobuhiro Iwamatsu X-Patchwork-Id: 406387 X-Patchwork-Delegate: iwamatsu@nigauri.org Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id 3A1D0140077 for ; Tue, 4 Nov 2014 11:16:25 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 00CD74B942; Tue, 4 Nov 2014 01:16:22 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oiHLenzn1ckn; Tue, 4 Nov 2014 01:16:21 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 0F5D74B945; Tue, 4 Nov 2014 01:16:18 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 2459F4B91C for ; Tue, 4 Nov 2014 01:16:13 +0100 (CET) Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HH2wJIr6lI51 for ; Tue, 4 Nov 2014 01:16:13 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-pa0-f51.google.com (mail-pa0-f51.google.com [209.85.220.51]) by theia.denx.de (Postfix) with ESMTPS id 1ACAD4B925 for ; Tue, 4 Nov 2014 01:16:07 +0100 (CET) Received: by mail-pa0-f51.google.com with SMTP id kq14so13234841pab.38 for ; Mon, 03 Nov 2014 16:16:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=k1KZjV76rfKDVGaRL7Tb17Jp/ETZbj2nRSjmuv9ny3E=; b=P5Nf0E5hEgRWpAqLPUAK4X+aCpPelC+PzgfBwBR9Ol/DJX8NdDQ85FFILaE4kfpsGp ubqxyCJnNdh70BHP4l1RbDkxfr6aZTzmk8Ng0viDIMMxdfsLtE90E/BETwfWoN2Fbj/G 6FefFCegbMFVl1YTt81OWkMt7zO/NaEAh8JQn5nH88Jb3NCcpjN6mZt/5DJ8DUr6PbEs SZ+UqKWMX8FED6tilZF9Y9DIm2M0jsmAOTCkw4v0/MV2SDnCaAGrFk66S633fIBxMkbJ 7gkTPcyV5ywihvNQm5s46UICA7R/Dh2zhMR0FuUD47C2xMuCsdNf6sjyTA6FCxlUoVEu X0ng== X-Gm-Message-State: ALoCoQmd1pCrqZdhrIo47qELZjgAJkWEOoPMrmsjpPamv69WGNxni9q/w0ESzAxjVKN0qxZOU/GE X-Received: by 10.70.125.131 with SMTP id mq3mr2446pdb.169.1415060166434; Mon, 03 Nov 2014 16:16:06 -0800 (PST) Received: from xps-iwamatsu.renesas.com (49.14.32.202.bf.2iij.net. [202.32.14.49]) by mx.google.com with ESMTPSA id o5sm18246586pdr.50.2014.11.03.16.16.03 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 03 Nov 2014 16:16:05 -0800 (PST) From: Nobuhiro Iwamatsu To: u-boot@lists.denx.de, Nobuhiro Iwamatsu Date: Tue, 4 Nov 2014 09:15:48 +0900 Message-Id: <1415060148-23982-3-git-send-email-nobuhiro.iwamatsu.yj@renesas.com> X-Mailer: git-send-email 2.1.1 In-Reply-To: <1415060148-23982-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com> References: <1415060148-23982-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com> Cc: Nobuhiro Iwamatsu Subject: [U-Boot] [PATCH 3/3] net: sh-eth: Add cache writeback control after setting bit of DMA descriptor X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.13 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de A bit field of DMA descriptor is on memory area of DMA. If we set data to bit of DMA descriptor, we must be writeback data of DMA descriptor. Signed-off-by: Nobuhiro Iwamatsu --- drivers/net/sh_eth.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c index d1d3b68..4bf493e 100644 --- a/drivers/net/sh_eth.c +++ b/drivers/net/sh_eth.c @@ -2,9 +2,9 @@ * sh_eth.c - Driver for Renesas ethernet controler. * * Copyright (C) 2008, 2011 Renesas Solutions Corp. - * Copyright (c) 2008, 2011 Nobuhiro Iwamatsu + * Copyright (c) 2008, 2011, 2014 2014 Nobuhiro Iwamatsu * Copyright (c) 2007 Carlos Munoz - * Copyright (C) 2013 Renesas Electronics Corporation + * Copyright (C) 2013, 2014 Renesas Electronics Corporation * * SPDX-License-Identifier: GPL-2.0+ */ @@ -83,6 +83,8 @@ int sh_eth_send(struct eth_device *dev, void *packet, int len) else port_info->tx_desc_cur->td0 = TD_TACT | TD_TFP; + flush_cache_wback(port_info->tx_desc_cur, sizeof(struct tx_desc_s)); + /* Restart the transmitter if disabled */ if (!(sh_eth_read(eth, EDTRR) & EDTRR_TRNS)) sh_eth_write(eth, EDTRR_TRNS, EDTRR); @@ -133,6 +135,10 @@ int sh_eth_recv(struct eth_device *dev) port_info->rx_desc_cur->rd0 = RD_RACT | RD_RDLE; else port_info->rx_desc_cur->rd0 = RD_RACT; + + flush_cache_wback(port_info->rx_desc_cur, + sizeof(struct rx_desc_s)); + /* Point to the next descriptor */ port_info->rx_desc_cur++; if (port_info->rx_desc_cur >=