diff mbox

[U-Boot] multiconfig.sh: replace GNU sed specific match

Message ID 1412176978-4061-1-git-send-email-jeroen@myspectrum.nl
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Jeroen Hofstee Oct. 1, 2014, 3:22 p.m. UTC
A SPL/TPL enabled target would was not recognized as
such by BSD sed, since it relies on a GNU extension.
Instead of or-ing just spell out both matches.

Cc: Masahiro Yamada <yamada.m@jp.panasonic.com>
Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>

---
https://www.gnu.org/software/sed/manual/sed.html:

regexp1\|regexp2
    Matches either regexp1 or regexp2. Use parentheses to use complex
    alternative regular expressions. The matching process tries each
    alternative in turn, from left to right, and the first one that
    succeeds is used. It is a GNU extension.
---
 scripts/multiconfig.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Masahiro Yamada Oct. 1, 2014, 3:50 p.m. UTC | #1
Hi Jeroen,

2014-10-02 0:22 GMT+09:00 Jeroen Hofstee <jeroen@myspectrum.nl>:
> A SPL/TPL enabled target would was not recognized as
> such by BSD sed, since it relies on a GNU extension.
> Instead of or-ing just spell out both matches.
>
> Cc: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
>

Acked-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Tom Rini Oct. 10, 2014, 2:42 p.m. UTC | #2
On Wed, Oct 01, 2014 at 05:22:58PM +0200, Jeroen Hofstee wrote:

> A SPL/TPL enabled target would was not recognized as
> such by BSD sed, since it relies on a GNU extension.
> Instead of or-ing just spell out both matches.
> 
> Cc: Masahiro Yamada <yamada.m@jp.panasonic.com>
> Signed-off-by: Jeroen Hofstee <jeroen@myspectrum.nl>
> Acked-by: Masahiro Yamada <yamada.m@jp.panasonic.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/scripts/multiconfig.sh b/scripts/multiconfig.sh
index 4a8737f..c489c7f 100644
--- a/scripts/multiconfig.sh
+++ b/scripts/multiconfig.sh
@@ -69,8 +69,8 @@  get_enabled_subimages() {
 
 	# CONFIG_SPL=y -> spl
 	# CONFIG_TPL=y -> tpl
-	sed -n -e 's/^CONFIG_\(SPL\|TPL\)=y$/\1/p' $KCONFIG_CONFIG | \
-							tr '[A-Z]' '[a-z]'
+	sed -n -e 's/^CONFIG_SPL=y$/spl/p' -e 's/^CONFIG_TPL=y$/tpl/p' \
+							 $KCONFIG_CONFIG
 }
 
 do_silentoldconfig () {