From patchwork Fri Jun 6 18:27:28 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ash Charles X-Patchwork-Id: 356984 X-Patchwork-Delegate: trini@ti.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id B811E1400EE for ; Sat, 7 Jun 2014 04:27:58 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id C39C94B725; Fri, 6 Jun 2014 20:27:55 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XXXF52hNtHyq; Fri, 6 Jun 2014 20:27:55 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id DDBE94B5EB; Fri, 6 Jun 2014 20:27:52 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id A1E034B5EB for ; Fri, 6 Jun 2014 20:27:47 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id xf8TeZrmmyzf for ; Fri, 6 Jun 2014 20:27:44 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-pd0-f177.google.com (mail-pd0-f177.google.com [209.85.192.177]) by theia.denx.de (Postfix) with ESMTPS id 085214A057 for ; Fri, 6 Jun 2014 20:27:39 +0200 (CEST) Received: by mail-pd0-f177.google.com with SMTP id g10so2709158pdj.8 for ; Fri, 06 Jun 2014 11:27:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QKtWpQ7wl4+7CmQrlkYWSbIp6oi1MjSjK/CBX692Q8Q=; b=rqSGwcB8onHMriyR8fKyqOvURP0IRGZ/TpMkBvH5At4vpt/5gFTBmIEfpdCKWPyzto Rghc5vdcCfkIWK39FRuDDrmUkruB+a/eWhkLMr6s145rvGMgigQbRiZJIpKmkhKVkmFu XJ8VW2tnNTGUmu0Xjek+3SWqlnn+06rVzdq7gENkJItAwQaASqzRvTMzHa4JNv08ePc+ AoFe8QLq6XWzTYgfxT/qc1AqCTavEVMKGAfjdWQKhi13ngJXA+cMBkn4oDdOW19SPD8S 63cfjnaoVsZBmI0XtUwjGz6xNNIBjuIy9JXmo7LUgu7JpyfCRuI3zxVwC7BpHrbgFzXB EL3w== X-Received: by 10.68.110.3 with SMTP id hw3mr3431649pbb.144.1402079257937; Fri, 06 Jun 2014 11:27:37 -0700 (PDT) Received: from gumstux.bchsia.telus.net (s206-116-3-18.bc.hsia.telus.net. [206.116.3.18]) by mx.google.com with ESMTPSA id ky8sm38592913pbc.64.2014.06.06.11.27.36 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 06 Jun 2014 11:27:37 -0700 (PDT) From: Ash Charles To: u-boot@lists.denx.de Date: Fri, 6 Jun 2014 11:27:28 -0700 Message-Id: <1402079248-14490-1-git-send-email-ashcharles@gmail.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: References: Cc: Ash Charles Subject: [U-Boot] [PATCH] omap: Don't enable GPMC CS0 with nothing attached X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de If CONFIG_(NAND|NOR|ONENAND) is not defined, no configuration is set for GPMC on chip select #0---size is 0. In this case, the GPMC configuration should be reset but not enabled. Enabling causes the Gumstix DuoVero board to hang when entering Linux. Signed-off-by: Ash Charles --- arch/arm/cpu/armv7/omap-common/mem-common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/cpu/armv7/omap-common/mem-common.c b/arch/arm/cpu/armv7/omap-common/mem-common.c index 944ef84..f3aa268 100644 --- a/arch/arm/cpu/armv7/omap-common/mem-common.c +++ b/arch/arm/cpu/armv7/omap-common/mem-common.c @@ -133,5 +133,6 @@ void gpmc_init(void) writel(0, &gpmc_cfg->cs[0].config7); sdelay(1000); /* enable chip-select specific configurations */ - enable_gpmc_cs_config(gpmc_regs, &gpmc_cfg->cs[0], base, size); + if (size != 0) + enable_gpmc_cs_config(gpmc_regs, &gpmc_cfg->cs[0], base, size); }