diff mbox

[U-Boot] Makfile: fix a rule to build u-boot.sb

Message ID 1383638942-16742-1-git-send-email-yamada.m@jp.panasonic.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Masahiro Yamada Nov. 5, 2013, 8:09 a.m. UTC
Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
---

This is a follow-up patch of the series:
First step towards Kbuild: Use Kbuild style makefiles

The series broke the build rule of u-boot.sb

u-boot.sb is never automatically generated.
(u-boot.sb is not added to ALL-y)

That's why I could detect the bug of the former series
by MAKEALL or patman test.

 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tom Rini Nov. 7, 2013, 12:56 a.m. UTC | #1
On Tue, Nov 05, 2013 at 05:09:02PM +0900, Masahiro Yamada wrote:

> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> 
> ---
> This is a follow-up patch of the series:
> First step towards Kbuild: Use Kbuild style makefiles
> 
> The series broke the build rule of u-boot.sb
> 
> u-boot.sb is never automatically generated.
> (u-boot.sb is not added to ALL-y)
> 
> That's why I could detect the bug of the former series
> by MAKEALL or patman test.
> 
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index a2fd7f6..1f499c5 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -490,7 +490,7 @@ $(obj)u-boot.ais:       $(obj)spl/u-boot-spl.bin $(obj)u-boot.img
>  
>  
>  $(obj)u-boot.sb:       $(obj)u-boot.bin $(obj)spl/u-boot-spl.bin
> -		$(MAKE) -C $(SRCTREE)/$(CPUDIR)/$(SOC)/ $(OBJTREE)/u-boot.sb
> +		$(MAKE) $(build) $(SRCTREE)/$(CPUDIR)/$(SOC)/ $(OBJTREE)/u-boot.sb
>  
>  # On x600 (SPEAr600) U-Boot is appended to U-Boot SPL.
>  # Both images are created using mkimage (crc etc), so that the ROM

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/Makefile b/Makefile
index a2fd7f6..1f499c5 100644
--- a/Makefile
+++ b/Makefile
@@ -490,7 +490,7 @@  $(obj)u-boot.ais:       $(obj)spl/u-boot-spl.bin $(obj)u-boot.img
 
 
 $(obj)u-boot.sb:       $(obj)u-boot.bin $(obj)spl/u-boot-spl.bin
-		$(MAKE) -C $(SRCTREE)/$(CPUDIR)/$(SOC)/ $(OBJTREE)/u-boot.sb
+		$(MAKE) $(build) $(SRCTREE)/$(CPUDIR)/$(SOC)/ $(OBJTREE)/u-boot.sb
 
 # On x600 (SPEAr600) U-Boot is appended to U-Boot SPL.
 # Both images are created using mkimage (crc etc), so that the ROM