diff mbox

[U-Boot] buildman: fix boards.cfg parsing

Message ID 1379578125-7037-1-git-send-email-andreas.devel@googlemail.com
State Accepted
Delegated to: Tom Rini
Headers show

Commit Message

Andreas Bießmann Sept. 19, 2013, 8:08 a.m. UTC 
Commit 27af930e9a5c91365ca639ada580b338eabe4989 changed the boards.cfg format
but missed to change the parsing in buildman.

This patch changes c'tor of Board class to the new sequence, but omits
maintainer field.

Signed-off-by: Andreas Bießmann <andreas.devel@googlemail.com>

---
 tools/buildman/board.py |   13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

Comments

Tom Rini Sept. 21, 2013, 12:07 p.m. UTC | #1 
On Thu, Sep 19, 2013 at 10:08:45AM +0200, Andreas Bie??mann wrote:

> Commit 27af930e9a5c91365ca639ada580b338eabe4989 changed the boards.cfg format
> but missed to change the parsing in buildman.
> 
> This patch changes c'tor of Board class to the new sequence, but omits
> maintainer field.
> 
> Signed-off-by: Andreas Bie??mann <andreas.devel@googlemail.com>

Applied to u-boot/master, thanks!
diff mbox

Patch

diff --git a/tools/buildman/board.py b/tools/buildman/board.py
index a388896..1d3db20 100644
--- a/tools/buildman/board.py
+++ b/tools/buildman/board.py
@@ -5,16 +5,17 @@ 
 
 class Board:
     """A particular board that we can build"""
-    def __init__(self, target, arch, cpu, board_name, vendor, soc, options):
+    def __init__(self, status, arch, cpu, soc, vendor, board_name, target, options):
         """Create a new board type.
 
         Args:
-            target: Target name (use make <target>_config to configure)
+            status: define whether the board is 'Active' or 'Orphaned'
             arch: Architecture name (e.g. arm)
             cpu: Cpu name (e.g. arm1136)
-            board_name: Name of board (e.g. integrator)
-            vendor: Name of vendor (e.g. armltd)
             soc: Name of SOC, or '' if none (e.g. mx31)
+            vendor: Name of vendor (e.g. armltd)
+            board_name: Name of board (e.g. integrator)
+            target: Target name (use make <target>_config to configure)
             options: board-specific options (e.g. integratorcp:CM1136)
         """
         self.target = target
@@ -63,8 +64,10 @@  class Boards:
                 for upto in range(len(fields)):
                     if fields[upto] == '-':
                         fields[upto] = ''
-                while len(fields) < 9:
+                while len(fields) < 8:
                     fields.append('')
+                if len(fields) > 8:
+                    fields = fields[:8]
 
                 board = Board(*fields)
                 self.AddBoard(board)