diff mbox

[U-Boot,V3,08/20] usb: gadget: mv_udc: add MX6Q specific reset

Message ID 1375399657-25642-9-git-send-email-troy.kisky@boundarydevices.com
State Changes Requested
Delegated to: Marek Vasut
Headers show

Commit Message

Troy Kisky Aug. 1, 2013, 11:27 p.m. UTC
Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>

---
	I don't know if this is needed, but it doesn't hurt.
---
 drivers/usb/gadget/mv_udc.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Marek Vasut Aug. 2, 2013, 10:58 a.m. UTC | #1
Dear Troy Kisky,

Why are you adding this? Any kind of explanation is missing.

> Signed-off-by: Troy Kisky <troy.kisky@boundarydevices.com>
> 
> ---
> 	I don't know if this is needed, but it doesn't hurt.
> ---
>  drivers/usb/gadget/mv_udc.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/gadget/mv_udc.c b/drivers/usb/gadget/mv_udc.c
> index 359b8e1..26f193d 100644
> --- a/drivers/usb/gadget/mv_udc.c
> +++ b/drivers/usb/gadget/mv_udc.c
> @@ -13,6 +13,7 @@
>  #include <config.h>
>  #include <net.h>
>  #include <malloc.h>
> +#include <asm/arch/sys_proto.h>
>  #include <asm/io.h>
>  #include <linux/types.h>
>  #include <usb/mv_udc.h>
> @@ -569,6 +570,9 @@ static int mv_pullup(struct usb_gadget *gadget, int
> is_on) /* RESET */
>  		writel(USBCMD_ITC(MICRO_8FRAME) | USBCMD_RST, &udc->usbcmd);
>  		udelay(200);
> +#if defined(CONFIG_MX6Q) || defined(CONFIG_MX6DL)
> +		reset_usb_phy1();
> +#endif
> 
>  		writel((unsigned)controller.epts, &udc->epinitaddr);

Best regards,
Marek Vasut
diff mbox

Patch

diff --git a/drivers/usb/gadget/mv_udc.c b/drivers/usb/gadget/mv_udc.c
index 359b8e1..26f193d 100644
--- a/drivers/usb/gadget/mv_udc.c
+++ b/drivers/usb/gadget/mv_udc.c
@@ -13,6 +13,7 @@ 
 #include <config.h>
 #include <net.h>
 #include <malloc.h>
+#include <asm/arch/sys_proto.h>
 #include <asm/io.h>
 #include <linux/types.h>
 #include <usb/mv_udc.h>
@@ -569,6 +570,9 @@  static int mv_pullup(struct usb_gadget *gadget, int is_on)
 		/* RESET */
 		writel(USBCMD_ITC(MICRO_8FRAME) | USBCMD_RST, &udc->usbcmd);
 		udelay(200);
+#if defined(CONFIG_MX6Q) || defined(CONFIG_MX6DL)
+		reset_usb_phy1();
+#endif
 
 		writel((unsigned)controller.epts, &udc->epinitaddr);