From patchwork Thu May 23 13:15:00 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajeshwari Birje X-Patchwork-Id: 245948 X-Patchwork-Delegate: jagannadh.teki@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id A1EE32C0178 for ; Thu, 23 May 2013 23:08:20 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 621B34A02E; Thu, 23 May 2013 15:08:16 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Rw1oTR09PRfw; Thu, 23 May 2013 15:08:16 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 4FF564A026; Thu, 23 May 2013 15:08:11 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 4053A4A019 for ; Thu, 23 May 2013 15:08:05 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IgdWDuI+CXWv for ; Thu, 23 May 2013 15:07:58 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 BL_NJABL=SKIP(-1.5) (only DNSBL check requested) Received: from mailout2.samsung.com (mailout2.samsung.com [203.254.224.25]) by theia.denx.de (Postfix) with ESMTP id EA83C4A026 for ; Thu, 23 May 2013 15:07:54 +0200 (CEST) Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MN9001JL5SZ0Q30@mailout2.samsung.com> for u-boot@lists.denx.de; Thu, 23 May 2013 22:07:47 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.126]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id D7.78.29708.3A41E915; Thu, 23 May 2013 22:07:47 +0900 (KST) X-AuditID: cbfee690-b7f6f6d00000740c-e4-519e14a34c06 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id B8.34.28381.2A41E915; Thu, 23 May 2013 22:07:47 +0900 (KST) Received: from rajeshwari-linux.sisodomain.com ([107.108.215.115]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MN900HFK5RGLZ70@mmp2.samsung.com>; Thu, 23 May 2013 22:07:46 +0900 (KST) From: Rajeshwari Shinde To: u-boot@lists.denx.de Date: Thu, 23 May 2013 18:45:00 +0530 Message-id: <1369314900-16412-1-git-send-email-rajeshwari.s@samsung.com> X-Mailer: git-send-email 1.7.4.4 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBLMWRmVeSWpSXmKPExsWyRsSkTnexyLxAg63neSxuXP/JZrFrawur xY1fbawWHUdaGC2mHP7CYvFtyzZGi+WvN7JbvN3bye7A4TG74SKLx85Zd9k9Fmwq9bhzbQ+b x9k7Oxg9+rasYgxgi+KySUnNySxLLdK3S+DKuPbSs2AfZ8XLDd+YGxjfsHcxcnJICJhIPJ88 kQnCFpO4cG89WxcjF4eQwFJGiZVHJrPAFZ27wgqRmM4o0XbiIDNIQkhgIpPE/39GIDabgJHE 1pPTGEFsEQEJiV/9VxlBGpgFFjFKbNv8gA0kISxgLjH91muwZhYBVYllbUvBGngFPCQm7rvM CLFNQeLY1K9g2yQEJrNLXGm4xgbRICDxbfIhoJM4gBKyEpsOMEPUS0ocXHGDZQKj4AJGhlWM oqkFyQXFSelFJnrFibnFpXnpesn5uZsYgaF8+t+zCTsY7x2wPsSYDDRuIrOUaHI+MBbySuIN jc2MLExNTI2NzC3NSBNWEudVb7EOFBJITyxJzU5NLUgtii8qzUktPsTIxMEp1cA4VygoUtE8 pXBjr9GBmy2mTbIrQgonzO46sSJna+jiRcce7lhpczHyZKmVdnuK2rPcDZJ6QTO/lmzicJQ2 NlUrE2TNVFq+WPTnv1zftQz5Bl3FUlzJPq075Voz3f5nHUjnSbLv1/pVERGwzYLncem8sm7t qvPJ1gmb+f8HOSdf15vwrsN3jhJLcUaioRZzUXEiABmvbsR7AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrKIsWRmVeSWpSXmKPExsVy+t9jQd3FIvMCDa6dYLa4cf0nm8WurS2s Fjd+tbFadBxpYbSYcvgLi8W3LdsYLZa/3shu8XZvJ7sDh8fshossHjtn3WX3WLCp1OPOtT1s Hmfv7GD06NuyijGALaqB0SYjNTEltUghNS85PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfV VsnFJ0DXLTMH6CIlhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZoIGENY8a1l54F +zgrXm74xtzA+Ia9i5GTQ0LAROL5uSusELaYxIV769m6GLk4hASmM0q0nTjIDJIQEpjIJPH/ nxGIzSZgJLH15DRGEFtEQELiV/9VRpAGZoFFjBLbNj9gA0kIC5hLTL/1GqyZRUBVYlnbUrAG XgEPiYn7LjNCbFOQODb1K+sERu4FjAyrGEVTC5ILipPScw31ihNzi0vz0vWS83M3MYIj5ZnU DsaVDRaHGAU4GJV4eCVuzwkUYk0sK67MPcQowcGsJMK7uWduoBBvSmJlVWpRfnxRaU5q8SHG ZKDtE5mlRJPzgVGcVxJvaGxibmpsamliYWJmSZqwkjjvgVbrQCGB9MSS1OzU1ILUIpgtTByc Ug2MtfKv2n0Mhfdz2wXlZknPOycz8YBBZMZMg/63Sb/m1r+bZh5ucqyovjZw2ZQFgXVixkUX l8dIdF1rizwgN5HxIP/8zTZmKUbdZ8wZDv3/P/Xw0t4thy79nLmh8k/f0crT3XMFGWYb5dfx PFzaUuJzeGvxV/v+jANGLfodKd0TSkQfzfHQOZOpxFKckWioxVxUnAgAl4ENjdgCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: u-boot-review@google.com, patches@linaro.org, jh80.chung@samsung.com, afleming@gmail.com Subject: [U-Boot] [PATCH] MMC: DWMMC: Fix FIFO_DEPTH calculation X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de Current DWMMC driver used to give FIFO underrun/overrun error every 3rd time for mmc rescan command. In current code FIFO_DEPTH is getting calculated after reading the FIFOTH register and extracting the RX_WMARK bits from it i.e (RX_WMARK = FIFO_DEPTH/2 -1). Instead of storing the correct value, we were recalculating the FIFO_DEPT each time which is not correct. Signed-off-by: Hatim Ali Signed-off-by: Rajeshwari Shinde Reviewed-by: Alim Akhtar Acked-by: Jaehoon Chung --- drivers/mmc/dw_mmc.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/dw_mmc.c b/drivers/mmc/dw_mmc.c index 4070d4e..be590a4 100644 --- a/drivers/mmc/dw_mmc.c +++ b/drivers/mmc/dw_mmc.c @@ -332,11 +332,13 @@ static int dwmci_init(struct mmc *mmc) dwmci_writel(host, DWMCI_BMOD, 1); fifo_size = dwmci_readl(host, DWMCI_FIFOTH); - if (host->fifoth_val) + if (host->fifoth_val) { fifoth_val = host->fifoth_val; - else + } else { fifoth_val = MSIZE(0x2) | RX_WMARK(fifo_size/2 -1) | TX_WMARK(fifo_size/2); + host->fifoth_val = fifoth_val; + } dwmci_writel(host, DWMCI_FIFOTH, fifoth_val); dwmci_writel(host, DWMCI_CLKENA, 0);