From patchwork Fri May 17 11:03:20 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajeshwari Birje X-Patchwork-Id: 244614 X-Patchwork-Delegate: promsoft@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id ADD8C2C00A1 for ; Fri, 17 May 2013 20:56:13 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 90AFC4A096; Fri, 17 May 2013 12:56:02 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kUSw0QBySV9a; Fri, 17 May 2013 12:56:02 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id DDF374A08E; Fri, 17 May 2013 12:55:41 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id F2B504A039 for ; Fri, 17 May 2013 12:55:36 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lzk+mHwX59OD for ; Fri, 17 May 2013 12:55:32 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by theia.denx.de (Postfix) with ESMTP id 1E89B4A046 for ; Fri, 17 May 2013 12:55:26 +0200 (CEST) Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MMX00MB3VNHBMO0@mailout3.samsung.com> for u-boot@lists.denx.de; Fri, 17 May 2013 19:55:15 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.123]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id B8.0D.08825.39C06915; Fri, 17 May 2013 19:55:15 +0900 (KST) X-AuditID: cbfee68e-b7f276d000002279-08-51960c938d0f Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id 61.74.16109.39C06915; Fri, 17 May 2013 19:55:15 +0900 (KST) Received: from rajeshwari-linux.sisodomain.com ([107.108.215.115]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MMX00F8CVNTEW90@mmp1.samsung.com>; Fri, 17 May 2013 19:55:15 +0900 (KST) From: Rajeshwari Shinde To: u-boot@lists.denx.de Date: Fri, 17 May 2013 16:33:20 +0530 Message-id: <1368788601-11221-4-git-send-email-rajeshwari.s@samsung.com> X-Mailer: git-send-email 1.7.4.4 In-reply-to: <1368788601-11221-1-git-send-email-rajeshwari.s@samsung.com> References: <1368788601-11221-1-git-send-email-rajeshwari.s@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNLMWRmVeSWpSXmKPExsWyRsSkWncyz7RAg9NnjS06jrQwWkw5/IXF 4tuWbYwWy19vZLd4u7eT3YHVY3bDRRaPBZtKPe5c28PmcfbODkaPvi2rGANYo7hsUlJzMstS i/TtErgyXly7w1YwUb1i0p/DTA2MX+W7GDk5JARMJG4vbmCHsMUkLtxbz9bFyMUhJLCUUaKz fSUjTNH5rUfBbCGBRYwSs28IQhRNZJLYtPUpE0iCTcBIYuvJaWBFIgISEr/6r4LZzAJREt+7 L4FtEBawk7h+6QhQPQcHi4CqxO39siBhXgEPibu/HzFD7FKQODb1KyuIzSngKXFq4lY2iL0e EjO+T2UC2Ssh0M0uceb7bbAEi4CAxLfJh1hAZkoIyEpsOgA1R1Li4IobLBMYhRcwMqxiFE0t SC4oTkovMtIrTswtLs1L10vOz93ECAzo0/+e9e1gvHnA+hBjMtC4icxSosn5wIjIK4k3NDYz sjA1MTU2Mrc0I01YSZxXrcU6UEggPbEkNTs1tSC1KL6oNCe1+BAjEwenVAPj5Irtkc1bF16a z6Q3c36p0RT3/by7jz8VE3g+STOWM0qkz3HplJZ1HhMmvNNTvdS+6Wz3ss+MOaKzNlfNnBSS de9IXVjSzO2mcflWFdyZJ+48Xai7UUVwnV2Ggw9z4MftQhdPfRR7FMw/rUOiKIsx6dDlJz8z 2JkK7UJfREy417lo2u+iLzdqlFiKMxINtZiLihMBlwDbdH4CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBIsWRmVeSWpSXmKPExsVy+t9jAd3JPNMCDTrPa1l0HGlhtJhy+AuL xbct2xgtlr/eyG7xdm8nuwOrx+yGiyweCzaVety5tofN4+ydHYwefVtWMQawRjUw2mSkJqak Fimk5iXnp2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl5qbaKrn4BOi6ZeYAbVdSKEvMKQUKBSQW Fyvp22GaEBripmsB0xih6xsSBNdjZIAGEtYwZry4doetYKJ6xaQ/h5kaGL/KdzFyckgImEic 33qUEcIWk7hwbz0biC0ksIhRYvYNwS5GLiB7IpPEpq1PmUASbAJGEltPTgNrEBGQkPjVfxXM ZhaIkvjefYkdxBYWsJO4fukIUD0HB4uAqsTt/bIgYV4BD4m7vx8xQ+xSkDg29SsriM0p4Clx auJWqL0eEjO+T2WawMi7gJFhFaNoakFyQXFSeq6hXnFibnFpXrpecn7uJkZwvDyT2sG4ssHi EKMAB6MSD6/CzymBQqyJZcWVuYcYJTiYlUR4j3+cGijEm5JYWZValB9fVJqTWnyIMRnoqInM UqLJ+cBYziuJNzQ2MTc1NrU0sTAxsyRNWEmc90CrdaCQQHpiSWp2ampBahHMFiYOTqkGRoeS G5EdV+0279rOGFPIwG3O/nXDjFaOl9ndH1e4aWSUxT90ivmteqK9pOfIlZIZ5g4b99akWgkL Op7ri6vb1dXwxqFxwrY3NpVpoq8ZapZdu6ebuj9M4KZowuM/u375MO9Lu/lnyYqyW1PsuUqO mbLpXA6oMOp89mN/lp6o2OaTp1Yvu/v4txJLcUaioRZzUXEiAHqqwgjbAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: u-boot-review@google.com, patches@linaro.org Subject: [U-Boot] [PATCH 3/4 V5] S5P: Serial: Add fdt support to driver X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de This patch adds FDT support to the serial s5p driver. At present disabling the serial console (from the device tree) crashes U-Boot. Add checks for this case, so that execution can continue without a serial console. It also enables the serial_s5p driver recognize the silent_console option. Signed-off-by: Abhilash Kesavan Signed-off-by: Gabe Black Signed-off-by: Simon Glass Signed-off-by: Rajeshwari Shinde --- Changes in V2: - None Changes in V3: - Moved driver config structure to data section. - Changed silent_console to silent-console. - Did put a check for base address before doing fdt decoding. Changes in V4: - None Changes in V5: - None drivers/serial/serial_s5p.c | 78 +++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 78 insertions(+), 0 deletions(-) diff --git a/drivers/serial/serial_s5p.c b/drivers/serial/serial_s5p.c index 3c41242..55ef2bf 100644 --- a/drivers/serial/serial_s5p.c +++ b/drivers/serial/serial_s5p.c @@ -24,16 +24,28 @@ #include #include #include +#include #include #include #include DECLARE_GLOBAL_DATA_PTR; +/* Information about a serial port */ +struct fdt_serial { + u32 base_addr; /* address of registers in physical memory */ + u8 port_id; /* uart port number */ + u8 enabled; /* 1 if enabled, 0 if disabled */ +} config __attribute__ ((section(".data"))); + static inline struct s5p_uart *s5p_get_base_uart(int dev_index) { +#ifdef CONFIG_OF_CONTROL + return (struct s5p_uart *)(config.base_addr); +#else u32 offset = dev_index * sizeof(struct s5p_uart); return (struct s5p_uart *)(samsung_get_base_uart() + offset); +#endif } /* @@ -69,6 +81,9 @@ void serial_setbrg_dev(const int dev_index) u32 baudrate = gd->baudrate; u32 val; + if (!config.enabled) + return; + val = uclk / baudrate; writel(val / 16 - 1, &uart->ubrdiv); @@ -87,6 +102,16 @@ int serial_init_dev(const int dev_index) { struct s5p_uart *const uart = s5p_get_base_uart(dev_index); +#if defined(CONFIG_SILENT_CONSOLE) && \ + defined(CONFIG_OF_CONTROL) && \ + !defined(CONFIG_SPL_BUILD) + if (fdtdec_get_config_int(gd->fdt_blob, "silent_console", 0)) + gd->flags |= GD_FLG_SILENT; +#endif + + if (!config.enabled) + return 0; + /* reset and enable FIFOs, set triggers to the maximum */ writel(0, &uart->ufcon); writel(0, &uart->umcon); @@ -129,6 +154,9 @@ int serial_getc_dev(const int dev_index) { struct s5p_uart *const uart = s5p_get_base_uart(dev_index); + if (!config.enabled) + return 0; + /* wait for character to arrive */ while (!(readl(&uart->utrstat) & 0x1)) { if (serial_err_check(dev_index, 0)) @@ -145,6 +173,9 @@ void serial_putc_dev(const char c, const int dev_index) { struct s5p_uart *const uart = s5p_get_base_uart(dev_index); + if (!config.enabled) + return; + /* wait for room in the tx FIFO */ while (!(readl(&uart->utrstat) & 0x2)) { if (serial_err_check(dev_index, 1)) @@ -165,6 +196,9 @@ int serial_tstc_dev(const int dev_index) { struct s5p_uart *const uart = s5p_get_base_uart(dev_index); + if (!config.enabled) + return 0; + return (int)(readl(&uart->utrstat) & 0x1); } @@ -207,8 +241,51 @@ DECLARE_S5P_SERIAL_FUNCTIONS(3); struct serial_device s5p_serial3_device = INIT_S5P_SERIAL_STRUCTURE(3, "s5pser3"); +#ifdef CONFIG_OF_CONTROL +int fdtdec_decode_console(int *index, struct fdt_serial *uart) +{ + const void *blob = gd->fdt_blob; + int node; + + node = fdt_path_offset(blob, "console"); + if (node < 0) + return node; + + uart->base_addr = fdtdec_get_addr(blob, node, "reg"); + if (uart->base_addr == FDT_ADDR_T_NONE) + return -FDT_ERR_NOTFOUND; + + uart->port_id = fdtdec_get_int(blob, node, "id", -1); + uart->enabled = fdtdec_get_is_enabled(blob, node); + + return 0; +} +#endif + __weak struct serial_device *default_serial_console(void) { +#ifdef CONFIG_OF_CONTROL + int index = 0; + + if ((!config.base_addr) && (fdtdec_decode_console(&index, &config))) { + debug("Cannot decode default console node\n"); + return NULL; + } + + if (config.port_id == 0) + return &s5p_serial0_device; + else if (config.port_id == 1) + return &s5p_serial1_device; + else if (config.port_id == 2) + return &s5p_serial2_device; + else if (config.port_id == 3) + return &s5p_serial3_device; + else + debug("Unknown config.port_id: %d", config.port_id); + + return NULL; +#else + config.enabled = 1; #if defined(CONFIG_SERIAL0) return &s5p_serial0_device; #elif defined(CONFIG_SERIAL1) @@ -220,6 +297,7 @@ __weak struct serial_device *default_serial_console(void) #else #error "CONFIG_SERIAL? missing." #endif +#endif } void s5p_serial_initialize(void)