| Message ID | 1365141274-22459-1-git-send-email-r.sricharan@ti.com |
|---|---|
| State | Not Applicable |
| Headers | show |
Hi Sricharan, On Fri, 5 Apr 2013 11:24:34 +0530, Sricharan R <r.sricharan@ti.com> wrote: > So with OMAP added to multi platform kernel, > the uImage no more contains a valid load address. > With the uboot already supporting zImage, > change the default boot command to bootz > instead. > > Acked-by: Nishanth Menon <nm@ti.com> > Signed-off-by: Sricharan R <r.sricharan@ti.com> > Tested-by: Nishanth Menon <nm@ti.com> > --- > include/configs/omap4_common.h | 4 ++-- > include/configs/omap5_common.h | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) Is there a reason why this patch does not have history? Amicalement,
Hi Albert, On Friday 05 April 2013 12:36 PM, Albert ARIBAUD wrote: > Hi Sricharan, > > On Fri, 5 Apr 2013 11:24:34 +0530, Sricharan R <r.sricharan@ti.com> > wrote: > >> So with OMAP added to multi platform kernel, >> the uImage no more contains a valid load address. >> With the uboot already supporting zImage, >> change the default boot command to bootz >> instead. >> >> Acked-by: Nishanth Menon <nm@ti.com> >> Signed-off-by: Sricharan R <r.sricharan@ti.com> >> Tested-by: Nishanth Menon <nm@ti.com> >> --- >> include/configs/omap4_common.h | 4 ++-- >> include/configs/omap5_common.h | 4 ++-- >> 2 files changed, 4 insertions(+), 4 deletions(-) > > Is there a reason why this patch does not have history? > > Amicalement, I had a minor change only in these two from the series. So reposted only these two with 'in-reply-to' threads. If this is not the right etiquette, then should it be update/appended in the original patch ? Regards, Sricharan
Hi Sricharan, On Fri, 5 Apr 2013 12:44:45 +0530, Sricharan R <r.sricharan@ti.com> wrote: > Hi Albert, > > On Friday 05 April 2013 12:36 PM, Albert ARIBAUD wrote: > > Hi Sricharan, > > > > On Fri, 5 Apr 2013 11:24:34 +0530, Sricharan R <r.sricharan@ti.com> > > wrote: > > > >> So with OMAP added to multi platform kernel, > >> the uImage no more contains a valid load address. > >> With the uboot already supporting zImage, > >> change the default boot command to bootz > >> instead. > >> > >> Acked-by: Nishanth Menon <nm@ti.com> > >> Signed-off-by: Sricharan R <r.sricharan@ti.com> > >> Tested-by: Nishanth Menon <nm@ti.com> > >> --- > >> include/configs/omap4_common.h | 4 ++-- > >> include/configs/omap5_common.h | 4 ++-- > >> 2 files changed, 4 insertions(+), 4 deletions(-) > > > > Is there a reason why this patch does not have history? > > > > Amicalement, > I had a minor change only in these two from the series. > So reposted only these two with 'in-reply-to' threads. > If this is not the right etiquette, then should it be > update/appended in the original patch ? My question is not about the series but only about 5/5 which has no patch history after the commit message delimiter (---) whereas 4/5 has history. If 5/5 has a minor change in V4, then it should have a history log indicating which minor change it was. > Regards, > Sricharan Amicalement,
On Friday 05 April 2013 01:38 PM, Albert ARIBAUD wrote: > Hi Sricharan, > > On Fri, 5 Apr 2013 12:44:45 +0530, Sricharan R <r.sricharan@ti.com> > wrote: > >> Hi Albert, >> >> On Friday 05 April 2013 12:36 PM, Albert ARIBAUD wrote: >>> Hi Sricharan, >>> >>> On Fri, 5 Apr 2013 11:24:34 +0530, Sricharan R <r.sricharan@ti.com> >>> wrote: >>> >>>> So with OMAP added to multi platform kernel, >>>> the uImage no more contains a valid load address. >>>> With the uboot already supporting zImage, >>>> change the default boot command to bootz >>>> instead. >>>> >>>> Acked-by: Nishanth Menon <nm@ti.com> >>>> Signed-off-by: Sricharan R <r.sricharan@ti.com> >>>> Tested-by: Nishanth Menon <nm@ti.com> >>>> --- >>>> include/configs/omap4_common.h | 4 ++-- >>>> include/configs/omap5_common.h | 4 ++-- >>>> 2 files changed, 4 insertions(+), 4 deletions(-) >>> >>> Is there a reason why this patch does not have history? >>> >>> Amicalement, >> I had a minor change only in these two from the series. >> So reposted only these two with 'in-reply-to' threads. >> If this is not the right etiquette, then should it be >> update/appended in the original patch ? > > My question is not about the series but only about 5/5 which has > no patch history after the commit message delimiter (---) whereas 4/5 > has history. > > If 5/5 has a minor change in V4, then it should have a history log > indicating which minor change it was. > ok. 5/5 was just rebase on 4/5. Will add it though. Sorry for the miss. Regards, Sricharan
diff --git a/include/configs/omap4_common.h b/include/configs/omap4_common.h index 7af3989..1fd3097 100644 --- a/include/configs/omap4_common.h +++ b/include/configs/omap4_common.h @@ -152,7 +152,7 @@ "fdtaddr=0x80f80000\0" \ "bootpart=0:2\0" \ "bootdir=/boot\0" \ - "bootfile=uImage\0" \ + "bootfile=zImage\0" \ "usbtty=cdc_acm\0" \ "vram=16M\0" \ "mmcdev=0\0" \ @@ -171,7 +171,7 @@ "loadimage=load mmc ${bootpart} ${loadaddr} ${bootdir}/${bootfile}\0" \ "mmcboot=echo Booting from mmc${mmcdev} ...; " \ "run mmcargs; " \ - "bootm ${loadaddr} - ${fdtaddr}\0" \ + "bootz ${loadaddr} - ${fdtaddr}\0" \ "findfdt="\ "if test $board_name = sdp4430; then " \ "setenv fdtfile omap4-sdp.dtb; fi; " \ diff --git a/include/configs/omap5_common.h b/include/configs/omap5_common.h index 6fb0253..da0ead9 100644 --- a/include/configs/omap5_common.h +++ b/include/configs/omap5_common.h @@ -151,7 +151,7 @@ "fdtaddr=0x80f80000\0" \ "bootpart=0:2\0" \ "bootdir=/boot\0" \ - "bootfile=uImage\0" \ + "bootfile=zImage\0" \ "usbtty=cdc_acm\0" \ "vram=16M\0" \ "mmcdev=0\0" \ @@ -170,7 +170,7 @@ "loadimage=load mmc ${bootpart} ${loadaddr} ${bootdir}/${bootfile}\0" \ "mmcboot=echo Booting from mmc${mmcdev} ...; " \ "run mmcargs; " \ - "bootm ${loadaddr} - ${fdtaddr}\0" \ + "bootz ${loadaddr} - ${fdtaddr}\0" \ "findfdt="\ "if test $board_name = omap5_uevm; then " \ "setenv fdtfile omap5-uevm.dtb; fi;\0 " \