From patchwork Mon Jan 14 05:49:36 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rajeshwari Birje X-Patchwork-Id: 211705 X-Patchwork-Delegate: promsoft@gmail.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id D806A2C00B1 for ; Mon, 14 Jan 2013 16:42:30 +1100 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 37CD24A023; Mon, 14 Jan 2013 06:42:29 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id egYBWinNxpIl; Mon, 14 Jan 2013 06:42:29 +0100 (CET) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id C36534A027; Mon, 14 Jan 2013 06:42:26 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 15B154A027 for ; Mon, 14 Jan 2013 06:42:24 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kejYEJMhzQaA for ; Mon, 14 Jan 2013 06:42:22 +0100 (CET) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by theia.denx.de (Postfix) with ESMTP id 0744A4A023 for ; Mon, 14 Jan 2013 06:42:20 +0100 (CET) Received: from epcpsbgm1.samsung.com (epcpsbgm1 [203.254.230.26]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MGL009G7P6AMRL0@mailout1.samsung.com> for u-boot@lists.denx.de; Mon, 14 Jan 2013 14:42:17 +0900 (KST) Received: from epcpsbgm1.samsung.com ( [172.20.52.125]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id A9.82.01231.9BA93F05; Mon, 14 Jan 2013 14:42:17 +0900 (KST) X-AuditID: cbfee61a-b7fa66d0000004cf-fc-50f39ab994f8 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm1.samsung.com (EPCPMTA) with SMTP id D7.82.01231.8BA93F05; Mon, 14 Jan 2013 14:42:17 +0900 (KST) Received: from rajeshwari-linux.sisodomain.com ([107.108.215.115]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0MGL00F64P6ABA50@mmp1.samsung.com> for u-boot@lists.denx.de; Mon, 14 Jan 2013 14:42:16 +0900 (KST) From: Rajeshwari Shinde To: u-boot@lists.denx.de Date: Mon, 14 Jan 2013 11:19:36 +0530 Message-id: <1358142576-1957-1-git-send-email-rajeshwari.s@samsung.com> X-Mailer: git-send-email 1.7.4.4 In-reply-to: <712aayush@samsung.com> References: <712aayush@samsung.com> DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFLMWRmVeSWpSXmKPExsWyRsSkVnfnrM8BBq+7eC3e7u1kd2D0OHtn B2MAYxSXTUpqTmZZapG+XQJXRvf0CWwFr3krfs+/x97AeIW7i5GDQ0LARGLjt7AuRk4gU0zi wr31bF2MXBxCAksZJd7+WsMOkTCReHxvOzNEYhGjxJuVlxghnFVMEq+vHWIEqWITMJLYenIa mC0iICHxq/8qI8gGZgEPiUmnA0DCwgL2Eic3rgYbyiKgKrHy1wswm1fAXaLj5HIWiGUKEsem fmUFsTkFVCSWTp3MAjJGSEBZ4vMmf4hWAYlvkw+xQNwvK7HpANhpEgLX2SS2rXsINUZS4uCK GywTGIUXMDKsYhRNLUguKE5KzzXUK07MLS7NS9dLzs/dxAgMwNP/nkntYFzZYHGIUYCDUYmH d1LE5wAh1sSy4srcQ4wSHMxKIryhdUAh3pTEyqrUovz4otKc1OJDjD5Al0xklhJNzgdGR15J vKGxibmpsamlkZGZqSkOYSVxXsZTTwKEBNITS1KzU1MLUotgxjFxcEo1MJ7dwCnh2ZI1XTF2 98EfhUmBH9VvFZw8Lqfr8jMyc1ZOkI2wr2mw3bJzRv3Zha9nZq/7rPen7NP1K7Zzf83ydpL8 /Op5+MwY52nM5xemWwVtydCeOiFH4M3P4LnpPipVHMqRvrNvqTje4DFY277Q+rHYH2++X01C fTNZ447yTNj3TceCd+a7UCWW4oxEQy3mouJEALTiRixtAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkkeLIzCtJLcpLzFFi42I5/e+xgO7OWZ8DDB7lWLzd28nuwOhx9s4O xgDGqAZGm4zUxJTUIoXUvOT8lMy8dFsl7+B453hTMwNDXUNLC3MlhbzE3FRbJRefAF23zByg qUoKZYk5pUChgMTiYiV9O0wTQkPcdC1gGiN0fUOC4HqMDNBAwhrGjO7pE9gKXvNW/J5/j72B 8Qp3FyMnh4SAicTje9uZIWwxiQv31rN1MXJxCAksYpR4s/ISI4Szikni9bVDjCBVbAJGEltP TgOzRQQkJH71XwWyOTiYBTwkJp0OAAkLC9hLnNy4mh3EZhFQlVj56wWYzSvgLtFxcjkLxDIF iWNTv7KC2JwCKhJLp05mARkjJKAs8XmT/wRG3gWMDKsYRVMLkguKk9JzDfWKE3OLS/PS9ZLz czcxgsP7mdQOxpUNFocYBTgYlXh4J0V8DhBiTSwrrsw9xCjBwawkwhtaBxTiTUmsrEotyo8v Ks1JLT7E6AN01ERmKdHkfGDs5ZXEGxqbmJsam1qaWJiYWeIQVhLnZTz1JEBIID2xJDU7NbUg tQhmHBMHp1QDo9yaju/3XnP4Fde4GO7/tuZEr2eTd6pKaZxp5VQ2o1aNjnvLlp5ymL75zQ3f RcYf120qvd8xOaTq6gWG9XXzbqz5/ubbyVXvXm12/n9DPuPF/6MBMU1h8rHq5/ul3JuX9MVf a9bn29Hi+Fz47rzvqnvvVS7sWue/58tDzeq5YRkZNU9kLZ8tnKnEUpyRaKjFXFScCADKG5AP nAIAAA== X-CFilter-Loop: Reflected Cc: patches@linaro.org Subject: [U-Boot] [PATCH V2] I2C: S3C24X0: Resolve build error for VCMA9 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de This patch resolves the following build errors for I2C driver in VCMA9: In file included from s3c24x0_i2c.c:40:0: s3c24x0_i2c.h:38:17: error: field 'id' has incomplete type s3c24x0_i2c.c:70:39: error: 'CONFIG_MAX_I2C_NUM' undeclared here (not in a function) s3c24x0_i2c.c:70:31: warning: 'i2c_bus' defined but not used [-Wunused-variable] s3c24x0_i2c.c:72:12: warning: 'i2c_busses' defined but not used [-Wunused-variable] Signed-off-by: Rajeshwari Shinde --- Changes since V1: - Changes the commit message to add the errors. - changed enum periph_id to int drivers/i2c/s3c24x0_i2c.c | 4 +++- drivers/i2c/s3c24x0_i2c.h | 3 +-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/s3c24x0_i2c.c b/drivers/i2c/s3c24x0_i2c.c index 7ec01ec..769a2ba 100644 --- a/drivers/i2c/s3c24x0_i2c.c +++ b/drivers/i2c/s3c24x0_i2c.c @@ -67,9 +67,11 @@ * variables to live in SRAM */ static unsigned int g_current_bus __attribute__((section(".data"))); +#ifdef CONFIG_OF_CONTROL +static int i2c_busses __attribute__((section(".data"))); static struct s3c24x0_i2c_bus i2c_bus[CONFIG_MAX_I2C_NUM] __attribute__((section(".data"))); -static int i2c_busses __attribute__((section(".data"))); +#endif #if !(defined CONFIG_EXYNOS4 || defined CONFIG_EXYNOS5) static int GetI2CSDA(void) diff --git a/drivers/i2c/s3c24x0_i2c.h b/drivers/i2c/s3c24x0_i2c.h index 1243bf1..a56d749 100644 --- a/drivers/i2c/s3c24x0_i2c.h +++ b/drivers/i2c/s3c24x0_i2c.h @@ -35,7 +35,6 @@ struct s3c24x0_i2c_bus { int node; /* device tree node */ int bus_num; /* i2c bus number */ struct s3c24x0_i2c *regs; - enum periph_id id; + int id; }; - #endif /* _S3C24X0_I2C_H */