diff mbox

[U-Boot,v2,5/6] ARM: Add SPL target to arm1136

Message ID 1349939506-4109-6-git-send-email-sbabic@denx.de
State Changes Requested
Delegated to: Stefano Babic
Headers show

Commit Message

Stefano Babic Oct. 11, 2012, 7:11 a.m. UTC 
Signed-off-by: Stefano Babic <sbabic@denx.de>
---

 Makefile                       |    1 +
 arch/arm/cpu/arm1136/config.mk |    3 +++
 2 files changed, 4 insertions(+)

Comments

Albert ARIBAUD Oct. 14, 2012, 9:17 a.m. UTC | #1 
Hi Stefano,

On Thu, 11 Oct 2012 09:11:45 +0200, Stefano Babic <sbabic@denx.de>
wrote:

> Signed-off-by: Stefano Babic <sbabic@denx.de>
> ---
> 
>  Makefile                       |    1 +
>  arch/arm/cpu/arm1136/config.mk |    3 +++
>  2 files changed, 4 insertions(+)
> 
> diff --git a/Makefile b/Makefile
> index a40d4cc..072bf66 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -819,6 +819,7 @@ clobber:	tidy
>  	@rm -f $(obj)nand_spl/{u-boot.lds,u-boot-nand_spl.lds,u-boot-spl,u-boot-spl.map,System.map}
>  	@rm -f $(obj)spl/{u-boot-spl,u-boot-spl.bin,u-boot-spl.lds,u-boot-spl.map}
>  	@rm -f $(obj)MLO
> +	@rm -f $(obj)SPL
>  	@rm -f $(obj)tools/xway-swap-bytes
>  	@rm -f $(obj)arch/powerpc/cpu/mpc824x/bedbug_603e.c
>  	@rm -f $(obj)arch/powerpc/cpu/mpc83xx/ddr-gen?.c
> diff --git a/arch/arm/cpu/arm1136/config.mk b/arch/arm/cpu/arm1136/config.mk
> index efee0d1..9092d91 100644
> --- a/arch/arm/cpu/arm1136/config.mk
> +++ b/arch/arm/cpu/arm1136/config.mk
> @@ -31,3 +31,6 @@ PLATFORM_CPPFLAGS += -march=armv5
>  # =========================================================================
>  PF_RELFLAGS_SLB_AT := $(call cc-option,-mshort-load-bytes,$(call cc-option,-malignment-traps,))
>  PLATFORM_RELFLAGS += $(PF_RELFLAGS_SLB_AT)
> +ifdef CONFIG_SPL_BUILD
> +ALL-y	+= $(OBJTREE)/SPL
> +endif

Nitpick: this patch also removes SPL build files in the clobber rule,
but the commit message does not say so. Can you just update the comment?

Amicalement,
Stefano Babic Oct. 15, 2012, 9:43 a.m. UTC | #2 
Am 14/10/2012 11:17, schrieb Albert ARIBAUD:
> Hi Stefano,
> 

Hi Albert,

> Nitpick: this patch also removes SPL build files in the clobber rule,
> but the commit message does not say so. Can you just update the comment?

Right, I fix it in V3, thanks.

Stefano
diff mbox

Patch

diff --git a/Makefile b/Makefile
index a40d4cc..072bf66 100644
--- a/Makefile
+++ b/Makefile
@@ -819,6 +819,7 @@  clobber:	tidy
 	@rm -f $(obj)nand_spl/{u-boot.lds,u-boot-nand_spl.lds,u-boot-spl,u-boot-spl.map,System.map}
 	@rm -f $(obj)spl/{u-boot-spl,u-boot-spl.bin,u-boot-spl.lds,u-boot-spl.map}
 	@rm -f $(obj)MLO
+	@rm -f $(obj)SPL
 	@rm -f $(obj)tools/xway-swap-bytes
 	@rm -f $(obj)arch/powerpc/cpu/mpc824x/bedbug_603e.c
 	@rm -f $(obj)arch/powerpc/cpu/mpc83xx/ddr-gen?.c
diff --git a/arch/arm/cpu/arm1136/config.mk b/arch/arm/cpu/arm1136/config.mk
index efee0d1..9092d91 100644
--- a/arch/arm/cpu/arm1136/config.mk
+++ b/arch/arm/cpu/arm1136/config.mk
@@ -31,3 +31,6 @@  PLATFORM_CPPFLAGS += -march=armv5
 # =========================================================================
 PF_RELFLAGS_SLB_AT := $(call cc-option,-mshort-load-bytes,$(call cc-option,-malignment-traps,))
 PLATFORM_RELFLAGS += $(PF_RELFLAGS_SLB_AT)
+ifdef CONFIG_SPL_BUILD
+ALL-y	+= $(OBJTREE)/SPL
+endif