| Message ID | 1346918700-32429-6-git-send-email-sbabic@denx.de |
|---|---|
| State | Changes Requested |
| Delegated to: | Stefano Babic |
| Headers | show |
On 09/06/2012 01:04 AM, Stefano Babic wrote: > Signed-off-by: Stefano Babic <sbabic@denx.de> > --- > spl/Makefile | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/spl/Makefile b/spl/Makefile > index f96c08e..77fc405 100644 > --- a/spl/Makefile > +++ b/spl/Makefile > @@ -109,6 +109,12 @@ $(OBJTREE)/MLO: $(obj)u-boot-spl.bin > -a $(CONFIG_SPL_TEXT_BASE) -d $< $@ > endif > > +ifneq ($(CONFIG_IMX_CONFIG),) > +$(OBJTREE)/MLO: $(obj)u-boot-spl.bin > + $(OBJTREE)/tools/mkimage -n $(SRCTREE)/$(CONFIG_IMX_CONFIG) -T imximage \ > + -e $(CONFIG_SPL_TEXT_BASE) -d $< $@ > +endif > + > ALL-y += $(obj)u-boot-spl.bin > > ifdef CONFIG_SAMSUNG Is that really the name you want? MLO comes from some part or another (I've read it, just can't recall off-hand) of the IT ROM docs saying it will read a file named MLO. Is mx35 in the same boat? Or just looking for a common name? Thanks!
On 06/09/2012 19:49, Tom Rini wrote: > On 09/06/2012 01:04 AM, Stefano Babic wrote: >> Signed-off-by: Stefano Babic <sbabic@denx.de> >> --- >> spl/Makefile | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/spl/Makefile b/spl/Makefile >> index f96c08e..77fc405 100644 >> --- a/spl/Makefile >> +++ b/spl/Makefile >> @@ -109,6 +109,12 @@ $(OBJTREE)/MLO: $(obj)u-boot-spl.bin >> -a $(CONFIG_SPL_TEXT_BASE) -d $< $@ >> endif >> >> +ifneq ($(CONFIG_IMX_CONFIG),) >> +$(OBJTREE)/MLO: $(obj)u-boot-spl.bin >> + $(OBJTREE)/tools/mkimage -n $(SRCTREE)/$(CONFIG_IMX_CONFIG) -T imximage \ >> + -e $(CONFIG_SPL_TEXT_BASE) -d $< $@ >> +endif >> + >> ALL-y += $(obj)u-boot-spl.bin >> >> ifdef CONFIG_SAMSUNG > > Is that really the name you want? MLO comes from some part or another > (I've read it, just can't recall off-hand) of the IT ROM docs saying it > will read a file named MLO. I know... > Is mx35 in the same boat? > Or just looking > for a common name? Right. It makes no sense that the binary for Freescale's SOCs has a name, for TI another one, for...we can generates less confusion if we uses the same name. Stefano
On 09/06/2012 12:59 PM, Stefano Babic wrote: > On 06/09/2012 19:49, Tom Rini wrote: >> On 09/06/2012 01:04 AM, Stefano Babic wrote: >>> Signed-off-by: Stefano Babic <sbabic@denx.de> >>> --- >>> spl/Makefile | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/spl/Makefile b/spl/Makefile >>> index f96c08e..77fc405 100644 >>> --- a/spl/Makefile >>> +++ b/spl/Makefile >>> @@ -109,6 +109,12 @@ $(OBJTREE)/MLO: $(obj)u-boot-spl.bin >>> -a $(CONFIG_SPL_TEXT_BASE) -d $< $@ >>> endif >>> >>> +ifneq ($(CONFIG_IMX_CONFIG),) >>> +$(OBJTREE)/MLO: $(obj)u-boot-spl.bin >>> + $(OBJTREE)/tools/mkimage -n $(SRCTREE)/$(CONFIG_IMX_CONFIG) -T imximage \ >>> + -e $(CONFIG_SPL_TEXT_BASE) -d $< $@ >>> +endif >>> + >>> ALL-y += $(obj)u-boot-spl.bin >>> >>> ifdef CONFIG_SAMSUNG >> >> Is that really the name you want? MLO comes from some part or another >> (I've read it, just can't recall off-hand) of the IT ROM docs saying it >> will read a file named MLO. > > I know... > >> Is mx35 in the same boat? >> Or just looking >> for a common name? > > Right. It makes no sense that the binary for Freescale's SOCs has a > name, for TI another one, for...we can generates less confusion if we > uses the same name. Agreed. I guess what I'm asking is, in the TI case the ROM reads FAT and must find 'MLO'. Does mx35 do the same or is the post-build step "dd if=MLO of=/dev/... ..." and the filename doesn't matter? I'm fine with the change now, just looking for the full details. Thanks!
Am 06/09/2012 22:48, schrieb Tom Rini: > On 09/06/2012 12:59 PM, Stefano Babic wrote: >> On 06/09/2012 19:49, Tom Rini wrote: >>> On 09/06/2012 01:04 AM, Stefano Babic wrote: >>>> Signed-off-by: Stefano Babic <sbabic@denx.de> >>>> --- >>>> spl/Makefile | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/spl/Makefile b/spl/Makefile >>>> index f96c08e..77fc405 100644 >>>> --- a/spl/Makefile >>>> +++ b/spl/Makefile >>>> @@ -109,6 +109,12 @@ $(OBJTREE)/MLO: $(obj)u-boot-spl.bin >>>> -a $(CONFIG_SPL_TEXT_BASE) -d $< $@ >>>> endif >>>> >>>> +ifneq ($(CONFIG_IMX_CONFIG),) >>>> +$(OBJTREE)/MLO: $(obj)u-boot-spl.bin >>>> + $(OBJTREE)/tools/mkimage -n $(SRCTREE)/$(CONFIG_IMX_CONFIG) -T imximage \ >>>> + -e $(CONFIG_SPL_TEXT_BASE) -d $< $@ >>>> +endif >>>> + >>>> ALL-y += $(obj)u-boot-spl.bin >>>> >>>> ifdef CONFIG_SAMSUNG >>> >>> Is that really the name you want? MLO comes from some part or another >>> (I've read it, just can3't recall off-hand) of the IT ROM docs saying it >>> will read a file named MLO. >> >> I know... >> >>> Is mx35 in the same boat? >>> Or just looking >>> for a common name? >> >> Right. It makes no sense that the binary for Freescale's SOCs has a >> name, for TI another one, for...we can generates less confusion if we >> uses the same name. > > Agreed. I guess what I'm asking is, in the TI case the ROM reads FAT > and must find 'MLO'. Does mx35 do the same or No. And not only the MX35, but also the MX5/MX6. > is the post-build step > "dd if=MLO of=/dev/... ..." and the filename doesn't matter? Exactly. The ROM does not understand a filesystem, and the SPL must be stored at a fixed address in the SD card. The filename does not matter, and the SPL is not seen as file, but as a raw image. > I'm fine > with the change now, just looking for the full details. Thanks! As for Freescale the filename does not matter while for TI does, we can use for both MLO ;-) Stefano
Hello, Le Thu, 06 Sep 2012 23:57:08 +0200, stefano babic <sbabic@denx.de> a écrit : > > Agreed. I guess what I'm asking is, in the TI case the ROM reads FAT > > and must find 'MLO'. Does mx35 do the same or > > No. And not only the MX35, but also the MX5/MX6. > > > is the post-build step > > "dd if=MLO of=/dev/... ..." and the filename doesn't matter? > > Exactly. The ROM does not understand a filesystem, and the SPL must be > stored at a fixed address in the SD card. The filename does not matter, > and the SPL is not seen as file, but as a raw image. > > > I'm fine > > with the change now, just looking for the full details. Thanks! > > As for Freescale the filename does not matter while for TI does, we can > use for both MLO ;-) Then in that case I would precisely *not* use the same filename, in order to make it clear that Freescale SPL cannot be used in the same way as the TI SPL. Naming it MLO will certainly confuse users having previous experience with TI stuff: it will lead them to believe that creating a FAT filesystem and putting the MLO file in it will be the necessary steps to get this SPL loaded by the ROM code. Best regards, Thomas
On 10/09/2012 14:27, Thomas Petazzoni wrote: > Hello, > Hi Thomas, >> Exactly. The ROM does not understand a filesystem, and the SPL must be >> stored at a fixed address in the SD card. The filename does not matter, >> and the SPL is not seen as file, but as a raw image. >> >>> I'm fine >>> with the change now, just looking for the full details. Thanks! >> >> As for Freescale the filename does not matter while for TI does, we can >> use for both MLO ;-) > > Then in that case I would precisely *not* use the same filename, in > order to make it clear that Freescale SPL cannot be used in the same > way as the TI SPL. Naming it MLO will certainly confuse users having > previous experience with TI stuff: it will lead them to believe that > creating a FAT filesystem and putting the MLO file in it will be the > necessary steps to get this SPL loaded by the ROM code. Of couse, setting a common name is not a reason enough for the users to not read the manual ;-). The way TI and Freescale have chosen to boot their SOCs are and remain quite differently. The reason to have a common name is to avoid to document for each SOC which is the binary result. Maybe a more neutral name as "SPL" instead of "MLO" ? This is the first attempt to set SPL for a not-TI SOC, but hopefully other SOCs will follow, and it is better to set already some simple rules, In any case, the resulting binary is a different thing as how to put the binary into the target: SPL can be copied as MLO on the SD-Card. Tom, what do you think ? Best regards, Stefano
On Mon, Sep 10, 2012 at 5:44 AM, Stefano Babic <sbabic@denx.de> wrote: > On 10/09/2012 14:27, Thomas Petazzoni wrote: >> Hello, >> > > Hi Thomas, > >>> Exactly. The ROM does not understand a filesystem, and the SPL must be >>> stored at a fixed address in the SD card. The filename does not matter, >>> and the SPL is not seen as file, but as a raw image. >>> >>>> I'm fine >>>> with the change now, just looking for the full details. Thanks! >>> >>> As for Freescale the filename does not matter while for TI does, we can >>> use for both MLO ;-) >> >> Then in that case I would precisely *not* use the same filename, in >> order to make it clear that Freescale SPL cannot be used in the same >> way as the TI SPL. Naming it MLO will certainly confuse users having >> previous experience with TI stuff: it will lead them to believe that >> creating a FAT filesystem and putting the MLO file in it will be the >> necessary steps to get this SPL loaded by the ROM code. > > Of couse, setting a common name is not a reason enough for the users to > not read the manual ;-). The way TI and Freescale have chosen to boot > their SOCs are and remain quite differently. > > The reason to have a common name is to avoid to document for each SOC > which is the binary result. Maybe a more neutral name as "SPL" instead > of "MLO" ? This is the first attempt to set SPL for a not-TI SOC, but > hopefully other SOCs will follow, and it is better to set already some > simple rules, > > In any case, the resulting binary is a different thing as how to put the > binary into the target: SPL can be copied as MLO on the SD-Card. Tom, > what do you think ? I think Thomas raises a good point. The important thing is that 'make fooboard' produces everything to boot the board (when possible). But at the end of the day, it comes down to the user needs to understand how to boot their board. The TI MLO file can be dd'ed to an SD card and booted too, for example.
diff --git a/spl/Makefile b/spl/Makefile index f96c08e..77fc405 100644 --- a/spl/Makefile +++ b/spl/Makefile @@ -109,6 +109,12 @@ $(OBJTREE)/MLO: $(obj)u-boot-spl.bin -a $(CONFIG_SPL_TEXT_BASE) -d $< $@ endif +ifneq ($(CONFIG_IMX_CONFIG),) +$(OBJTREE)/MLO: $(obj)u-boot-spl.bin + $(OBJTREE)/tools/mkimage -n $(SRCTREE)/$(CONFIG_IMX_CONFIG) -T imximage \ + -e $(CONFIG_SPL_TEXT_BASE) -d $< $@ +endif + ALL-y += $(obj)u-boot-spl.bin ifdef CONFIG_SAMSUNG
Signed-off-by: Stefano Babic <sbabic@denx.de> --- spl/Makefile | 6 ++++++ 1 file changed, 6 insertions(+)