[U-Boot,v1,8/8] OMAP3: mt_ventoux: added video support

Signed-off-by: Stefano Babic <sbabic@denx.de>
---
 board/teejet/mt_ventoux/mt_ventoux.c |   91 ++++++++++++++++++++++++++++++++++
 board/teejet/mt_ventoux/mt_ventoux.h |    2 +-
 include/configs/mt_ventoux.h         |   16 ++++++
 3 files changed, 108 insertions(+), 1 deletion(-)

Hello Stefano,

On 28.08.2012 09:46, Stefano Babic wrote:
> Signed-off-by: Stefano Babic<sbabic@denx.de>
> ---
>   board/teejet/mt_ventoux/mt_ventoux.c |   91 ++++++++++++++++++++++++++++++++++
>   board/teejet/mt_ventoux/mt_ventoux.h |    2 +-
>   include/configs/mt_ventoux.h         |   16 ++++++
>   3 files changed, 108 insertions(+), 1 deletion(-)
>
> diff --git a/board/teejet/mt_ventoux/mt_ventoux.c b/board/teejet/mt_ventoux/mt_ventoux.c
> index 814e72f..a2bda4b 100644
> --- a/board/teejet/mt_ventoux/mt_ventoux.c
> +++ b/board/teejet/mt_ventoux/mt_ventoux.c
> @@ -21,13 +21,17 @@
>
>   #include<common.h>
>   #include<netdev.h>
> +#include<malloc.h>
>   #include<fpga.h>
> +#include<video_fb.h>
>   #include<asm/io.h>
>   #include<asm/arch/mem.h>
>   #include<asm/arch/mux.h>
>   #include<asm/arch/sys_proto.h>
>   #include<asm/omap_gpio.h>
>   #include<asm/arch/mmc_host_def.h>
> +#include<asm/arch/dss.h>
> +#include<asm/arch/clocks.h>
>   #include<i2c.h>
>   #include<spartan3.h>
>   #include<asm/gpio.h>
> @@ -53,6 +57,50 @@ DECLARE_GLOBAL_DATA_PTR;
>   #define FPGA_INIT	119
>   #define FPGA_DONE	154
>
> +#define LCD_PWR		138
> +#define LCD_PON_PIN	139
> +
> +#if defined(CONFIG_VIDEO)&&  !defined(CONFIG_SPL_BUILD)
> +static struct {
> +	u32 xres;
> +	u32 yres;
> +} panel_resolution[] = {
> +	{ 480, 272 },
> +	{ 800, 480 }
> +};
> +
> +static struct panel_config lcd_cfg[] = {
> +	{
> +	.timing_h       =  ((4 /* hpb */ - 1)<<  20) |
> +			((8 /*hfp */- 1)<<  8) |
> +			(41 /* hsw */ - 1), /* Horizontal timing */

Could we use here a define, something like this:

#define PANEL_TIMING_H(bp, fp, sw) (((bp - 1) << 20) | ((fp - 1) << 8) | (sw - 1))

                 .panel_config = {
                         .timing_h       = PANEL_TIMING_H(4, 8, 41),

> +	.timing_v       = (2 /*vbp */<<  24) |
                                          ^^
                                          Is this correct? In the manual I
                                          see for the timing H and V settings
                                          the same bitpositions!

> +			(4 /* vfp */<<  8) |
> +			(10 - 1), /* Vertical timing */

#define PANEL_TIMING_V(bp, fp, sw) (((bp) << 20) | ((fp) << 8) | (sw - 1))

and here too ?

> +	.pol_freq       = 0x00000000, /* Pol Freq */
> +	.divisor        = 0x0001000d, /* 33Mhz Pixel Clock */
> +	.panel_type     = 0x01, /* TFT */
> +	.data_lines     = 0x03, /* 24 Bit RGB */
> +	.load_mode      = 0x02, /* Frame Mode */
> +	.panel_color	= 0,
> +	},
> +	{
> +	.timing_h       =  ((20 /* hpb */ - 1)<<  20) |
> +			((192 /*hfp */- 1)<<  8) |
> +			(4 /* hsw */ - 1), /* Horizontal timing */

and here ...

> +	.timing_v       = (2 /*vbp */<<  24) |
> +			(20 /* vfp */<<  8) |
> +			(10 /* vsw */ - 1), /* Vertical timing */

and here.

> +	.pol_freq       = 0x00004000, /* Pol Freq */
> +	.divisor        = 0x0001000E, /* 36Mhz Pixel Clock */
> +	.panel_type     = 0x01, /* TFT */
> +	.data_lines     = 0x03, /* 24 Bit RGB */
> +	.load_mode      = 0x02, /* Frame Mode */
> +	.panel_color	= 0,
> +	}
> +};
> +#endif
[...]

bye,
Heiko

On 28/08/2012 10:11, Heiko Schocher wrote:
> Hello Stefano,
> 

Hi Heiko,

>> +static struct panel_config lcd_cfg[] = {
>> +    {
>> +    .timing_h       =  ((4 /* hpb */ - 1)<<  20) |
>> +            ((8 /*hfp */- 1)<<  8) |
>> +            (41 /* hsw */ - 1), /* Horizontal timing */
> 
> Could we use here a define, something like this:
> 
> #define PANEL_TIMING_H(bp, fp, sw) (((bp - 1) << 20) | ((fp - 1) << 8) |
> (sw - 1))

Agree - and put it in a common header (arch/dss.h), making it accessible
to all boards. And we need only one macro PANEL_TIMING, the register has
the same layout.

I'll do in V2.

> 
>                 .panel_config = {
>                         .timing_h       = PANEL_TIMING_H(4, 8, 41),
> 
>> +    .timing_v       = (2 /*vbp */<<  24) |
>                                          ^^
>                                          Is this correct? In the manual I
>                                          see for the timing H and V
> settings
>                                          the same bitpositions!
> 

This is not correct, thanks. It has no influence on my hardware because
it simply increments vbp, but I will fix it.

Stefano

Hello Stefano,

Could we use here a define, something like this:

#define PANEL_TIMING_H(bp, fp, sw) (((bp - 1) << 20) | ((fp - 1) << 8) |
(sw - 1))

> Agree - and put it in a common header (arch/dss.h), making it accessible
> to all boards. And we need only one macro PANEL_TIMING, the register has
> the same layout.
>
> I'll do in V2.
>
The hbp, hfp, hsw, vsw all have a "(program to value minus 1)."
vbp and vfp don't, you can set those to zero.

So while the layout is the same, the meaning isn't. To make the values
match the lcd specification, I would prefer to have the separate
defines.

Regards,
Jeroen

On 28/08/2012 10:47, Jeroen Hofstee wrote:
> Hello Stefano,
> 
> Could we use here a define, something like this:
> 
> #define PANEL_TIMING_H(bp, fp, sw) (((bp - 1) << 20) | ((fp - 1) << 8) |
> (sw - 1))
> 
>> Agree - and put it in a common header (arch/dss.h), making it accessible
>> to all boards. And we need only one macro PANEL_TIMING, the register has
>> the same layout.
>>
>> I'll do in V2.
>>
> The hbp, hfp, hsw, vsw all have a "(program to value minus 1)."
> vbp and vfp don't, you can set those to zero.
> 
> So while the layout is the same, the meaning isn't. To make the values
> match the lcd specification, I would prefer to have the separate
> defines.

That's right - I will put two separate defines.

Regards,
Stefano