From patchwork Wed Aug 22 19:25:40 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matt Sealey X-Patchwork-Id: 179379 X-Patchwork-Delegate: sbabic@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id C5DCD2C009D for ; Thu, 23 Aug 2012 05:26:54 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 6DAAE2808A; Wed, 22 Aug 2012 21:26:53 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rPj-3Pt4fDxD; Wed, 22 Aug 2012 21:26:51 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 2C67028088; Wed, 22 Aug 2012 21:26:50 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id E9E812807E for ; Wed, 22 Aug 2012 21:26:25 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id YQLxIT7dJYEF for ; Wed, 22 Aug 2012 21:26:25 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-yw0-f44.google.com (mail-yw0-f44.google.com [209.85.213.44]) by theia.denx.de (Postfix) with ESMTPS id 2FCC128080 for ; Wed, 22 Aug 2012 21:26:23 +0200 (CEST) Received: by yhq56 with SMTP id 56so1005900yhq.3 for ; Wed, 22 Aug 2012 12:26:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=AYRjpqEaEsdlrFYtreEolNbQWx6LCREhRtxuYv2qG7M=; b=kImutS5wZ6Dc4fIL710fcRWhQ82khjumCUNK5rXp1ffDpwowxznegG8r5E++VmFqsL im302xblnnJFDMg73BHNx9uez5KsfwSrHLfzfK2WCUalUu1AnnHpKScwT61LLd8um9sg e/hLp2KQuOJO6o1ZrTA/MNtLzfu03lCyPeuB2Et3bPbK61djEgyLE8JU3ZjSWBw/Wc1L VpQiUXlipaluseg6luerSohcrmbaScoZMMVB9GbeMELGQ8bsBAaQxKQIwSB6JJggHnmR T27azkxslzgyXGlXeDwdCeYQNzpuy2exQtRzkNsYd3awse+UB8yY5KFjIqJ+XoRG9wSe WRSA== Received: by 10.60.19.168 with SMTP id g8mr16894907oee.134.1345663582236; Wed, 22 Aug 2012 12:26:22 -0700 (PDT) Received: from shinji.genesi-usa.com ([199.193.222.22]) by mx.google.com with ESMTPS id hz6sm4663654obb.1.2012.08.22.12.26.21 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 22 Aug 2012 12:26:21 -0700 (PDT) From: Matt Sealey To: U-Boot ML Date: Wed, 22 Aug 2012 14:25:40 -0500 Message-Id: <1345663541-26682-3-git-send-email-matt@genesi-usa.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1345663541-26682-1-git-send-email-matt@genesi-usa.com> References: <1345663541-26682-1-git-send-email-matt@genesi-usa.com> X-Gm-Message-State: ALoCoQk7rKqPsZ9F7nzn+n8l6ZNWfg291oznU/Jq6ciXGMeiMPdLzEh65+UIZgBYp90PXonmQtFy Subject: [U-Boot] [PATCH 3/4] efikamx: configure Smarttop PCBID and LED pads in DCD for convenience X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de PCBID pads seem to need time to settle due to external pulldowns, otherwise we are reading floating GPIO pins with implicit pad pullups and get the wrong data. However we can't "wait" at the time we need them before relocation, since timers are not available. The time taken to get from DCD to the code requiring the pads set seems to be more than long enough (even with caches enabled). We have space in the DCD due to the DDR settings changes to configure all the pad settings we need for this, plus the LED pad settings too which reduces the amount of code required later on. Signed-off-by: Matt Sealey Acked-by: Stefano Babic --- board/genesi/mx51_efikamx/imximage_mx.cfg | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/board/genesi/mx51_efikamx/imximage_mx.cfg b/board/genesi/mx51_efikamx/imximage_mx.cfg index ea6b271..38fa760 100644 --- a/board/genesi/mx51_efikamx/imximage_mx.cfg +++ b/board/genesi/mx51_efikamx/imximage_mx.cfg @@ -45,6 +45,16 @@ BOOT_FROM spi # Address absolute address of the register # value value to be stored in the register +# Essential GPIO settings to be done as early as possible +# PCBIDn pad settings are all the defaults except #2 which needs HVE off +DATA 4 0x73fa8134 0x3 # PCBID0 ALT3 GPIO 3_16 +DATA 4 0x73fa8130 0x3 # PCBID1 ALT3 GPIO 3_17 +DATA 4 0x73fa8128 0x3 # PCBID2 ALT3 GPIO 3_11 +DATA 4 0x73fa8504 0xe4 # PCBID2 PAD ~HVE +DATA 4 0x73fa8198 0x3 # LED0 ALT3 GPIO 3_13 +DATA 4 0x73fa81c4 0x3 # LED1 ALT3 GPIO 3_14 +DATA 4 0x73fa81c8 0x3 # LED2 ALT3 GPIO 3_15 + # DDR bus IOMUX PAD settings DATA 4 0x73fa850c 0x20c5 # SDODT1 DATA 4 0x73fa8510 0x20c5 # SDODT0