From patchwork Thu Jul 5 19:53:39 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Troy Kisky X-Patchwork-Id: 169254 X-Patchwork-Delegate: hs@denx.de Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id BC9212C007F for ; Fri, 6 Jul 2012 05:56:17 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 1830A2812A; Thu, 5 Jul 2012 21:55:51 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FoT5JVYCy-IG; Thu, 5 Jul 2012 21:55:50 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id C8F672814C; Thu, 5 Jul 2012 21:54:28 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 7934128109 for ; Thu, 5 Jul 2012 21:54:15 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 0J32LHGeYs92 for ; Thu, 5 Jul 2012 21:54:14 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-pb0-f44.google.com (mail-pb0-f44.google.com [209.85.160.44]) by theia.denx.de (Postfix) with ESMTPS id 6DC6C28102 for ; Thu, 5 Jul 2012 21:54:04 +0200 (CEST) Received: by pbcwy7 with SMTP id wy7so12330720pbc.3 for ; Thu, 05 Jul 2012 12:54:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=ep0STqhL6oCR0P4ou968NVdfn5JtNfN8YsPJ82MW61U=; b=aN8/nKPiU0e/Nu7y59Nq8GXDvyGa+38KMP0Emx19q0iF1jNuuDKXeuJdQrIxyZ8mP3 CuqQEFrE7B9ojrxaA8mn/M+RGwHGW/533cAJDhCOXJ65hyHk35/q4yP9lUfE1/cQEFEe mcUkrChxX2TuXLAtCOdumaeNDH00ZEehIgDDNP7HpkeYGzEAv7dr37TsHfev7AeX3Hhk JtejMOonltfckYVIP7cM/IWfur446+gq54zojqTzGJn6HusMB9zml5aqItwj27+LAVke Wq1oT0VSaZZ1eZ9XwJOQN4dL3LbzHTox745bRtvAjHZ4K4N6V+ALOZqhj4l7t0axNthl gASQ== Received: by 10.68.192.39 with SMTP id hd7mr30321986pbc.97.1341518041550; Thu, 05 Jul 2012 12:54:01 -0700 (PDT) Received: from officeserver-2 ([70.96.116.236]) by mx.google.com with ESMTPS id ve4sm20313093pbc.55.2012.07.05.12.53.59 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 05 Jul 2012 12:54:00 -0700 (PDT) Received: from tkisky by officeserver-2 with local (Exim 4.76) (envelope-from ) id 1Sms7p-0006pP-6e; Thu, 05 Jul 2012 12:54:05 -0700 From: Troy Kisky To: u-boot@lists.denx.de, Heiko Schocher , sbabic@denx.de Date: Thu, 5 Jul 2012 12:53:39 -0700 Message-Id: <1341518043-26191-1-git-send-email-troy.kisky@boundarydevices.com> X-Mailer: git-send-email 1.7.9.5 X-Gm-Message-State: ALoCoQmn9gU0ZwQolCl0Gy+pECiYuiN9MJ1hfJk2E7uLXplcspUKVaLDD7laJ8VhLEWWEcgFEFvK Cc: r49496@freescale.com Subject: [U-Boot] [PATCH V2 01/25] mxc_i2c: fix i2c_imx_stop X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de Instead of clearing 2 bits, all the other bits were set because '|=' was used instead of '&='. Signed-off-by: Troy Kisky Acked-by: Marek Vasut Acked-by: Stefano Babic --- V2: add acks --- drivers/i2c/mxc_i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/mxc_i2c.c b/drivers/i2c/mxc_i2c.c index fc68062..c0c45fd 100644 --- a/drivers/i2c/mxc_i2c.c +++ b/drivers/i2c/mxc_i2c.c @@ -264,7 +264,7 @@ void i2c_imx_stop(void) /* Stop I2C transaction */ temp = readb(&i2c_regs->i2cr); - temp |= ~(I2CR_MSTA | I2CR_MTX); + temp &= ~(I2CR_MSTA | I2CR_MTX); writeb(temp, &i2c_regs->i2cr); i2c_imx_bus_busy(0);