From patchwork Mon May 7 20:42:57 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 157450 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from theia.denx.de (theia.denx.de [85.214.87.163]) by ozlabs.org (Postfix) with ESMTP id C049BB6FA5 for ; Tue, 8 May 2012 06:43:19 +1000 (EST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 2390A280FA; Mon, 7 May 2012 22:43:17 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id JLyU68McXxlG; Mon, 7 May 2012 22:43:16 +0200 (CEST) Received: from theia.denx.de (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id A577A280FB; Mon, 7 May 2012 22:43:13 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by theia.denx.de (Postfix) with ESMTP id 702EF280FB for ; Mon, 7 May 2012 22:43:11 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at theia.denx.de Received: from theia.denx.de ([127.0.0.1]) by localhost (theia.denx.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id WUKaBggEupAb for ; Mon, 7 May 2012 22:43:10 +0200 (CEST) X-policyd-weight: NOT_IN_SBL_XBL_SPAMHAUS=-1.5 NOT_IN_SPAMCOP=-1.5 NOT_IN_BL_NJABL=-1.5 (only DNSBL check requested) Received: from mail-yw0-f44.google.com (mail-yw0-f44.google.com [209.85.213.44]) by theia.denx.de (Postfix) with ESMTPS id 84544280FA for ; Mon, 7 May 2012 22:43:08 +0200 (CEST) Received: by yhq56 with SMTP id 56so4418550yhq.3 for ; Mon, 07 May 2012 13:43:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=1dvOdJQc4grmy9ouH0MCo1d8aTvwNyCIQU88UDFVZPI=; b=U74qYi5HdR1uZ01r+WNtQXz1Wdmp/3iipwnYCNXyFosMdcjBdzB5VEuMbhDcfcvryu Rst3g3sSr22UhR25v8icEkYwUSNTXcEF3/aace+1SOpr0j9MDRl0e88SmztPnVOsnKzu x60pPC9/T4SXtSqw72hMhJVXXtMtTAWJl8vIWXDa/OlfCsV23zGHMOTf0sIPrrQF/1M5 hSIxdtAIkq1/y/MUxJNTtK35ByjZsmdhBEeRYtx7eWPwo1H6k8n0/dOdx/Tjaa/D9V3q 3tyVZRK8GfzzSm3kMHvKc2h+ej1ja3PdEwCFrPKpmd9dPFif4h4Gca32sJ/FwiM9soCw qGYw== Received: by 10.236.75.232 with SMTP id z68mr22226836yhd.6.1336423387786; Mon, 07 May 2012 13:43:07 -0700 (PDT) Received: from localhost.localdomain ([201.82.161.72]) by mx.google.com with ESMTPS id i7sm29332371ani.17.2012.05.07.13.43.04 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 07 May 2012 13:43:07 -0700 (PDT) From: Fabio Estevam To: u-boot@lists.denx.de Date: Mon, 7 May 2012 17:42:57 -0300 Message-Id: <1336423377-15718-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 1.7.1 Cc: Fabio Estevam Subject: [U-Boot] [PATCH] mx53loco: Remove unneeded gpio_set_value() X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.11 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: u-boot-bounces@lists.denx.de Errors-To: u-boot-bounces@lists.denx.de From: Fabio Estevam There is no need to set the VBUS power enable to 0 first and then to 1. Set it to 1 in the gpio_direction_output() function. While at it, use the standard naming convention for the GPIO comment. Signed-off-by: Fabio Estevam --- board/freescale/mx53loco/mx53loco.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/board/freescale/mx53loco/mx53loco.c b/board/freescale/mx53loco/mx53loco.c index 2f2c00c..c9d0c19 100644 --- a/board/freescale/mx53loco/mx53loco.c +++ b/board/freescale/mx53loco/mx53loco.c @@ -92,10 +92,9 @@ static void setup_iomux_uart(void) #ifdef CONFIG_USB_EHCI_MX5 int board_ehci_hcd_init(int port) { - /* request VBUS power enable pin, GPIO[8}, gpio7 */ + /* request VBUS power enable pin, GPIO7_8 */ mxc_request_iomux(MX53_PIN_ATA_DA_2, IOMUX_CONFIG_ALT1); - gpio_direction_output(IOMUX_TO_GPIO(MX53_PIN_ATA_DA_2), 0); - gpio_set_value(IOMUX_TO_GPIO(MX53_PIN_ATA_DA_2), 1); + gpio_direction_output(IOMUX_TO_GPIO(MX53_PIN_ATA_DA_2), 1); return 0; } #endif