| Message ID | 1335652120-2646-1-git-send-email-marex@denx.de |
|---|---|
| State | Accepted |
| Headers | show |
Dear Marek Vasut, In message <1335652120-2646-1-git-send-email-marex@denx.de> you wrote: > cmd_nand.c: In function ‘arg_off_size’: > cmd_nand.c:216:5: warning: ‘maxsize’ may be used uninitialized in this function [-Wmaybe-uninitialized] > > Signed-off-by: Marek Vasut <marex@denx.de> > Cc: Scott Wood <scottwood@freescale.com> > Cc: Wolfgang Denk <wd@denx.de> > --- > common/cmd_nand.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks. > NOTE: Why does this emit these blahs about UTF8? I just noticed git started > behaving weird on me, anyone can give me a hint how to disable these? Yes, I think I can: don't use funny characters like these quotes around "arg_off_size" and "maxsize" in the commit messages. You will also notice that patchwork has problems with these, like here: Traceback (most recent call last): File "/home/wd/bin/pwclient", line 466, in <module> main() File "/home/wd/bin/pwclient", line 449, in main action_apply(rpc, patch_id) File "/home/wd/bin/pwclient", line 264, in action_apply proc.communicate(s) File "/usr/lib64/python2.7/subprocess.py", line 737, in communicate self.stdin.write(input) UnicodeEncodeError: 'ascii' codec can't encode character u'\u2018' in position 450: ordinal not in range(128) Best regards, Wolfgang Denk
Dear Wolfgang Denk, > Dear Marek Vasut, > > In message <1335652120-2646-1-git-send-email-marex@denx.de> you wrote: > > cmd_nand.c: In function ‘arg_off_size’: > > cmd_nand.c:216:5: warning: ‘maxsize’ may be used uninitialized in this > > function [-Wmaybe-uninitialized] > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > Cc: Scott Wood <scottwood@freescale.com> > > Cc: Wolfgang Denk <wd@denx.de> > > --- > > > > common/cmd_nand.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Applied, thanks. > > > NOTE: Why does this emit these blahs about UTF8? I just noticed git > > started behaving weird on me, anyone can give me a hint how to disable > > these? > > Yes, I think I can: don't use funny characters like these quotes > around "arg_off_size" and "maxsize" in the commit messages. Looking closer at it, it's not standard "'" quote character, what the heck. But $LANG (and $LANGUAGE) is set to en_US.UTF8 . Damned, I'll try to find the root cause, but I feel like overcomplicated KDE4 combined with who-knows-what will win this battle :-/ > You will > also notice that patchwork has problems with these, like here: > > Traceback (most recent call last): > File "/home/wd/bin/pwclient", line 466, in <module> > main() > File "/home/wd/bin/pwclient", line 449, in main > action_apply(rpc, patch_id) > File "/home/wd/bin/pwclient", line 264, in action_apply > proc.communicate(s) > File "/usr/lib64/python2.7/subprocess.py", line 737, in communicate > self.stdin.write(input) > UnicodeEncodeError: 'ascii' codec can't encode character u'\u2018' in > position 450: ordinal not in range(128) > > > > Best regards, > > Wolfgang Denk Best regards, Marek Vasut
Dear Marek Vasut, In message <201204291511.36960.marex@denx.de> you wrote: > > > Yes, I think I can: don't use funny characters like these quotes > > around "arg_off_size" and "maxsize" in the commit messages. > > Looking closer at it, it's not standard "'" quote character, what the heck. But > $LANG (and $LANGUAGE) is set to en_US.UTF8 . Damned, I'll try to find the root > cause, but I feel like overcomplicated KDE4 combined with who-knows-what will > win this battle :-/ I don't know either how to set LC_MESSAGES or even LC_ALL or anything else to prevent gcc from issuing such characters; so I guess we have to maually filter/convert any such messages instead of just copy & paste error messages ... Best regards, Wolfgang Denk
Dear Wolfgang Denk, > Dear Marek Vasut, > > In message <201204291511.36960.marex@denx.de> you wrote: > > > Yes, I think I can: don't use funny characters like these quotes > > > around "arg_off_size" and "maxsize" in the commit messages. > > > > Looking closer at it, it's not standard "'" quote character, what the > > heck. But $LANG (and $LANGUAGE) is set to en_US.UTF8 . Damned, I'll try > > to find the root cause, but I feel like overcomplicated KDE4 combined > > with who-knows-what will win this battle :-/ > > I don't know either how to set LC_MESSAGES or even LC_ALL or anything > else to prevent gcc from issuing such characters; so I guess we have > to maually filter/convert any such messages instead of just copy & > paste error messages ... Yes, I agree ... I'll keep my eyes peeled. > Best regards, > > Wolfgang Denk Best regards, Marek Vasut
diff --git a/common/cmd_nand.c b/common/cmd_nand.c index bae630d..0fd3a6c 100644 --- a/common/cmd_nand.c +++ b/common/cmd_nand.c @@ -191,7 +191,7 @@ static int arg_off_size(int argc, char *const argv[], int *idx, loff_t *off, loff_t *size) { int ret; - loff_t maxsize; + loff_t maxsize = 0; if (argc == 0) { *off = 0;
cmd_nand.c: In function ‘arg_off_size’: cmd_nand.c:216:5: warning: ‘maxsize’ may be used uninitialized in this function [-Wmaybe-uninitialized] Signed-off-by: Marek Vasut <marex@denx.de> Cc: Scott Wood <scottwood@freescale.com> Cc: Wolfgang Denk <wd@denx.de> --- common/cmd_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) NOTE: Why does this emit these blahs about UTF8? I just noticed git started behaving weird on me, anyone can give me a hint how to disable these?